All of lore.kernel.org
 help / color / mirror / Atom feed
From: Guo Ren <guoren@kernel.org>
To: Han Gao <gaohan@iscas.ac.cn>
Cc: Paul Walmsley <pjw@kernel.org>,
	Palmer Dabbelt <palmer@dabbelt.com>,
	Albert Ou <aou@eecs.berkeley.edu>,
	Alexandre Ghiti <alex@ghiti.fr>,
	linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org,
	Han Gao <rabenda.cn@gmail.com>,
	stable@vger.kernel.org
Subject: Re: [PATCH] riscv: compat: fix COMPAT_UTS_MACHINE definition
Date: Wed, 28 Jan 2026 20:17:18 -0500	[thread overview]
Message-ID: <aXq1HthMYkBGXx/l@gmail.com> (raw)
In-Reply-To: <20260127190711.2264664-1-gaohan@iscas.ac.cn>

On Wed, Jan 28, 2026 at 03:07:11AM +0800, Han Gao wrote:
> The COMPAT_UTS_MACHINE for riscv was incorrectly defined as "riscv".
> Change it to "riscv32" to reflect the correct 32-bit compat name.
> 
> Fixes: 06d0e3723647 ("riscv: compat: Add basic compat data type implementation")
> Cc: stable@vger.kernel.org
> 
> Signed-off-by: Han Gao <gaohan@iscas.ac.cn>
> ---
>  arch/riscv/include/asm/compat.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/riscv/include/asm/compat.h b/arch/riscv/include/asm/compat.h
> index 6081327e55f5..28e115eed218 100644
> --- a/arch/riscv/include/asm/compat.h
> +++ b/arch/riscv/include/asm/compat.h
> @@ -2,7 +2,7 @@
>  #ifndef __ASM_COMPAT_H
>  #define __ASM_COMPAT_H
>  
> -#define COMPAT_UTS_MACHINE	"riscv\0\0"
> +#define COMPAT_UTS_MACHINE	"riscv32\0\0"
Good catch, my typo. The UTS_MACHINE is riscv32 in Makefile. Thx for fixup.

Reviewed-by: Guo Ren (Alibaba Damo Academy) <guoren@kernel.org>


>  
>  /*
>   * Architecture specific compatibility types
> -- 
> 2.47.3
> 
> 
> _______________________________________________
> linux-riscv mailing list
> linux-riscv@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-riscv
> 

_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

WARNING: multiple messages have this Message-ID (diff)
From: Guo Ren <guoren@kernel.org>
To: Han Gao <gaohan@iscas.ac.cn>
Cc: Paul Walmsley <pjw@kernel.org>,
	Palmer Dabbelt <palmer@dabbelt.com>,
	Albert Ou <aou@eecs.berkeley.edu>,
	Alexandre Ghiti <alex@ghiti.fr>,
	linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org,
	Han Gao <rabenda.cn@gmail.com>,
	stable@vger.kernel.org
Subject: Re: [PATCH] riscv: compat: fix COMPAT_UTS_MACHINE definition
Date: Wed, 28 Jan 2026 20:17:18 -0500	[thread overview]
Message-ID: <aXq1HthMYkBGXx/l@gmail.com> (raw)
In-Reply-To: <20260127190711.2264664-1-gaohan@iscas.ac.cn>

On Wed, Jan 28, 2026 at 03:07:11AM +0800, Han Gao wrote:
> The COMPAT_UTS_MACHINE for riscv was incorrectly defined as "riscv".
> Change it to "riscv32" to reflect the correct 32-bit compat name.
> 
> Fixes: 06d0e3723647 ("riscv: compat: Add basic compat data type implementation")
> Cc: stable@vger.kernel.org
> 
> Signed-off-by: Han Gao <gaohan@iscas.ac.cn>
> ---
>  arch/riscv/include/asm/compat.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/riscv/include/asm/compat.h b/arch/riscv/include/asm/compat.h
> index 6081327e55f5..28e115eed218 100644
> --- a/arch/riscv/include/asm/compat.h
> +++ b/arch/riscv/include/asm/compat.h
> @@ -2,7 +2,7 @@
>  #ifndef __ASM_COMPAT_H
>  #define __ASM_COMPAT_H
>  
> -#define COMPAT_UTS_MACHINE	"riscv\0\0"
> +#define COMPAT_UTS_MACHINE	"riscv32\0\0"
Good catch, my typo. The UTS_MACHINE is riscv32 in Makefile. Thx for fixup.

Reviewed-by: Guo Ren (Alibaba Damo Academy) <guoren@kernel.org>


>  
>  /*
>   * Architecture specific compatibility types
> -- 
> 2.47.3
> 
> 
> _______________________________________________
> linux-riscv mailing list
> linux-riscv@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-riscv
> 

  reply	other threads:[~2026-01-29  1:17 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-27 19:07 [PATCH] riscv: compat: fix COMPAT_UTS_MACHINE definition Han Gao
2026-01-27 19:07 ` Han Gao
2026-01-29  1:17 ` Guo Ren [this message]
2026-01-29  1:17   ` Guo Ren
2026-01-29  8:24 ` Paul Walmsley
2026-01-29  8:24   ` Paul Walmsley

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aXq1HthMYkBGXx/l@gmail.com \
    --to=guoren@kernel.org \
    --cc=alex@ghiti.fr \
    --cc=aou@eecs.berkeley.edu \
    --cc=gaohan@iscas.ac.cn \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-riscv@lists.infradead.org \
    --cc=palmer@dabbelt.com \
    --cc=pjw@kernel.org \
    --cc=rabenda.cn@gmail.com \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.