From: "Vishal Moola (Oracle)" <vishal.moola@gmail.com>
To: Matthew Wilcox <willy@infradead.org>
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, x86@kernel.org,
"Mike Rapoport (Microsoft)" <rppt@kernel.org>,
akpm@linux-foundation.org,
Dave Hansen <dave.hansen@linux.intel.com>,
Andy Lutomirski <luto@kernel.org>,
Peter Zijlstra <peterz@infradead.org>
Subject: Re: [PATCH v5 2/4] x86/mm/pat: Convert pte code to use ptdescs
Date: Wed, 11 Feb 2026 14:23:49 -0800 [thread overview]
Message-ID: <aY0BddJ9Xm6OsC_-@fedora> (raw)
In-Reply-To: <aYz65w4TP37_t97o@casper.infradead.org>
On Wed, Feb 11, 2026 at 09:55:51PM +0000, Matthew Wilcox wrote:
> On Wed, Feb 11, 2026 at 11:52:31AM -0800, Vishal Moola (Oracle) wrote:
> > -static bool try_to_free_pte_page(pte_t *pte)
> > +static bool try_to_free_pte(pte_t *pte)
>
> I don't like this name though. You're not freeing a single PTE,
> you're freeing a level of page tables. How about
> try_to_free_pte_table()?
Ah, right. That would make sense to me.
Dave doesn't want the renaming at all[1], so I'm planning to leave it as
try_to_free_pte_page() though.
[1] https://lore.kernel.org/linux-mm/20260211195233.368497-1-vishal.moola@gmail.com/T/#m72f1d8d91b16f0693cca4271cc8685d2337372d7
next prev parent reply other threads:[~2026-02-11 22:23 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-11 19:52 [PATCH v5 0/4] Convert 64-bit x86/mm/pat to ptdescs Vishal Moola (Oracle)
2026-02-11 19:52 ` [PATCH v5 1/4] mm: Add address apis for ptdescs Vishal Moola (Oracle)
2026-02-11 20:13 ` Dave Hansen
2026-02-11 21:54 ` Matthew Wilcox
2026-02-11 22:18 ` Vishal Moola (Oracle)
2026-02-12 0:07 ` Vishal Moola (Oracle)
2026-02-18 20:23 ` Vishal Moola (Oracle)
2026-02-18 20:27 ` Dave Hansen
2026-02-11 19:52 ` [PATCH v5 2/4] x86/mm/pat: Convert pte code to use ptdescs Vishal Moola (Oracle)
2026-02-11 21:55 ` Matthew Wilcox
2026-02-11 22:23 ` Vishal Moola (Oracle) [this message]
2026-02-11 23:04 ` Dave Hansen
2026-02-11 19:52 ` [PATCH v5 3/4] x86/mm/pat: Convert pmd " Vishal Moola (Oracle)
2026-02-11 20:07 ` Dave Hansen
2026-02-11 21:45 ` Vishal Moola (Oracle)
2026-02-11 19:52 ` [PATCH v5 4/4] x86/mm/pat: Convert split_large_page() " Vishal Moola (Oracle)
2026-02-11 21:59 ` Matthew Wilcox
2026-02-11 22:38 ` Vishal Moola (Oracle)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aY0BddJ9Xm6OsC_-@fedora \
--to=vishal.moola@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=dave.hansen@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=luto@kernel.org \
--cc=peterz@infradead.org \
--cc=rppt@kernel.org \
--cc=willy@infradead.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.