From: "Vishal Moola (Oracle)" <vishal.moola@gmail.com>
To: Dave Hansen <dave.hansen@intel.com>
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, x86@kernel.org,
"Mike Rapoport (Microsoft)" <rppt@kernel.org>,
akpm@linux-foundation.org,
"Matthew Wilcox (Oracle)" <willy@infradead.org>,
Dave Hansen <dave.hansen@linux.intel.com>,
Andy Lutomirski <luto@kernel.org>,
Peter Zijlstra <peterz@infradead.org>
Subject: Re: [PATCH v5 3/4] x86/mm/pat: Convert pmd code to use ptdescs
Date: Wed, 11 Feb 2026 13:45:13 -0800 [thread overview]
Message-ID: <aYz4ac9cCW3EyhAC@fedora> (raw)
In-Reply-To: <29599d4e-c2c7-4f40-a444-28dcc3768ce4@intel.com>
On Wed, Feb 11, 2026 at 12:07:05PM -0800, Dave Hansen wrote:
> On 2/11/26 11:52, Vishal Moola (Oracle) wrote:
> > Also, rename *_pmd_page() functions to *_pmd(). Rename them now to avoid
> > any confusion later. Eventually these allocations will be backed by a
> > ptdesc not a page, but that's not important to callers either.
>
> So, pages are still a thing, whether the API says 'struct page' or not.
> The hardware kinda uses pages for page tables. ;)
>
> Could we please leave out the unnecessary churn from the renames?
Yeah I'll drop the renames. I thought it'd be better for
correctness-sake, as the idea is to "allocate memory for a page table"
rather than "allocate a generic page for a page table."
As long as its using the right APIs the naming doesn't really matter
to me.
next prev parent reply other threads:[~2026-02-11 21:45 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-11 19:52 [PATCH v5 0/4] Convert 64-bit x86/mm/pat to ptdescs Vishal Moola (Oracle)
2026-02-11 19:52 ` [PATCH v5 1/4] mm: Add address apis for ptdescs Vishal Moola (Oracle)
2026-02-11 20:13 ` Dave Hansen
2026-02-11 21:54 ` Matthew Wilcox
2026-02-11 22:18 ` Vishal Moola (Oracle)
2026-02-12 0:07 ` Vishal Moola (Oracle)
2026-02-18 20:23 ` Vishal Moola (Oracle)
2026-02-18 20:27 ` Dave Hansen
2026-02-11 19:52 ` [PATCH v5 2/4] x86/mm/pat: Convert pte code to use ptdescs Vishal Moola (Oracle)
2026-02-11 21:55 ` Matthew Wilcox
2026-02-11 22:23 ` Vishal Moola (Oracle)
2026-02-11 23:04 ` Dave Hansen
2026-02-11 19:52 ` [PATCH v5 3/4] x86/mm/pat: Convert pmd " Vishal Moola (Oracle)
2026-02-11 20:07 ` Dave Hansen
2026-02-11 21:45 ` Vishal Moola (Oracle) [this message]
2026-02-11 19:52 ` [PATCH v5 4/4] x86/mm/pat: Convert split_large_page() " Vishal Moola (Oracle)
2026-02-11 21:59 ` Matthew Wilcox
2026-02-11 22:38 ` Vishal Moola (Oracle)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aYz4ac9cCW3EyhAC@fedora \
--to=vishal.moola@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=dave.hansen@intel.com \
--cc=dave.hansen@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=luto@kernel.org \
--cc=peterz@infradead.org \
--cc=rppt@kernel.org \
--cc=willy@infradead.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.