Re: [PATCHv4 3/3] pci: make reset_subordinate hotplug safe

[Keith Busch <kbusch@kernel.org>]

On Fri, Feb 13, 2026 at 09:32:32AM +0200, Ilpo Järvinen wrote:
> On Thu, 12 Feb 2026, Keith Busch wrote:
> >  int pci_bus_error_reset(struct pci_dev *bridge)
> >  {
> > -	struct pci_bus *bus = bridge->subordinate;
> > -	struct pci_slot *slot;
> > -
> > -	if (!bus)
> > -		return -ENOTTY;
> > -
> > -	mutex_lock(&pci_slot_mutex);
> > -	if (list_empty(&bus->slots))
> > -		goto bus_reset;
> > -
> > -	list_for_each_entry(slot, &bus->slots, list)
> > -		if (pci_probe_reset_slot(slot))
> > -			goto bus_reset;
> > -
> > -	list_for_each_entry(slot, &bus->slots, list)
> > -		if (pci_slot_reset(slot, PCI_RESET_DO_RESET))
> > -			goto bus_reset;
> > -
> > -	mutex_unlock(&pci_slot_mutex);
> > -	return 0;
> > -bus_reset:
> > -	mutex_unlock(&pci_slot_mutex);
> > -	return pci_bus_reset(bridge->subordinate, PCI_RESET_DO_RESET);
> > +	return pci_reset_bridge(bridge, PCI_RESET_NO_RESTORE);
> >  }
> 
> I think this should be moved down below pci_reset_bridge() and the forward 
> declaration of pci_reset_bridge() removed.

Yes, thanks for the suggestion. A cleaner end result for sure.