Re: [PATCHv4 2/3] pci: allow all bus devices to use the same slot

[Keith Busch <kbusch@kernel.org>]

On Fri, Feb 13, 2026 at 09:26:35AM +0200, Ilpo Järvinen wrote:
> On Thu, 12 Feb 2026, Keith Busch wrote:
> > @@ -42,6 +42,15 @@ static ssize_t address_read_file(struct pci_slot *slot, char *buf)
> >  				  pci_domain_nr(slot->bus),
> >  				  slot->bus->number);
> >  
> > +	/*
> > +	 * Preserve legacy ABI expectations that hotplug drivers that manage
> > +	 * multiple devices per slot emit 0 for the device number.
> > +	 */
> > +	if (slot->number == PCI_SLOT_ALL_DEVICES)
> > +		return sysfs_emit(buf, "%04x:%02x:00\n",
> > +				  pci_domain_nr(slot->bus),
> > +				  slot->bus->number);
> 
> This fits to two lines.
> 
> Add braces as it's a multi-line block.

These suggestions clash with the local contentions of this function.
These lines are exact copy/paste from directly above it, with a tiny
modification for the legacy behavior. Not that I'm advocating for this
particular coding style, but consistency is preferred.