All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tommaso Merciai <tommaso.merciai.xr@bp.renesas.com>
To: Arnd Bergmann <arnd@kernel.org>
Cc: Vinod Koul <vkoul@kernel.org>, Arnd Bergmann <arnd@arndb.de>,
	Neil Armstrong <neil.armstrong@linaro.org>,
	Biju Das <biju.das.jz@bp.renesas.com>,
	linux-phy@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] phy: renesas: rcar-gen3-usb2: add regulator dependency
Date: Tue, 3 Feb 2026 09:24:32 +0100	[thread overview]
Message-ID: <aYGwwMLkVp4X2IBC@tom-desktop> (raw)
In-Reply-To: <20260202095118.1233046-1-arnd@kernel.org>

On Mon, Feb 02, 2026 at 10:51:14AM +0100, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
> 
> The driver start registering a regulator, but can still be
> enabled even when it is unable to call into the regulator
> subsystem:
> 
> aarch64-linux-ld: drivers/phy/renesas/phy-rcar-gen3-usb2.o: in function `rcar_gen3_phy_usb2_probe':
> phy-rcar-gen3-usb2.c:(.text+0x2884): undefined reference to `devm_regulator_register'
> 
> Add a Kconfig dependency to avoid this configuration.
> 
> Fixes: b6d7dd157763 ("phy: renesas: rcar-gen3-usb2: Add regulator for OTG VBUS control")

Tested-by: Tommaso Merciai <tommaso.merciai.xr@bp.renesas.com>

> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
>  drivers/phy/renesas/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/phy/renesas/Kconfig b/drivers/phy/renesas/Kconfig
> index d217c630b2fd..90a9ca2db7fc 100644
> --- a/drivers/phy/renesas/Kconfig
> +++ b/drivers/phy/renesas/Kconfig
> @@ -29,6 +29,7 @@ config PHY_RCAR_GEN3_USB2
>  	depends on ARCH_RENESAS
>  	depends on EXTCON || !EXTCON # if EXTCON=m, this cannot be built-in
>  	depends on USB_SUPPORT
> +	depends on REGULATOR
>  	select GENERIC_PHY
>  	select MULTIPLEXER
>  	select USB_COMMON
> -- 
> 2.39.5
> 

Thanks & Regards,
Tommaso

-- 
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy

WARNING: multiple messages have this Message-ID (diff)
From: Tommaso Merciai <tommaso.merciai.xr@bp.renesas.com>
To: Arnd Bergmann <arnd@kernel.org>
Cc: Vinod Koul <vkoul@kernel.org>, Arnd Bergmann <arnd@arndb.de>,
	Neil Armstrong <neil.armstrong@linaro.org>,
	Biju Das <biju.das.jz@bp.renesas.com>,
	linux-phy@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] phy: renesas: rcar-gen3-usb2: add regulator dependency
Date: Tue, 3 Feb 2026 09:24:32 +0100	[thread overview]
Message-ID: <aYGwwMLkVp4X2IBC@tom-desktop> (raw)
In-Reply-To: <20260202095118.1233046-1-arnd@kernel.org>

On Mon, Feb 02, 2026 at 10:51:14AM +0100, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
> 
> The driver start registering a regulator, but can still be
> enabled even when it is unable to call into the regulator
> subsystem:
> 
> aarch64-linux-ld: drivers/phy/renesas/phy-rcar-gen3-usb2.o: in function `rcar_gen3_phy_usb2_probe':
> phy-rcar-gen3-usb2.c:(.text+0x2884): undefined reference to `devm_regulator_register'
> 
> Add a Kconfig dependency to avoid this configuration.
> 
> Fixes: b6d7dd157763 ("phy: renesas: rcar-gen3-usb2: Add regulator for OTG VBUS control")

Tested-by: Tommaso Merciai <tommaso.merciai.xr@bp.renesas.com>

> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
>  drivers/phy/renesas/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/phy/renesas/Kconfig b/drivers/phy/renesas/Kconfig
> index d217c630b2fd..90a9ca2db7fc 100644
> --- a/drivers/phy/renesas/Kconfig
> +++ b/drivers/phy/renesas/Kconfig
> @@ -29,6 +29,7 @@ config PHY_RCAR_GEN3_USB2
>  	depends on ARCH_RENESAS
>  	depends on EXTCON || !EXTCON # if EXTCON=m, this cannot be built-in
>  	depends on USB_SUPPORT
> +	depends on REGULATOR
>  	select GENERIC_PHY
>  	select MULTIPLEXER
>  	select USB_COMMON
> -- 
> 2.39.5
> 

Thanks & Regards,
Tommaso

  reply	other threads:[~2026-02-03  8:25 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-02  9:51 [PATCH] phy: renesas: rcar-gen3-usb2: add regulator dependency Arnd Bergmann
2026-02-02  9:51 ` Arnd Bergmann
2026-02-03  8:24 ` Tommaso Merciai [this message]
2026-02-03  8:24   ` Tommaso Merciai
2026-02-04 15:44 ` Vinod Koul
2026-02-04 15:44   ` Vinod Koul

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aYGwwMLkVp4X2IBC@tom-desktop \
    --to=tommaso.merciai.xr@bp.renesas.com \
    --cc=arnd@arndb.de \
    --cc=arnd@kernel.org \
    --cc=biju.das.jz@bp.renesas.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-phy@lists.infradead.org \
    --cc=neil.armstrong@linaro.org \
    --cc=vkoul@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.