[Buildroot] [PATCH 1/1] package/lrzsz: fix build error

[Buildroot] [PATCH 1/1] package/lrzsz: fix build error

[Bernd Kuhls]

Fixes:
https://autobuild.buildroot.net/results/2e3/2e33c61e1c9bee099f973c1e43b696c63e5eed4b/

Signed-off-by: Bernd Kuhls <bernd@kuhls.net>
---
 package/lrzsz/0007-force-cross-compile.patch | 36 ++++++++++++++++++++
 1 file changed, 36 insertions(+)
 create mode 100644 package/lrzsz/0007-force-cross-compile.patch

diff --git a/package/lrzsz/0007-force-cross-compile.patch b/package/lrzsz/0007-force-cross-compile.patch
new file mode 100644
index 0000000000..48b029208d
--- /dev/null
+++ b/package/lrzsz/0007-force-cross-compile.patch
@@ -0,0 +1,36 @@
+Fix build error
+
+xstrtol.h:11:19: error: implicit declaration of function 'strtol';
+ did you mean 'xstrtol'? [-Wimplicit-function-declaration]
+   11 | # define __strtol strtol
+
+When build host and target share the same arch the test for cross-
+compiling may fail to detect this leading to further errors which
+leads to "#undef STDC_HEADERS" being added to config.h. This in turn
+prevents "#include <stdlib.h>" in lib/xstrtol.c causing a build error.
+
+Patching configure.in is not an option because autoreconf fails and
+upstream meanwhile added heavy changes to the "whole autoconf/automake/
+libtool/gettext mess":
+https://github.com/UweOhse/lrzsz/commit/29ec4b7c2869fee3f0e8d65c42779ead11c34f07
+
+So we patch configure directly to force a cross-compiled build.
+
+Adding ac_cv_header_stdc=yes to lrzsz.mk would also fix the build error
+but masks the fact that the cross-compile environment is misdetected.
+
+Upstream: not applicable
+
+Signed-off-by: Bernd Kuhls <bernd@kuhls.net>
+
+--- a/configure	2025-12-05 19:07:42.514385175 +0100
++++ b/configure	2025-12-05 19:07:55.506624148 +0100
+@@ -1059,7 +1059,7 @@
+   ac_cv_prog_cc_works=yes
+   # If we can't run a trivial program, we are probably using a cross compiler.
+   if (./conftest; exit) 2>/dev/null; then
+-    ac_cv_prog_cc_cross=no
++    ac_cv_prog_cc_cross=yes
+   else
+     ac_cv_prog_cc_cross=yes
+   fi
-- 
2.47.3

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/1] package/lrzsz: fix build error

[Thomas Petazzoni via buildroot]

Hello Bernd,

On Fri, Dec 05, 2025 at 07:18:55PM +0100, Bernd Kuhls wrote:
> Fixes:
> https://autobuild.buildroot.net/results/2e3/2e33c61e1c9bee099f973c1e43b696c63e5eed4b/
> 
> Signed-off-by: Bernd Kuhls <bernd@kuhls.net>

Could you revisit this patch, providing the information that we expect
when fixing build failures? What is the build failure? When did it
start happening? Also, a fix that's not upstreamable looks strange at
first sight. Can we do better?

> +Adding ac_cv_header_stdc=yes to lrzsz.mk would also fix the build error
> +but masks the fact that the cross-compile environment is misdetected.

Not sure to understand this part. What does "masks the fact that the
cross-compile environment is misdetected" actually mean?

Thanks!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot