All of lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH v2 1/1] package/brotli: fix LoongArch64 build
@ 2026-01-04 11:02 Bernd Kuhls
  2026-02-04 13:23 ` Thomas Petazzoni via buildroot
  2026-02-13 19:36 ` Thomas Perale via buildroot
  0 siblings, 2 replies; 3+ messages in thread
From: Bernd Kuhls @ 2026-01-04 11:02 UTC (permalink / raw)
  To: buildroot; +Cc: Adrian Perez de Castro

Buildroot commit 473c9400a0c7be14e7eb8ba617697a76286915b3 bumped brotli
to version 1.2.0 causing build errors on loongarch64. The build error
does not occur with brotli 1.1.0.

Fixes:
https://autobuild.buildroot.net/results/57f/57f61a5fd17432bba05e4f1865f82cc2f4626d3c/

Signed-off-by: Bernd Kuhls <bernd@kuhls.net>
---
v2: added comment that the previous brotli version builds with
    LoongArch64 (Thomas)

 ...-BROTLI_MODEL-macro-for-some-targets.patch | 46 +++++++++++++++++++
 1 file changed, 46 insertions(+)
 create mode 100644 package/brotli/0001-disable-BROTLI_MODEL-macro-for-some-targets.patch

diff --git a/package/brotli/0001-disable-BROTLI_MODEL-macro-for-some-targets.patch b/package/brotli/0001-disable-BROTLI_MODEL-macro-for-some-targets.patch
new file mode 100644
index 0000000000..d35b4b3336
--- /dev/null
+++ b/package/brotli/0001-disable-BROTLI_MODEL-macro-for-some-targets.patch
@@ -0,0 +1,46 @@
+From e230f474b87134e8c6c85b630084c612057f253e Mon Sep 17 00:00:00 2001
+From: Evgenii Kliuchnikov <eustas@google.com>
+Date: Mon, 3 Nov 2025 07:20:19 -0800
+Subject: [PATCH] disable BROTLI_MODEL macro for some targets
+
+PiperOrigin-RevId: 827486322
+
+Upstream: https://github.com/google/brotli/commit/e230f474b87134e8c6c85b630084c612057f253e
+
+Signed-off-by: Bernd Kuhls <bernd@kuhls.net>
+---
+ c/common/platform.h | 9 +++++++--
+ 1 file changed, 7 insertions(+), 2 deletions(-)
+
+diff --git a/c/common/platform.h b/c/common/platform.h
+index b59f9b809..e1254d5ca 100644
+--- a/c/common/platform.h
++++ b/c/common/platform.h
+@@ -213,6 +213,10 @@ To apply compiler hint, enclose the branching condition into macros, like this:
+ #define BROTLI_TARGET_MIPS64
+ #endif
+ 
++#if defined(__ia64__) || defined(_M_IA64)
++#define BROTLI_TARGET_IA64
++#endif
++
+ #if defined(BROTLI_TARGET_X64) || defined(BROTLI_TARGET_ARMV8_64) || \
+     defined(BROTLI_TARGET_POWERPC64) || defined(BROTLI_TARGET_RISCV64) || \
+     defined(BROTLI_TARGET_LOONGARCH64) || defined(BROTLI_TARGET_MIPS64)
+@@ -665,13 +669,14 @@ BROTLI_UNUSED_FUNCTION void BrotliSuppressUnusedFunctions(void) {
+ #undef BROTLI_TEST
+ #endif
+ 
+-#if BROTLI_GNUC_HAS_ATTRIBUTE(model, 3, 0, 3)
++#if !defined(BROTLI_MODEL) && BROTLI_GNUC_HAS_ATTRIBUTE(model, 3, 0, 3) && \
++    !defined(BROTLI_TARGET_IA64) && !defined(BROTLI_TARGET_LOONGARCH64)
+ #define BROTLI_MODEL(M) __attribute__((model(M)))
+ #else
+ #define BROTLI_MODEL(M) /* M */
+ #endif
+ 
+-#if BROTLI_GNUC_HAS_ATTRIBUTE(cold, 4, 3, 0)
++#if !defined(BROTLI_COLD) && BROTLI_GNUC_HAS_ATTRIBUTE(cold, 4, 3, 0)
+ #define BROTLI_COLD __attribute__((cold))
+ #else
+ #define BROTLI_COLD /* cold */
-- 
2.47.3

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply related	[flat|nested] 3+ messages in thread
* Re: [Buildroot] [PATCH v2 1/1] package/brotli: fix LoongArch64 build
  2026-01-04 11:02 [Buildroot] [PATCH v2 1/1] package/brotli: fix LoongArch64 build Bernd Kuhls
@ 2026-02-04 13:23 ` Thomas Petazzoni via buildroot
  2026-02-13 19:36 ` Thomas Perale via buildroot
  1 sibling, 0 replies; 3+ messages in thread
From: Thomas Petazzoni via buildroot @ 2026-02-04 13:23 UTC (permalink / raw)
  To: Bernd Kuhls; +Cc: buildroot, Adrian Perez de Castro

On Sun, Jan 04, 2026 at 12:02:20PM +0100, Bernd Kuhls wrote:
> Buildroot commit 473c9400a0c7be14e7eb8ba617697a76286915b3 bumped brotli
> to version 1.2.0 causing build errors on loongarch64. The build error
> does not occur with brotli 1.1.0.
> 
> Fixes:
> https://autobuild.buildroot.net/results/57f/57f61a5fd17432bba05e4f1865f82cc2f4626d3c/
> 
> Signed-off-by: Bernd Kuhls <bernd@kuhls.net>

Applied, thanks!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 3+ messages in thread
* Re: [Buildroot] [PATCH v2 1/1] package/brotli: fix LoongArch64 build
  2026-01-04 11:02 [Buildroot] [PATCH v2 1/1] package/brotli: fix LoongArch64 build Bernd Kuhls
  2026-02-04 13:23 ` Thomas Petazzoni via buildroot
@ 2026-02-13 19:36 ` Thomas Perale via buildroot
  1 sibling, 0 replies; 3+ messages in thread
From: Thomas Perale via buildroot @ 2026-02-13 19:36 UTC (permalink / raw)
  To: Bernd Kuhls; +Cc: Thomas Perale, buildroot

In reply of:
> Buildroot commit 473c9400a0c7be14e7eb8ba617697a76286915b3 bumped brotli
> to version 1.2.0 causing build errors on loongarch64. The build error
> does not occur with brotli 1.1.0.
> 
> Fixes:
> https://autobuild.buildroot.net/results/57f/57f61a5fd17432bba05e4f1865f82cc2f4626d3c/
> 
> Signed-off-by: Bernd Kuhls <bernd@kuhls.net>

Applied to 2025.11.x. Thanks

> ---
> v2: added comment that the previous brotli version builds with
>     LoongArch64 (Thomas)
> 
>  ...-BROTLI_MODEL-macro-for-some-targets.patch | 46 +++++++++++++++++++
>  1 file changed, 46 insertions(+)
>  create mode 100644 package/brotli/0001-disable-BROTLI_MODEL-macro-for-some-targets.patch
> 
> diff --git a/package/brotli/0001-disable-BROTLI_MODEL-macro-for-some-targets.patch b/package/brotli/0001-disable-BROTLI_MODEL-macro-for-some-targets.patch
> new file mode 100644
> index 0000000000..d35b4b3336
> --- /dev/null
> +++ b/package/brotli/0001-disable-BROTLI_MODEL-macro-for-some-targets.patch
> @@ -0,0 +1,46 @@
> +From e230f474b87134e8c6c85b630084c612057f253e Mon Sep 17 00:00:00 2001
> +From: Evgenii Kliuchnikov <eustas@google.com>
> +Date: Mon, 3 Nov 2025 07:20:19 -0800
> +Subject: [PATCH] disable BROTLI_MODEL macro for some targets
> +
> +PiperOrigin-RevId: 827486322
> +
> +Upstream: https://github.com/google/brotli/commit/e230f474b87134e8c6c85b630084c612057f253e
> +
> +Signed-off-by: Bernd Kuhls <bernd@kuhls.net>
> +---
> + c/common/platform.h | 9 +++++++--
> + 1 file changed, 7 insertions(+), 2 deletions(-)
> +
> +diff --git a/c/common/platform.h b/c/common/platform.h
> +index b59f9b809..e1254d5ca 100644
> +--- a/c/common/platform.h
> ++++ b/c/common/platform.h
> +@@ -213,6 +213,10 @@ To apply compiler hint, enclose the branching condition into macros, like this:
> + #define BROTLI_TARGET_MIPS64
> + #endif
> + 
> ++#if defined(__ia64__) || defined(_M_IA64)
> ++#define BROTLI_TARGET_IA64
> ++#endif
> ++
> + #if defined(BROTLI_TARGET_X64) || defined(BROTLI_TARGET_ARMV8_64) || \
> +     defined(BROTLI_TARGET_POWERPC64) || defined(BROTLI_TARGET_RISCV64) || \
> +     defined(BROTLI_TARGET_LOONGARCH64) || defined(BROTLI_TARGET_MIPS64)
> +@@ -665,13 +669,14 @@ BROTLI_UNUSED_FUNCTION void BrotliSuppressUnusedFunctions(void) {
> + #undef BROTLI_TEST
> + #endif
> + 
> +-#if BROTLI_GNUC_HAS_ATTRIBUTE(model, 3, 0, 3)
> ++#if !defined(BROTLI_MODEL) && BROTLI_GNUC_HAS_ATTRIBUTE(model, 3, 0, 3) && \
> ++    !defined(BROTLI_TARGET_IA64) && !defined(BROTLI_TARGET_LOONGARCH64)
> + #define BROTLI_MODEL(M) __attribute__((model(M)))
> + #else
> + #define BROTLI_MODEL(M) /* M */
> + #endif
> + 
> +-#if BROTLI_GNUC_HAS_ATTRIBUTE(cold, 4, 3, 0)
> ++#if !defined(BROTLI_COLD) && BROTLI_GNUC_HAS_ATTRIBUTE(cold, 4, 3, 0)
> + #define BROTLI_COLD __attribute__((cold))
> + #else
> + #define BROTLI_COLD /* cold */
> -- 
> 2.47.3
> 
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 3+ messages in thread
end of thread, other threads:[~2026-02-13 19:37 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-01-04 11:02 [Buildroot] [PATCH v2 1/1] package/brotli: fix LoongArch64 build Bernd Kuhls
2026-02-04 13:23 ` Thomas Petazzoni via buildroot
2026-02-13 19:36 ` Thomas Perale via buildroot

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.