Re: [nft PATCH 1/4] configure: Implement --enable-profiling option

[Pablo Neira Ayuso <pablo@netfilter.org>]

On Tue, Jan 27, 2026 at 11:29:13PM +0100, Phil Sutter wrote:
> diff --git a/src/main.c b/src/main.c
> index 29b0533dee7c9..bdcf8ab3c304b 100644
> --- a/src/main.c
> +++ b/src/main.c
> @@ -16,6 +16,7 @@
>  #include <errno.h>
>  #include <getopt.h>
>  #include <fcntl.h>
> +#include <signal.h>
>  #include <sys/types.h>
>  
>  #include <nftables/libnftables.h>
> @@ -360,6 +361,33 @@ static bool nft_options_check(int argc, char * const argv[])
>  	return true;
>  }
>  
> +#ifdef BUILD_PROFILING
> +static void termhandler(int signo)
> +{
> +	switch (signo) {
> +	case SIGTERM:
> +		exit(143);
> +	case SIGINT:
> +		exit(130);
> +	}
> +}
> +
> +static void setup_sighandler(void)
> +{
> +	struct sigaction act = {
> +		.sa_handler = termhandler,
> +	};
> +
> +	if (sigaction(SIGTERM, &act, NULL) == -1 ||
> +	    sigaction(SIGINT, &act, NULL) == -1) {
> +		perror("sigaction");
> +		exit(1);
> +	}
> +}
> +#else
> +static void setup_sighandler(void) { /* empty */ }
> +#endif

Nitpick: This is small, but please add it to src/profile.c, to make
extending it future proof and reduce ifdef pollution a bit.

With a include/profile.h also you can define the empty stub for
setup_sighandler() when !BUILD_PROFILING.

Thanks

> +
>  int main(int argc, char * const *argv)
>  {
>  	const struct option *options = get_options();
> @@ -375,6 +403,8 @@ int main(int argc, char * const *argv)
>  	if (getuid() != geteuid())
>  		_exit(111);
>  
> +	setup_sighandler();
> +
>  	if (!nft_options_check(argc, argv))
>  		exit(EXIT_FAILURE);
>  
> -- 
> 2.51.0
>