Re: [nft PATCH 0/4] Inspect and improve test suite code coverage

[Phil Sutter <phil@nwl.cc>]

On Thu, Feb 05, 2026 at 02:35:57AM +0100, Pablo Neira Ayuso wrote:
> On Tue, Jan 27, 2026 at 11:29:12PM +0100, Phil Sutter wrote:
> > While inspecting the test suites' code coverage using --coverage gcc
> > option and gcov(r) for analysis, I noticed that 'nft monitor' processes
> > did not influence the stats at all. It appears that a process receiving
> > SIGTERM or SIGINT (via kill or ctrl-c) does not dump profiling data at
> > exit. Installing a signal handler for those signals which calls exit()
> > resolves this, so patch 1 of this series implements --enable-profiling
> > into configure which also conditionally enables said signal handler.
> > 
> > Patches 2 and 4 fix for zero test coverage of src/nftrace.c and
> > src/xt.c, bumping stats to ~90% for both.
> > 
> > Patch 3 fixes for ignored comment matches in translated iptables-nft
> > rules. This is required for patch 4 which uses a comment match to check
> > whether nft is built with translation support.
> 
> Apart from the aforementioned nitpick, series LGTM.

Thanks for your review. I'll adjust patch 1 as per your feedback and
resubmit.