All of lore.kernel.org
 help / color / mirror / Atom feed
* [driver-core:driver-core-testing 1/4] include/linux/rcupdate.h:510:9: error: dereferencing pointer to incomplete type 'struct revocable_provider'
@ 2026-02-03 16:48 kernel test robot
  2026-02-05  5:55 ` Tzung-Bi Shih
  0 siblings, 1 reply; 2+ messages in thread
From: kernel test robot @ 2026-02-03 16:48 UTC (permalink / raw)
  To: Tzung-Bi Shih; +Cc: oe-kbuild-all, devel, Greg Kroah-Hartman

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/driver-core/driver-core.git driver-core-testing
head:   988357628c2c84e891f5992c4f5cfb31fb3bd27b
commit: 4d7dc4d1a62dbb22b1178dddeeb7a22d0272df77 [1/4] revocable: Fix races in revocable_alloc() using RCU
config: sparc-randconfig-001-20260203 (https://download.01.org/0day-ci/archive/20260204/202602040048.R81E8WaK-lkp@intel.com/config)
compiler: sparc-linux-gcc (GCC) 8.5.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20260204/202602040048.R81E8WaK-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202602040048.R81E8WaK-lkp@intel.com/

All error/warnings (new ones prefixed by >>):

   In file included from drivers/base/revocable_test.c:19:
   drivers/base/revocable_test.c: In function 'revocable_test_basic':
>> include/linux/rcupdate.h:510:9: error: dereferencing pointer to incomplete type 'struct revocable_provider'
     typeof(*p) *local = (typeof(*p) *__force)(p);   \
   include/kunit/test.h:839:15: note: in definition of macro 'KUNIT_BASE_BINARY_ASSERTION'
     const typeof(left) __left = (left);           \
                  ^~~~
   include/kunit/test.h:1056:2: note: in expansion of macro 'KUNIT_BINARY_PTR_ASSERTION'
     KUNIT_BINARY_PTR_ASSERTION(test,           \
     ^~~~~~~~~~~~~~~~~~~~~~~~~~
   include/kunit/test.h:1053:2: note: in expansion of macro 'KUNIT_EXPECT_PTR_EQ_MSG'
     KUNIT_EXPECT_PTR_EQ_MSG(test, left, right, NULL)
     ^~~~~~~~~~~~~~~~~~~~~~~
   drivers/base/revocable_test.c:40:2: note: in expansion of macro 'KUNIT_EXPECT_PTR_EQ'
     KUNIT_EXPECT_PTR_EQ(test, unrcu_pointer(rp), NULL);
     ^~~~~~~~~~~~~~~~~~~
   include/linux/rcupdate.h:521:26: note: in expansion of macro '__unrcu_pointer'
    #define unrcu_pointer(p) __unrcu_pointer(p, __UNIQUE_ID(rcu))
                             ^~~~~~~~~~~~~~~
   drivers/base/revocable_test.c:40:28: note: in expansion of macro 'unrcu_pointer'
     KUNIT_EXPECT_PTR_EQ(test, unrcu_pointer(rp), NULL);
                               ^~~~~~~~~~~~~
   In file included from include/linux/err.h:5,
                    from include/kunit/assert.h:12,
                    from include/kunit/test.h:12,
                    from drivers/base/revocable_test.c:19:
>> include/kunit/test.h:1058:14: warning: comparison between pointer and integer
           left, ==, right,          \
                 ^~
   include/linux/compiler.h:76:40: note: in definition of macro 'likely'
    # define likely(x) __builtin_expect(!!(x), 1)
                                           ^
   include/kunit/test.h:884:2: note: in expansion of macro 'KUNIT_BASE_BINARY_ASSERTION'
     KUNIT_BASE_BINARY_ASSERTION(test,           \
     ^~~~~~~~~~~~~~~~~~~~~~~~~~~
   include/kunit/test.h:1056:2: note: in expansion of macro 'KUNIT_BINARY_PTR_ASSERTION'
     KUNIT_BINARY_PTR_ASSERTION(test,           \
     ^~~~~~~~~~~~~~~~~~~~~~~~~~
   include/kunit/test.h:1053:2: note: in expansion of macro 'KUNIT_EXPECT_PTR_EQ_MSG'
     KUNIT_EXPECT_PTR_EQ_MSG(test, left, right, NULL)
     ^~~~~~~~~~~~~~~~~~~~~~~
   drivers/base/revocable_test.c:40:2: note: in expansion of macro 'KUNIT_EXPECT_PTR_EQ'
     KUNIT_EXPECT_PTR_EQ(test, unrcu_pointer(rp), NULL);
     ^~~~~~~~~~~~~~~~~~~
   In file included from drivers/base/revocable_test.c:19:
>> include/kunit/test.h:856:20: warning: initialization of 'const void *' from 'int' makes pointer from integer without a cast [-Wint-conversion]
         .left_value = __left,         \
                       ^~~~~~
   include/kunit/test.h:734:42: note: in definition of macro '_KUNIT_FAILED'
     const struct assert_class __assertion = INITIALIZER;         \
                                             ^~~~~~~~~~~
   include/kunit/test.h:855:9: note: in expansion of macro 'KUNIT_INIT_ASSERT'
            KUNIT_INIT_ASSERT(.text = &__text,         \
            ^~~~~~~~~~~~~~~~~
   include/kunit/test.h:884:2: note: in expansion of macro 'KUNIT_BASE_BINARY_ASSERTION'
     KUNIT_BASE_BINARY_ASSERTION(test,           \
     ^~~~~~~~~~~~~~~~~~~~~~~~~~~
   include/kunit/test.h:1056:2: note: in expansion of macro 'KUNIT_BINARY_PTR_ASSERTION'
     KUNIT_BINARY_PTR_ASSERTION(test,           \
     ^~~~~~~~~~~~~~~~~~~~~~~~~~
   include/kunit/test.h:1053:2: note: in expansion of macro 'KUNIT_EXPECT_PTR_EQ_MSG'
     KUNIT_EXPECT_PTR_EQ_MSG(test, left, right, NULL)
     ^~~~~~~~~~~~~~~~~~~~~~~
   drivers/base/revocable_test.c:40:2: note: in expansion of macro 'KUNIT_EXPECT_PTR_EQ'
     KUNIT_EXPECT_PTR_EQ(test, unrcu_pointer(rp), NULL);
     ^~~~~~~~~~~~~~~~~~~
   include/kunit/test.h:856:20: note: (near initialization for '__assertion.left_value')
         .left_value = __left,         \
                       ^~~~~~
   include/kunit/test.h:734:42: note: in definition of macro '_KUNIT_FAILED'
     const struct assert_class __assertion = INITIALIZER;         \
                                             ^~~~~~~~~~~
   include/kunit/test.h:855:9: note: in expansion of macro 'KUNIT_INIT_ASSERT'
            KUNIT_INIT_ASSERT(.text = &__text,         \
            ^~~~~~~~~~~~~~~~~
   include/kunit/test.h:884:2: note: in expansion of macro 'KUNIT_BASE_BINARY_ASSERTION'
     KUNIT_BASE_BINARY_ASSERTION(test,           \
     ^~~~~~~~~~~~~~~~~~~~~~~~~~~
   include/kunit/test.h:1056:2: note: in expansion of macro 'KUNIT_BINARY_PTR_ASSERTION'
     KUNIT_BINARY_PTR_ASSERTION(test,           \
     ^~~~~~~~~~~~~~~~~~~~~~~~~~
   include/kunit/test.h:1053:2: note: in expansion of macro 'KUNIT_EXPECT_PTR_EQ_MSG'
     KUNIT_EXPECT_PTR_EQ_MSG(test, left, right, NULL)
     ^~~~~~~~~~~~~~~~~~~~~~~
   drivers/base/revocable_test.c:40:2: note: in expansion of macro 'KUNIT_EXPECT_PTR_EQ'
     KUNIT_EXPECT_PTR_EQ(test, unrcu_pointer(rp), NULL);
     ^~~~~~~~~~~~~~~~~~~
   In file included from include/linux/err.h:5,
                    from include/kunit/assert.h:12,
                    from include/kunit/test.h:12,
                    from drivers/base/revocable_test.c:19:
   drivers/base/revocable_test.c: In function 'revocable_test_revocation':
>> include/kunit/test.h:1058:14: warning: comparison between pointer and integer
           left, ==, right,          \
                 ^~
   include/linux/compiler.h:76:40: note: in definition of macro 'likely'
    # define likely(x) __builtin_expect(!!(x), 1)
                                           ^
   include/kunit/test.h:884:2: note: in expansion of macro 'KUNIT_BASE_BINARY_ASSERTION'
     KUNIT_BASE_BINARY_ASSERTION(test,           \
     ^~~~~~~~~~~~~~~~~~~~~~~~~~~
   include/kunit/test.h:1056:2: note: in expansion of macro 'KUNIT_BINARY_PTR_ASSERTION'
     KUNIT_BINARY_PTR_ASSERTION(test,           \
     ^~~~~~~~~~~~~~~~~~~~~~~~~~
   include/kunit/test.h:1053:2: note: in expansion of macro 'KUNIT_EXPECT_PTR_EQ_MSG'
     KUNIT_EXPECT_PTR_EQ_MSG(test, left, right, NULL)
     ^~~~~~~~~~~~~~~~~~~~~~~
   drivers/base/revocable_test.c:60:2: note: in expansion of macro 'KUNIT_EXPECT_PTR_EQ'
     KUNIT_EXPECT_PTR_EQ(test, unrcu_pointer(rp), NULL);
     ^~~~~~~~~~~~~~~~~~~
   In file included from drivers/base/revocable_test.c:19:
>> include/kunit/test.h:856:20: warning: initialization of 'const void *' from 'int' makes pointer from integer without a cast [-Wint-conversion]
         .left_value = __left,         \
                       ^~~~~~
   include/kunit/test.h:734:42: note: in definition of macro '_KUNIT_FAILED'
     const struct assert_class __assertion = INITIALIZER;         \
                                             ^~~~~~~~~~~
   include/kunit/test.h:855:9: note: in expansion of macro 'KUNIT_INIT_ASSERT'
            KUNIT_INIT_ASSERT(.text = &__text,         \
            ^~~~~~~~~~~~~~~~~
   include/kunit/test.h:884:2: note: in expansion of macro 'KUNIT_BASE_BINARY_ASSERTION'
     KUNIT_BASE_BINARY_ASSERTION(test,           \
     ^~~~~~~~~~~~~~~~~~~~~~~~~~~
   include/kunit/test.h:1056:2: note: in expansion of macro 'KUNIT_BINARY_PTR_ASSERTION'
     KUNIT_BINARY_PTR_ASSERTION(test,           \
     ^~~~~~~~~~~~~~~~~~~~~~~~~~
   include/kunit/test.h:1053:2: note: in expansion of macro 'KUNIT_EXPECT_PTR_EQ_MSG'
     KUNIT_EXPECT_PTR_EQ_MSG(test, left, right, NULL)
     ^~~~~~~~~~~~~~~~~~~~~~~
   drivers/base/revocable_test.c:60:2: note: in expansion of macro 'KUNIT_EXPECT_PTR_EQ'
     KUNIT_EXPECT_PTR_EQ(test, unrcu_pointer(rp), NULL);
     ^~~~~~~~~~~~~~~~~~~
   include/kunit/test.h:856:20: note: (near initialization for '__assertion.left_value')
         .left_value = __left,         \
                       ^~~~~~
   include/kunit/test.h:734:42: note: in definition of macro '_KUNIT_FAILED'
     const struct assert_class __assertion = INITIALIZER;         \
                                             ^~~~~~~~~~~
   include/kunit/test.h:855:9: note: in expansion of macro 'KUNIT_INIT_ASSERT'
            KUNIT_INIT_ASSERT(.text = &__text,         \
            ^~~~~~~~~~~~~~~~~
   include/kunit/test.h:884:2: note: in expansion of macro 'KUNIT_BASE_BINARY_ASSERTION'
     KUNIT_BASE_BINARY_ASSERTION(test,           \
     ^~~~~~~~~~~~~~~~~~~~~~~~~~~
   include/kunit/test.h:1056:2: note: in expansion of macro 'KUNIT_BINARY_PTR_ASSERTION'
     KUNIT_BINARY_PTR_ASSERTION(test,           \
     ^~~~~~~~~~~~~~~~~~~~~~~~~~
   include/kunit/test.h:1053:2: note: in expansion of macro 'KUNIT_EXPECT_PTR_EQ_MSG'
     KUNIT_EXPECT_PTR_EQ_MSG(test, left, right, NULL)
     ^~~~~~~~~~~~~~~~~~~~~~~
   drivers/base/revocable_test.c:60:2: note: in expansion of macro 'KUNIT_EXPECT_PTR_EQ'
     KUNIT_EXPECT_PTR_EQ(test, unrcu_pointer(rp), NULL);
     ^~~~~~~~~~~~~~~~~~~
   In file included from include/linux/err.h:5,
                    from include/kunit/assert.h:12,
                    from include/kunit/test.h:12,
                    from drivers/base/revocable_test.c:19:
   drivers/base/revocable_test.c: In function 'revocable_test_try_access_macro':
>> include/kunit/test.h:1058:14: warning: comparison between pointer and integer
           left, ==, right,          \
                 ^~
   include/linux/compiler.h:76:40: note: in definition of macro 'likely'
    # define likely(x) __builtin_expect(!!(x), 1)
                                           ^
   include/kunit/test.h:884:2: note: in expansion of macro 'KUNIT_BASE_BINARY_ASSERTION'
     KUNIT_BASE_BINARY_ASSERTION(test,           \
     ^~~~~~~~~~~~~~~~~~~~~~~~~~~
   include/kunit/test.h:1056:2: note: in expansion of macro 'KUNIT_BINARY_PTR_ASSERTION'
     KUNIT_BINARY_PTR_ASSERTION(test,           \
     ^~~~~~~~~~~~~~~~~~~~~~~~~~
   include/kunit/test.h:1053:2: note: in expansion of macro 'KUNIT_EXPECT_PTR_EQ_MSG'
     KUNIT_EXPECT_PTR_EQ_MSG(test, left, right, NULL)
     ^~~~~~~~~~~~~~~~~~~~~~~
   drivers/base/revocable_test.c:87:2: note: in expansion of macro 'KUNIT_EXPECT_PTR_EQ'
     KUNIT_EXPECT_PTR_EQ(test, unrcu_pointer(rp), NULL);
     ^~~~~~~~~~~~~~~~~~~
   In file included from drivers/base/revocable_test.c:19:
>> include/kunit/test.h:856:20: warning: initialization of 'const void *' from 'int' makes pointer from integer without a cast [-Wint-conversion]
         .left_value = __left,         \
                       ^~~~~~
   include/kunit/test.h:734:42: note: in definition of macro '_KUNIT_FAILED'
     const struct assert_class __assertion = INITIALIZER;         \
                                             ^~~~~~~~~~~
   include/kunit/test.h:855:9: note: in expansion of macro 'KUNIT_INIT_ASSERT'
            KUNIT_INIT_ASSERT(.text = &__text,         \
            ^~~~~~~~~~~~~~~~~
   include/kunit/test.h:884:2: note: in expansion of macro 'KUNIT_BASE_BINARY_ASSERTION'
     KUNIT_BASE_BINARY_ASSERTION(test,           \
     ^~~~~~~~~~~~~~~~~~~~~~~~~~~
   include/kunit/test.h:1056:2: note: in expansion of macro 'KUNIT_BINARY_PTR_ASSERTION'
     KUNIT_BINARY_PTR_ASSERTION(test,           \
     ^~~~~~~~~~~~~~~~~~~~~~~~~~
   include/kunit/test.h:1053:2: note: in expansion of macro 'KUNIT_EXPECT_PTR_EQ_MSG'
     KUNIT_EXPECT_PTR_EQ_MSG(test, left, right, NULL)
     ^~~~~~~~~~~~~~~~~~~~~~~
   drivers/base/revocable_test.c:87:2: note: in expansion of macro 'KUNIT_EXPECT_PTR_EQ'
     KUNIT_EXPECT_PTR_EQ(test, unrcu_pointer(rp), NULL);
     ^~~~~~~~~~~~~~~~~~~
   include/kunit/test.h:856:20: note: (near initialization for '__assertion.left_value')
         .left_value = __left,         \
                       ^~~~~~
   include/kunit/test.h:734:42: note: in definition of macro '_KUNIT_FAILED'
     const struct assert_class __assertion = INITIALIZER;         \
                                             ^~~~~~~~~~~
   include/kunit/test.h:855:9: note: in expansion of macro 'KUNIT_INIT_ASSERT'
            KUNIT_INIT_ASSERT(.text = &__text,         \
            ^~~~~~~~~~~~~~~~~
   include/kunit/test.h:884:2: note: in expansion of macro 'KUNIT_BASE_BINARY_ASSERTION'
     KUNIT_BASE_BINARY_ASSERTION(test,           \
     ^~~~~~~~~~~~~~~~~~~~~~~~~~~
   include/kunit/test.h:1056:2: note: in expansion of macro 'KUNIT_BINARY_PTR_ASSERTION'
     KUNIT_BINARY_PTR_ASSERTION(test,           \
     ^~~~~~~~~~~~~~~~~~~~~~~~~~
   include/kunit/test.h:1053:2: note: in expansion of macro 'KUNIT_EXPECT_PTR_EQ_MSG'
     KUNIT_EXPECT_PTR_EQ_MSG(test, left, right, NULL)
     ^~~~~~~~~~~~~~~~~~~~~~~
   drivers/base/revocable_test.c:87:2: note: in expansion of macro 'KUNIT_EXPECT_PTR_EQ'
     KUNIT_EXPECT_PTR_EQ(test, unrcu_pointer(rp), NULL);
     ^~~~~~~~~~~~~~~~~~~
   In file included from include/linux/err.h:5,
                    from include/kunit/assert.h:12,
                    from include/kunit/test.h:12,
                    from drivers/base/revocable_test.c:19:
   drivers/base/revocable_test.c: In function 'revocable_test_try_access_macro2':
>> include/kunit/test.h:1058:14: warning: comparison between pointer and integer
           left, ==, right,          \
                 ^~
   include/linux/compiler.h:76:40: note: in definition of macro 'likely'
    # define likely(x) __builtin_expect(!!(x), 1)
                                           ^
   include/kunit/test.h:884:2: note: in expansion of macro 'KUNIT_BASE_BINARY_ASSERTION'
     KUNIT_BASE_BINARY_ASSERTION(test,           \
     ^~~~~~~~~~~~~~~~~~~~~~~~~~~
   include/kunit/test.h:1056:2: note: in expansion of macro 'KUNIT_BINARY_PTR_ASSERTION'
     KUNIT_BINARY_PTR_ASSERTION(test,           \
     ^~~~~~~~~~~~~~~~~~~~~~~~~~
   include/kunit/test.h:1053:2: note: in expansion of macro 'KUNIT_EXPECT_PTR_EQ_MSG'
     KUNIT_EXPECT_PTR_EQ_MSG(test, left, right, NULL)
     ^~~~~~~~~~~~~~~~~~~~~~~
   drivers/base/revocable_test.c:118:2: note: in expansion of macro 'KUNIT_EXPECT_PTR_EQ'
     KUNIT_EXPECT_PTR_EQ(test, unrcu_pointer(rp), NULL);
     ^~~~~~~~~~~~~~~~~~~
   In file included from drivers/base/revocable_test.c:19:
>> include/kunit/test.h:856:20: warning: initialization of 'const void *' from 'int' makes pointer from integer without a cast [-Wint-conversion]
         .left_value = __left,         \
                       ^~~~~~
   include/kunit/test.h:734:42: note: in definition of macro '_KUNIT_FAILED'
     const struct assert_class __assertion = INITIALIZER;         \
                                             ^~~~~~~~~~~
   include/kunit/test.h:855:9: note: in expansion of macro 'KUNIT_INIT_ASSERT'
            KUNIT_INIT_ASSERT(.text = &__text,         \
            ^~~~~~~~~~~~~~~~~
   include/kunit/test.h:884:2: note: in expansion of macro 'KUNIT_BASE_BINARY_ASSERTION'
     KUNIT_BASE_BINARY_ASSERTION(test,           \
     ^~~~~~~~~~~~~~~~~~~~~~~~~~~
   include/kunit/test.h:1056:2: note: in expansion of macro 'KUNIT_BINARY_PTR_ASSERTION'
     KUNIT_BINARY_PTR_ASSERTION(test,           \
     ^~~~~~~~~~~~~~~~~~~~~~~~~~
   include/kunit/test.h:1053:2: note: in expansion of macro 'KUNIT_EXPECT_PTR_EQ_MSG'
     KUNIT_EXPECT_PTR_EQ_MSG(test, left, right, NULL)
     ^~~~~~~~~~~~~~~~~~~~~~~
   drivers/base/revocable_test.c:118:2: note: in expansion of macro 'KUNIT_EXPECT_PTR_EQ'
     KUNIT_EXPECT_PTR_EQ(test, unrcu_pointer(rp), NULL);
     ^~~~~~~~~~~~~~~~~~~
   include/kunit/test.h:856:20: note: (near initialization for '__assertion.left_value')
         .left_value = __left,         \
                       ^~~~~~
   include/kunit/test.h:734:42: note: in definition of macro '_KUNIT_FAILED'
     const struct assert_class __assertion = INITIALIZER;         \
                                             ^~~~~~~~~~~
   include/kunit/test.h:855:9: note: in expansion of macro 'KUNIT_INIT_ASSERT'
            KUNIT_INIT_ASSERT(.text = &__text,         \
            ^~~~~~~~~~~~~~~~~
   include/kunit/test.h:884:2: note: in expansion of macro 'KUNIT_BASE_BINARY_ASSERTION'
     KUNIT_BASE_BINARY_ASSERTION(test,           \
     ^~~~~~~~~~~~~~~~~~~~~~~~~~~
   include/kunit/test.h:1056:2: note: in expansion of macro 'KUNIT_BINARY_PTR_ASSERTION'
     KUNIT_BINARY_PTR_ASSERTION(test,           \
     ^~~~~~~~~~~~~~~~~~~~~~~~~~
   include/kunit/test.h:1053:2: note: in expansion of macro 'KUNIT_EXPECT_PTR_EQ_MSG'
     KUNIT_EXPECT_PTR_EQ_MSG(test, left, right, NULL)
     ^~~~~~~~~~~~~~~~~~~~~~~
   drivers/base/revocable_test.c:118:2: note: in expansion of macro 'KUNIT_EXPECT_PTR_EQ'
     KUNIT_EXPECT_PTR_EQ(test, unrcu_pointer(rp), NULL);
     ^~~~~~~~~~~~~~~~~~~


vim +510 include/linux/rcupdate.h

53ecfba259f54b Paul E. McKenney 2010-09-13  507  
24ba53017e188e Chun-Hung Tseng  2021-09-15  508  #define __unrcu_pointer(p, local)					\
24ba53017e188e Chun-Hung Tseng  2021-09-15  509  ({									\
24ba53017e188e Chun-Hung Tseng  2021-09-15 @510  	typeof(*p) *local = (typeof(*p) *__force)(p);			\
24ba53017e188e Chun-Hung Tseng  2021-09-15  511  	rcu_check_sparse(p, __rcu);					\
24ba53017e188e Chun-Hung Tseng  2021-09-15  512  	((typeof(*p) __force __kernel *)(local)); 			\
24ba53017e188e Chun-Hung Tseng  2021-09-15  513  })
76c8eaafe4f061 Paul E. McKenney 2021-04-21  514  /**
76c8eaafe4f061 Paul E. McKenney 2021-04-21  515   * unrcu_pointer - mark a pointer as not being RCU protected
76c8eaafe4f061 Paul E. McKenney 2021-04-21  516   * @p: pointer needing to lose its __rcu property
76c8eaafe4f061 Paul E. McKenney 2021-04-21  517   *
76c8eaafe4f061 Paul E. McKenney 2021-04-21  518   * Converts @p from an __rcu pointer to a __kernel pointer.
76c8eaafe4f061 Paul E. McKenney 2021-04-21  519   * This allows an __rcu pointer to be used with xchg() and friends.
76c8eaafe4f061 Paul E. McKenney 2021-04-21  520   */
24ba53017e188e Chun-Hung Tseng  2021-09-15  521  #define unrcu_pointer(p) __unrcu_pointer(p, __UNIQUE_ID(rcu))
76c8eaafe4f061 Paul E. McKenney 2021-04-21  522  

:::::: The code at line 510 was first introduced by commit
:::::: 24ba53017e188e031f9cb8b290286fad52d2af00 rcu: Replace ________p1 and _________p1 with __UNIQUE_ID(rcu)

:::::: TO: Chun-Hung Tseng <henrybear327@gmail.com>
:::::: CC: Paul E. McKenney <paulmck@kernel.org>

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [driver-core:driver-core-testing 1/4] include/linux/rcupdate.h:510:9: error: dereferencing pointer to incomplete type 'struct revocable_provider'
  2026-02-03 16:48 [driver-core:driver-core-testing 1/4] include/linux/rcupdate.h:510:9: error: dereferencing pointer to incomplete type 'struct revocable_provider' kernel test robot
@ 2026-02-05  5:55 ` Tzung-Bi Shih
  0 siblings, 0 replies; 2+ messages in thread
From: Tzung-Bi Shih @ 2026-02-05  5:55 UTC (permalink / raw)
  To: kernel test robot; +Cc: oe-kbuild-all, devel, Greg Kroah-Hartman

On Wed, Feb 04, 2026 at 12:48:55AM +0800, kernel test robot wrote:
> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/driver-core/driver-core.git driver-core-testing
> head:   988357628c2c84e891f5992c4f5cfb31fb3bd27b
> commit: 4d7dc4d1a62dbb22b1178dddeeb7a22d0272df77 [1/4] revocable: Fix races in revocable_alloc() using RCU
> config: sparc-randconfig-001-20260203 (https://download.01.org/0day-ci/archive/20260204/202602040048.R81E8WaK-lkp@intel.com/config)
> compiler: sparc-linux-gcc (GCC) 8.5.0
> reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20260204/202602040048.R81E8WaK-lkp@intel.com/reproduce)
> 
> If you fix the issue in a separate patch/commit (i.e. not just a new version of
> the same patch/commit), kindly add following tags
> | Reported-by: kernel test robot <lkp@intel.com>
> | Closes: https://lore.kernel.org/oe-kbuild-all/202602040048.R81E8WaK-lkp@intel.com/
> 
> All error/warnings (new ones prefixed by >>):
> 
>    In file included from drivers/base/revocable_test.c:19:
>    drivers/base/revocable_test.c: In function 'revocable_test_basic':
> >> include/linux/rcupdate.h:510:9: error: dereferencing pointer to incomplete type 'struct revocable_provider'
>      typeof(*p) *local = (typeof(*p) *__force)(p);   \
>    include/kunit/test.h:839:15: note: in definition of macro 'KUNIT_BASE_BINARY_ASSERTION'
>      const typeof(left) __left = (left);           \
>                   ^~~~
>    include/kunit/test.h:1056:2: note: in expansion of macro 'KUNIT_BINARY_PTR_ASSERTION'
>      KUNIT_BINARY_PTR_ASSERTION(test,           \
>      ^~~~~~~~~~~~~~~~~~~~~~~~~~
>    include/kunit/test.h:1053:2: note: in expansion of macro 'KUNIT_EXPECT_PTR_EQ_MSG'
>      KUNIT_EXPECT_PTR_EQ_MSG(test, left, right, NULL)
>      ^~~~~~~~~~~~~~~~~~~~~~~
>    drivers/base/revocable_test.c:40:2: note: in expansion of macro 'KUNIT_EXPECT_PTR_EQ'
>      KUNIT_EXPECT_PTR_EQ(test, unrcu_pointer(rp), NULL);
>      ^~~~~~~~~~~~~~~~~~~
>    include/linux/rcupdate.h:521:26: note: in expansion of macro '__unrcu_pointer'
>     #define unrcu_pointer(p) __unrcu_pointer(p, __UNIQUE_ID(rcu))
>                              ^~~~~~~~~~~~~~~
>    drivers/base/revocable_test.c:40:28: note: in expansion of macro 'unrcu_pointer'
>      KUNIT_EXPECT_PTR_EQ(test, unrcu_pointer(rp), NULL);
>                                ^~~~~~~~~~~~~

This warning seems to be reproducible only with older toolchain.

`struct revocable_provider` is an opaque type.  Possible fixes: make it
a non-opaque type, or move the type definition to revocable_internal.h
and include the header in the KUnit test, or don't use unrcu_pointer()
at all.

I'll address other reported comments first, and evaluate this later.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2026-02-05  5:55 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-02-03 16:48 [driver-core:driver-core-testing 1/4] include/linux/rcupdate.h:510:9: error: dereferencing pointer to incomplete type 'struct revocable_provider' kernel test robot
2026-02-05  5:55 ` Tzung-Bi Shih

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.