Re: [PATCH 1/2] Input: st1232 - read firmware version and revision

[Dmitry Torokhov <dmitry.torokhov@gmail.com>]

Hi Michael,

On Fri, Jan 23, 2026 at 05:28:55PM +0100, Michael Tretter wrote:
> +static int st1232_ts_read_fw_version(struct st1232_ts_data *ts,
> +				     u8 *fw_version, u32 *fw_revision)
> +{
> +	int error;
> +
> +	/* select firmware version register */
> +	error = st1232_ts_read_data(ts, REG_FIRMWARE_VERSION, 1);
> +	if (error)
> +		return error;
> +	*fw_version = ts->read_buf[0];
> +
> +	/* select firmware revision register */
> +	error = st1232_ts_read_data(ts, REG_FIRMWARE_REVISION_3, 4);
> +	if (error)
> +		return error;
> +	*fw_revision = get_unaligned_le32(ts->read_buf);

Why unaligned? You are not reading at an offset and allocated memory is
cache line aligned.

Thanks.

-- 
Dmitry