Re: [PATCH 1/2] Input: st1232 - read firmware version and revision

[Michael Tretter <m.tretter@pengutronix.de>]

On Fri, 06 Feb 2026 15:50:13 +0100, Michael Tretter wrote:
> On Thu, 05 Feb 2026 01:17:17 -0800, Dmitry Torokhov wrote:
> > On Fri, Jan 23, 2026 at 05:28:55PM +0100, Michael Tretter wrote:
> > > +static int st1232_ts_read_fw_version(struct st1232_ts_data *ts,
> > > +				     u8 *fw_version, u32 *fw_revision)
> > > +{
> > > +	int error;
> > > +
> > > +	/* select firmware version register */
> > > +	error = st1232_ts_read_data(ts, REG_FIRMWARE_VERSION, 1);
> > > +	if (error)
> > > +		return error;
> > > +	*fw_version = ts->read_buf[0];
> > > +
> > > +	/* select firmware revision register */
> > > +	error = st1232_ts_read_data(ts, REG_FIRMWARE_REVISION_3, 4);
> > > +	if (error)
> > > +		return error;
> > > +	*fw_revision = get_unaligned_le32(ts->read_buf);
> > 
> > Why unaligned? You are not reading at an offset and allocated memory is
> > cache line aligned.
> 
> I copied what other touchscreen drivers were doing to read the version,
> but missed that they either read at an offset or use a buffer on the
> stack.
> 
> Should I send a v2 or can you change this to le32_to_cpu() while
> applying the patch?

I just sent a v2.

Michael