All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dan Carpenter <dan.carpenter@linaro.org>
To: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
Cc: linux-pm@vger.kernel.org, linux-kernel <linux-kernel@vger.kernel.org>
Subject: [bug report] power: sequencing: qcom-wcn: add support for WCN39xx
Date: Fri, 6 Feb 2026 16:40:19 +0300	[thread overview]
Message-ID: <aYXvQxKqmjP_sdCd@stanley.mountain> (raw)
In-Reply-To: <caa37f28-a2e8-4e0a-a9ce-a365ce805e4b@stanley.mountain>

[ Smatch checking is paused while we raise funding.  #SadFace
  https://lore.kernel.org/all/aTaiGSbWZ9DJaGo7@stanley.mountain/ -dan ]

Hello Dmitry Baryshkov,

Commit 0eb85f468ef5 ("power: sequencing: qcom-wcn: add support for
WCN39xx") from Jan 6, 2026 (linux-next), leads to the following
Smatch static checker warning:

	drivers/power/sequencing/pwrseq-qcom-wcn.c:492 pwrseq_qcom_wcn_probe()
	warn: passing zero to 'dev_err_probe'

drivers/power/sequencing/pwrseq-qcom-wcn.c
    458 static int pwrseq_qcom_wcn_probe(struct platform_device *pdev)
    459 {
    460         struct device *dev = &pdev->dev;
    461         struct pwrseq_qcom_wcn_ctx *ctx;
    462         struct pwrseq_config config;
    463         int i, ret;
    464 
    465         ctx = devm_kzalloc(dev, sizeof(*ctx), GFP_KERNEL);
    466         if (!ctx)
    467                 return -ENOMEM;
    468 
    469         ctx->of_node = dev->of_node;
    470 
    471         ctx->pdata = device_get_match_data(dev);
    472         if (!ctx->pdata)
    473                 return dev_err_probe(dev, -ENODEV,
    474                                      "Failed to obtain platform data\n");
    475 
    476         ctx->regs = devm_kcalloc(dev, ctx->pdata->num_vregs,
    477                                  sizeof(*ctx->regs), GFP_KERNEL);
    478         if (!ctx->regs)
    479                 return -ENOMEM;
    480 
    481         for (i = 0; i < ctx->pdata->num_vregs; i++)
    482                 ctx->regs[i].supply = ctx->pdata->vregs[i];
    483 
    484         ret = devm_regulator_bulk_get(dev, ctx->pdata->num_vregs, ctx->regs);
    485         if (ret < 0)
    486                 return dev_err_probe(dev, ret,
    487                                      "Failed to get all regulators\n");
    488 
    489         if (ctx->pdata->has_vddio) {
    490                 ctx->vddio = devm_regulator_get(dev, "vddio");
    491                 if (IS_ERR(ctx->vddio))
--> 492                         return dev_err_probe(dev, ret, "Failed to get VDDIO\n");

s/ret/PTR_ERR(ctx->vddio)/

    493         }
    494 
    495         ctx->bt_gpio = devm_gpiod_get_optional(dev, "bt-enable", GPIOD_OUT_LOW);
    496         if (IS_ERR(ctx->bt_gpio))
    497                 return dev_err_probe(dev, PTR_ERR(ctx->bt_gpio),
    498                                      "Failed to get the Bluetooth enable GPIO\n");
    499 
    500         /*

regards,
dan carpenter

  parent reply	other threads:[~2026-02-06 13:40 UTC|newest]

Thread overview: 97+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-12-08 10:02 Support needed to continue Smatch work Dan Carpenter
2026-02-06 13:38 ` Dan Carpenter
2026-02-06 13:38   ` [bug report] net: ethtool: Introduce per-PHY DUMP operations Dan Carpenter
2026-02-06 17:04     ` Maxime Chevallier
2026-02-09  7:09       ` Dan Carpenter
2026-02-09  8:09         ` Maxime Chevallier
2026-02-09 13:10           ` Andrew Lunn
2026-02-10 10:37             ` Dan Carpenter
2026-02-06 13:38   ` [bug report] net: wwan: Add Qualcomm BAM-DMUX WWAN network driver Dan Carpenter
2026-02-06 15:12     ` Stephan Gerhold
2026-02-06 15:23       ` Dan Carpenter
2026-02-06 13:38   ` [bug report] iommu/amd: Introduce gDomID-to-hDomID Mapping and handle parent domain invalidation Dan Carpenter
2026-02-06 13:38   ` [bug report] drm/amdkfd: add debug set and clear address watch points operation Dan Carpenter
2026-02-06 13:38   ` [PATCH next] mtd: spi-nor: hisi-sfc: fix refcounting bug in hisi_spi_nor_register_all() Dan Carpenter
2026-02-06 13:38     ` Dan Carpenter
2026-02-06 14:14     ` Pratyush Yadav
2026-02-06 14:14       ` Pratyush Yadav
2026-02-06 14:22       ` Miquel Raynal
2026-02-06 14:22         ` Miquel Raynal
2026-02-06 14:23     ` Miquel Raynal
2026-02-06 14:23       ` Miquel Raynal
2026-02-06 13:39   ` [bug report] media: synopsys: add driver for the designware mipi csi-2 receiver Dan Carpenter
2026-02-06 13:39   ` [bug report] crush: remove forcefeed functionality Dan Carpenter
2026-02-06 20:44     ` Viacheslav Dubeyko
2026-02-06 13:39   ` [bug report] net: ethernet: ti: am65-cpsw: enable bc/mc storm prevention support Dan Carpenter
2026-02-06 13:39   ` [bug report] phy: qcom: qmp-usbc: Add QCS615 USB/DP PHY config and DP mode support Dan Carpenter
2026-02-06 13:39     ` Dan Carpenter
2026-02-17 15:27     ` Konrad Dybcio
2026-02-17 15:27       ` Konrad Dybcio
2026-02-27  5:11       ` Xiangxu Yin
2026-02-27  5:11         ` Xiangxu Yin
2026-02-06 13:39   ` [bug report] drm/amd/display: add DC changes for DCN351 Dan Carpenter
2026-02-06 13:39   ` [bug report] media: rockchip: rkcif: add support for rk3568 vicap mipi capture Dan Carpenter
2026-02-06 13:39     ` Dan Carpenter
2026-02-16 13:33     ` Michael Riesch
2026-02-16 13:33       ` Michael Riesch
2026-02-06 13:39   ` [bug report] drm/imagination: Add gpuid module parameter Dan Carpenter
2026-02-06 13:39   ` [bug report] ASoC: SOF: ipc4-control: Add support for generic bytes control Dan Carpenter
2026-02-06 13:39   ` [bug report] media: iris: gen1: Destroy internal buffers after FW releases Dan Carpenter
2026-02-06 13:39   ` [bug report] cifs: Fix locking usage for tcon fields Dan Carpenter
2026-02-06 13:40   ` [bug report] drm/xe: Avoid toggling schedule state to check LRC timestamp in TDR Dan Carpenter
2026-02-06 13:40   ` [bug report] iio: dac: adding support for Microchip MCP47FEB02 Dan Carpenter
2026-02-06 14:04     ` Andy Shevchenko
2026-02-06 14:33       ` Dan Carpenter
2026-02-06 15:14         ` Andy Shevchenko
2026-02-06 15:32           ` Dan Carpenter
2026-02-06 15:57             ` Andy Shevchenko
2026-02-10 10:26               ` Ariana.Lazar
2026-03-01 12:31                 ` Jonathan Cameron
2026-03-02 10:28                   ` Ariana.Lazar
2026-03-03 21:41                     ` Jonathan Cameron
2026-02-06 13:40   ` Dan Carpenter [this message]
2026-02-06 13:40   ` [bug report] io_uring: add task fork hook Dan Carpenter
2026-02-06 14:28     ` Jens Axboe
2026-02-06 13:40   ` [bug report] ACPI: battery: Adjust event notification routine Dan Carpenter
2026-02-06 21:28     ` [PATCH v1] ACPI: battery: Drop redundant check from acpi_battery_notify() Rafael J. Wysocki
2026-02-06 13:40   ` [bug report] iio: adc: Add support for ad4062 Dan Carpenter
2026-02-06 14:07     ` Andy Shevchenko
2026-03-01 12:34       ` Jonathan Cameron
2026-03-05 17:10         ` Jorge Marques
2026-02-06 13:40   ` [bug report] ext4: refactor zeroout path and handle all cases Dan Carpenter
2026-02-06 15:44     ` Ojaswin Mujoo
2026-02-06 13:40   ` [bug report] media: chips-media: wave5: Fix Null reference while testing fluster Dan Carpenter
2026-02-11  7:59     ` Nas Chung
2026-02-06 13:40   ` [bug report] phy: apple: Add Apple Type-C PHY Dan Carpenter
2026-02-06 13:40     ` Dan Carpenter
2026-02-06 21:47     ` Janne Grunau
2026-02-06 21:47       ` Janne Grunau
2026-02-06 21:48       ` Sven Peter
2026-02-06 21:48         ` Sven Peter
2026-02-06 13:40   ` [bug report] spi: stm32: properly fail on dma_request_chan error Dan Carpenter
2026-02-06 13:40   ` [bug report] tracing: Properly process error handling in event_hist_trigger_parse() Dan Carpenter
2026-02-06 13:40   ` [bug report] drm/amd/display: Only poll analog connectors Dan Carpenter
2026-02-06 13:41   ` [bug report] fs/ntfs3: Add initialization of super block Dan Carpenter
2026-02-09 10:20     ` Konstantin Komarov
2026-02-09 15:35     ` [PATCH] (resend: correct threading) fs/ntfs3: avoid calling run_get_entry() when run == NULL in ntfs_read_run_nb_ra() Konstantin Komarov
2026-02-06 13:41   ` [bug report] remoteproc: imx_rproc: Introduce prepare ops for imx_rproc_dcfg Dan Carpenter
2026-02-06 16:29     ` Mathieu Poirier
2026-02-08 11:45     ` Peng Fan
2026-02-06 13:41   ` [bug report] irqchip/ls-extirq: Convert to a platform driver to make it work again Dan Carpenter
2026-02-06 13:41   ` [bug report] soc: rockchip: grf: Support multiple grf to be handled Dan Carpenter
2026-02-06 13:41     ` Dan Carpenter
2026-02-06 13:41   ` [bug report] drm/amdgpu: fix possible fence leaks from job structure Dan Carpenter
2026-02-06 13:41   ` [bug report] bio: add allocation cache abstraction Dan Carpenter
2026-02-06 13:41   ` [bug report] ASoC: codecs: ACF bin parsing and check library file for aw88395 Dan Carpenter
2026-02-06 13:41   ` [bug report] xfrm: always fail xfrm_dev_{state,policy}_flush_secctx_check() Dan Carpenter
2026-02-06 14:05     ` Tetsuo Handa
2026-02-09  9:43   ` [bug report] wifi: mwifiex: Allocate dev name earlier for interface workqueue name Dan Carpenter
2026-02-09  9:44   ` [bug report] apparmor: add support loading per permission tagging Dan Carpenter
2026-02-10 17:15     ` [apparmor][PATCH] apparmor: fix signedness bug in unpack_tags() Massimiliano Pellizzer
2026-02-09  9:45   ` [bug report] regulator: s2mps11: add S2MPG10 regulator Dan Carpenter
2026-02-09 14:07     ` André Draszik
2026-02-10  8:43   ` [bug report] btrfs: tests: zoned: add tests cases for zoned code Dan Carpenter
2026-02-10 19:05     ` David Sterba
2026-02-10  8:51   ` [bug report] ASoC: SOF: sof-audio: Add support for loopback capture Dan Carpenter
2026-02-13  5:56   ` [bug report] bpf: Fix a potential use-after-free of BTF object Dan Carpenter
2026-02-13 10:29     ` Anton Protopopov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aYXvQxKqmjP_sdCd@stanley.mountain \
    --to=dan.carpenter@linaro.org \
    --cc=dmitry.baryshkov@oss.qualcomm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.