All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dan Carpenter <dan.carpenter@linaro.org>
To: "André Draszik" <andre.draszik@linaro.org>
Cc: "André Draszik" <andre.draszik@linaro.org>,
	linux-samsung-soc@vger.kernel.org,
	linux-kernel <linux-kernel@vger.kernel.org>
Subject: [bug report] regulator: s2mps11: add S2MPG10 regulator
Date: Mon, 9 Feb 2026 12:45:31 +0300	[thread overview]
Message-ID: <aYmsu8qREppwBESH@stanley.mountain> (raw)
In-Reply-To: <caa37f28-a2e8-4e0a-a9ce-a365ce805e4b@stanley.mountain>

[ Smatch checking is paused while we raise funding. #SadFace
  https://lore.kernel.org/all/aTaiGSbWZ9DJaGo7@stanley.mountain/ -dan ]

Hello André Draszik,

Commit a2b8b9f33ce3 ("regulator: s2mps11: add S2MPG10 regulator")
from Jan 22, 2026 (linux-next), leads to the following Smatch static
checker warning:

	drivers/regulator/s2mps11.c:483 s2mpg10_of_parse_cb()
	warn: off by one 'ext_control' == ARRAY_SIZE()?

drivers/regulator/s2mps11.c
    458         if (of_property_read_u32(np, "samsung,ext-control", &ext_control))
    459                 return 0;
    460 
    461         switch (s2mps11->dev_type) {
    462         case S2MPG10:
    463                 switch (desc->id) {
    464                 case S2MPG10_BUCK1 ... S2MPG10_BUCK7:
    465                 case S2MPG10_BUCK10:
    466                 case S2MPG10_LDO3 ... S2MPG10_LDO19:
    467                         if (ext_control > S2MPG10_EXTCTRL_TCXO_ON2)
    468                                 return -EINVAL;
    469                         break;
    470 
    471                 case S2MPG10_LDO20:
    472                         if (ext_control < S2MPG10_EXTCTRL_LDO20M_EN2 ||
    473                             ext_control > S2MPG10_EXTCTRL_LDO20M_EN)
    474                                 return -EINVAL;
    475                         break;
    476 
    477                 default:
    478                         return -EINVAL;
    479                 }
    480 
    481                 if (ext_control > ARRAY_SIZE(ext_control_s2mpg10))

This should be >= ARRAY_SIZE().  Although the earlier checks prevent an
out of bounds access, it's still worth fixing the sanity check.

    482                         return -EINVAL;
--> 483                 ext_control = ext_control_s2mpg10[ext_control];
    484                 break;
    485 
    486         case S2MPG11:
    487                 switch (desc->id) {
    488                 case S2MPG11_BUCK1 ... S2MPG11_BUCK3:

regards,
dan carpenter

  parent reply	other threads:[~2026-02-09  9:45 UTC|newest]

Thread overview: 97+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-12-08 10:02 Support needed to continue Smatch work Dan Carpenter
2026-02-06 13:38 ` Dan Carpenter
2026-02-06 13:38   ` [bug report] net: ethtool: Introduce per-PHY DUMP operations Dan Carpenter
2026-02-06 17:04     ` Maxime Chevallier
2026-02-09  7:09       ` Dan Carpenter
2026-02-09  8:09         ` Maxime Chevallier
2026-02-09 13:10           ` Andrew Lunn
2026-02-10 10:37             ` Dan Carpenter
2026-02-06 13:38   ` [bug report] net: wwan: Add Qualcomm BAM-DMUX WWAN network driver Dan Carpenter
2026-02-06 15:12     ` Stephan Gerhold
2026-02-06 15:23       ` Dan Carpenter
2026-02-06 13:38   ` [bug report] iommu/amd: Introduce gDomID-to-hDomID Mapping and handle parent domain invalidation Dan Carpenter
2026-02-06 13:38   ` [bug report] drm/amdkfd: add debug set and clear address watch points operation Dan Carpenter
2026-02-06 13:38   ` [PATCH next] mtd: spi-nor: hisi-sfc: fix refcounting bug in hisi_spi_nor_register_all() Dan Carpenter
2026-02-06 13:38     ` Dan Carpenter
2026-02-06 14:14     ` Pratyush Yadav
2026-02-06 14:14       ` Pratyush Yadav
2026-02-06 14:22       ` Miquel Raynal
2026-02-06 14:22         ` Miquel Raynal
2026-02-06 14:23     ` Miquel Raynal
2026-02-06 14:23       ` Miquel Raynal
2026-02-06 13:39   ` [bug report] media: synopsys: add driver for the designware mipi csi-2 receiver Dan Carpenter
2026-02-06 13:39   ` [bug report] crush: remove forcefeed functionality Dan Carpenter
2026-02-06 20:44     ` Viacheslav Dubeyko
2026-02-06 13:39   ` [bug report] net: ethernet: ti: am65-cpsw: enable bc/mc storm prevention support Dan Carpenter
2026-02-06 13:39   ` [bug report] phy: qcom: qmp-usbc: Add QCS615 USB/DP PHY config and DP mode support Dan Carpenter
2026-02-06 13:39     ` Dan Carpenter
2026-02-17 15:27     ` Konrad Dybcio
2026-02-17 15:27       ` Konrad Dybcio
2026-02-27  5:11       ` Xiangxu Yin
2026-02-27  5:11         ` Xiangxu Yin
2026-02-06 13:39   ` [bug report] drm/amd/display: add DC changes for DCN351 Dan Carpenter
2026-02-06 13:39   ` [bug report] media: rockchip: rkcif: add support for rk3568 vicap mipi capture Dan Carpenter
2026-02-06 13:39     ` Dan Carpenter
2026-02-16 13:33     ` Michael Riesch
2026-02-16 13:33       ` Michael Riesch
2026-02-06 13:39   ` [bug report] drm/imagination: Add gpuid module parameter Dan Carpenter
2026-02-06 13:39   ` [bug report] ASoC: SOF: ipc4-control: Add support for generic bytes control Dan Carpenter
2026-02-06 13:39   ` [bug report] media: iris: gen1: Destroy internal buffers after FW releases Dan Carpenter
2026-02-06 13:39   ` [bug report] cifs: Fix locking usage for tcon fields Dan Carpenter
2026-02-06 13:40   ` [bug report] drm/xe: Avoid toggling schedule state to check LRC timestamp in TDR Dan Carpenter
2026-02-06 13:40   ` [bug report] iio: dac: adding support for Microchip MCP47FEB02 Dan Carpenter
2026-02-06 14:04     ` Andy Shevchenko
2026-02-06 14:33       ` Dan Carpenter
2026-02-06 15:14         ` Andy Shevchenko
2026-02-06 15:32           ` Dan Carpenter
2026-02-06 15:57             ` Andy Shevchenko
2026-02-10 10:26               ` Ariana.Lazar
2026-03-01 12:31                 ` Jonathan Cameron
2026-03-02 10:28                   ` Ariana.Lazar
2026-03-03 21:41                     ` Jonathan Cameron
2026-02-06 13:40   ` [bug report] power: sequencing: qcom-wcn: add support for WCN39xx Dan Carpenter
2026-02-06 13:40   ` [bug report] io_uring: add task fork hook Dan Carpenter
2026-02-06 14:28     ` Jens Axboe
2026-02-06 13:40   ` [bug report] ACPI: battery: Adjust event notification routine Dan Carpenter
2026-02-06 21:28     ` [PATCH v1] ACPI: battery: Drop redundant check from acpi_battery_notify() Rafael J. Wysocki
2026-02-06 13:40   ` [bug report] iio: adc: Add support for ad4062 Dan Carpenter
2026-02-06 14:07     ` Andy Shevchenko
2026-03-01 12:34       ` Jonathan Cameron
2026-03-05 17:10         ` Jorge Marques
2026-02-06 13:40   ` [bug report] ext4: refactor zeroout path and handle all cases Dan Carpenter
2026-02-06 15:44     ` Ojaswin Mujoo
2026-02-06 13:40   ` [bug report] media: chips-media: wave5: Fix Null reference while testing fluster Dan Carpenter
2026-02-11  7:59     ` Nas Chung
2026-02-06 13:40   ` [bug report] phy: apple: Add Apple Type-C PHY Dan Carpenter
2026-02-06 13:40     ` Dan Carpenter
2026-02-06 21:47     ` Janne Grunau
2026-02-06 21:47       ` Janne Grunau
2026-02-06 21:48       ` Sven Peter
2026-02-06 21:48         ` Sven Peter
2026-02-06 13:40   ` [bug report] spi: stm32: properly fail on dma_request_chan error Dan Carpenter
2026-02-06 13:40   ` [bug report] tracing: Properly process error handling in event_hist_trigger_parse() Dan Carpenter
2026-02-06 13:40   ` [bug report] drm/amd/display: Only poll analog connectors Dan Carpenter
2026-02-06 13:41   ` [bug report] fs/ntfs3: Add initialization of super block Dan Carpenter
2026-02-09 10:20     ` Konstantin Komarov
2026-02-09 15:35     ` [PATCH] (resend: correct threading) fs/ntfs3: avoid calling run_get_entry() when run == NULL in ntfs_read_run_nb_ra() Konstantin Komarov
2026-02-06 13:41   ` [bug report] remoteproc: imx_rproc: Introduce prepare ops for imx_rproc_dcfg Dan Carpenter
2026-02-06 16:29     ` Mathieu Poirier
2026-02-08 11:45     ` Peng Fan
2026-02-06 13:41   ` [bug report] irqchip/ls-extirq: Convert to a platform driver to make it work again Dan Carpenter
2026-02-06 13:41   ` [bug report] soc: rockchip: grf: Support multiple grf to be handled Dan Carpenter
2026-02-06 13:41     ` Dan Carpenter
2026-02-06 13:41   ` [bug report] drm/amdgpu: fix possible fence leaks from job structure Dan Carpenter
2026-02-06 13:41   ` [bug report] bio: add allocation cache abstraction Dan Carpenter
2026-02-06 13:41   ` [bug report] ASoC: codecs: ACF bin parsing and check library file for aw88395 Dan Carpenter
2026-02-06 13:41   ` [bug report] xfrm: always fail xfrm_dev_{state,policy}_flush_secctx_check() Dan Carpenter
2026-02-06 14:05     ` Tetsuo Handa
2026-02-09  9:43   ` [bug report] wifi: mwifiex: Allocate dev name earlier for interface workqueue name Dan Carpenter
2026-02-09  9:44   ` [bug report] apparmor: add support loading per permission tagging Dan Carpenter
2026-02-10 17:15     ` [apparmor][PATCH] apparmor: fix signedness bug in unpack_tags() Massimiliano Pellizzer
2026-02-09  9:45   ` Dan Carpenter [this message]
2026-02-09 14:07     ` [bug report] regulator: s2mps11: add S2MPG10 regulator André Draszik
2026-02-10  8:43   ` [bug report] btrfs: tests: zoned: add tests cases for zoned code Dan Carpenter
2026-02-10 19:05     ` David Sterba
2026-02-10  8:51   ` [bug report] ASoC: SOF: sof-audio: Add support for loopback capture Dan Carpenter
2026-02-13  5:56   ` [bug report] bpf: Fix a potential use-after-free of BTF object Dan Carpenter
2026-02-13 10:29     ` Anton Protopopov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aYmsu8qREppwBESH@stanley.mountain \
    --to=dan.carpenter@linaro.org \
    --cc=andre.draszik@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.