* [PATCH] non-x86/symbols: check table sizes don't change between linking passes 2 and 3
@ 2026-02-02 14:45 Jan Beulich
2026-02-02 15:43 ` Bertrand Marquis
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Jan Beulich @ 2026-02-02 14:45 UTC (permalink / raw)
To: xen-devel@lists.xenproject.org
Cc: Julien Grall, Stefano Stabellini, Volodymyr Babchuk,
Bertrand Marquis, Michal Orzel, Timothy Pearson, Alistair Francis,
Connor Davis, Oleksii Kurochko
Extend commit 1df11ccceb1a ("symbols: check table sizes don't change
between linking passes 2 and 3") to other ports as well.
Signed-off-by: Jan Beulich <jbeulich@suse.com>
--- a/xen/arch/arm/Makefile
+++ b/xen/arch/arm/Makefile
@@ -99,6 +99,7 @@ $(TARGET)-syms: $(objtree)/prelink.o $(o
| $(objtree)/tools/symbols $(all_symbols) --sysv --sort \
> $(dot-target).2.S
$(MAKE) $(build)=$(@D) $(dot-target).2.o
+ $(call compare-symbol-tables, $(dot-target).1.o, $(dot-target).2.o)
$(LD) $(XEN_LDFLAGS) -T $(obj)/xen.lds $< $(build_id_linker) \
$(dot-target).2.o -o $@
$(NM) -pa --format=sysv $@ \
--- a/xen/arch/ppc/Makefile
+++ b/xen/arch/ppc/Makefile
@@ -26,6 +26,7 @@ $(TARGET)-syms: $(objtree)/prelink.o $(o
| $(objtree)/tools/symbols $(all_symbols) --sysv --sort \
> $(dot-target).2.S
$(MAKE) $(build)=$(@D) $(dot-target).2.o
+ $(call compare-symbol-tables, $(dot-target).1.o, $(dot-target).2.o)
$(LD) $(XEN_LDFLAGS) -T $(obj)/xen.lds $< $(build_id_linker) \
$(dot-target).2.o -o $@
$(NM) -pa --format=sysv $@ \
--- a/xen/arch/riscv/Makefile
+++ b/xen/arch/riscv/Makefile
@@ -40,6 +40,7 @@ $(TARGET)-syms: $(objtree)/prelink.o $(o
| $(objtree)/tools/symbols $(all_symbols) --sysv --sort \
> $(dot-target).2.S
$(MAKE) $(build)=$(@D) $(dot-target).2.o
+ $(call compare-symbol-tables, $(dot-target).1.o, $(dot-target).2.o)
$(LD) $(XEN_LDFLAGS) -T $(obj)/xen.lds $< $(build_id_linker) \
$(dot-target).2.o -o $@
$(NM) -pa --format=sysv $@ \
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] non-x86/symbols: check table sizes don't change between linking passes 2 and 3
2026-02-02 14:45 [PATCH] non-x86/symbols: check table sizes don't change between linking passes 2 and 3 Jan Beulich
@ 2026-02-02 15:43 ` Bertrand Marquis
2026-02-10 14:37 ` Roger Pau Monné
2026-02-10 16:45 ` Oleksii Kurochko
2 siblings, 0 replies; 5+ messages in thread
From: Bertrand Marquis @ 2026-02-02 15:43 UTC (permalink / raw)
To: Jan Beulich
Cc: xen-devel@lists.xenproject.org, Julien Grall, Stefano Stabellini,
Volodymyr Babchuk, Michal Orzel, Timothy Pearson,
Alistair Francis, Connor Davis, Oleksii Kurochko
Hi Jan,
I checked that xen on arm is still compiling properly with that so
> On 2 Feb 2026, at 15:45, Jan Beulich <jbeulich@suse.com> wrote:
>
> Extend commit 1df11ccceb1a ("symbols: check table sizes don't change
> between linking passes 2 and 3") to other ports as well.
>
> Signed-off-by: Jan Beulich <jbeulich@suse.com>
For Arm:
Acked-by: Bertrand Marquis <bertrand.marquis@arm.com>
Cheers
Bertrand
>
> --- a/xen/arch/arm/Makefile
> +++ b/xen/arch/arm/Makefile
> @@ -99,6 +99,7 @@ $(TARGET)-syms: $(objtree)/prelink.o $(o
> | $(objtree)/tools/symbols $(all_symbols) --sysv --sort \
> > $(dot-target).2.S
> $(MAKE) $(build)=$(@D) $(dot-target).2.o
> + $(call compare-symbol-tables, $(dot-target).1.o, $(dot-target).2.o)
> $(LD) $(XEN_LDFLAGS) -T $(obj)/xen.lds $< $(build_id_linker) \
> $(dot-target).2.o -o $@
> $(NM) -pa --format=sysv $@ \
> --- a/xen/arch/ppc/Makefile
> +++ b/xen/arch/ppc/Makefile
> @@ -26,6 +26,7 @@ $(TARGET)-syms: $(objtree)/prelink.o $(o
> | $(objtree)/tools/symbols $(all_symbols) --sysv --sort \
> > $(dot-target).2.S
> $(MAKE) $(build)=$(@D) $(dot-target).2.o
> + $(call compare-symbol-tables, $(dot-target).1.o, $(dot-target).2.o)
> $(LD) $(XEN_LDFLAGS) -T $(obj)/xen.lds $< $(build_id_linker) \
> $(dot-target).2.o -o $@
> $(NM) -pa --format=sysv $@ \
> --- a/xen/arch/riscv/Makefile
> +++ b/xen/arch/riscv/Makefile
> @@ -40,6 +40,7 @@ $(TARGET)-syms: $(objtree)/prelink.o $(o
> | $(objtree)/tools/symbols $(all_symbols) --sysv --sort \
> > $(dot-target).2.S
> $(MAKE) $(build)=$(@D) $(dot-target).2.o
> + $(call compare-symbol-tables, $(dot-target).1.o, $(dot-target).2.o)
> $(LD) $(XEN_LDFLAGS) -T $(obj)/xen.lds $< $(build_id_linker) \
> $(dot-target).2.o -o $@
> $(NM) -pa --format=sysv $@ \
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] non-x86/symbols: check table sizes don't change between linking passes 2 and 3
2026-02-02 14:45 [PATCH] non-x86/symbols: check table sizes don't change between linking passes 2 and 3 Jan Beulich
2026-02-02 15:43 ` Bertrand Marquis
@ 2026-02-10 14:37 ` Roger Pau Monné
2026-02-10 14:43 ` Jan Beulich
2026-02-10 16:45 ` Oleksii Kurochko
2 siblings, 1 reply; 5+ messages in thread
From: Roger Pau Monné @ 2026-02-10 14:37 UTC (permalink / raw)
To: Jan Beulich
Cc: xen-devel@lists.xenproject.org, Julien Grall, Stefano Stabellini,
Volodymyr Babchuk, Bertrand Marquis, Michal Orzel,
Timothy Pearson, Alistair Francis, Connor Davis, Oleksii Kurochko
On Mon, Feb 02, 2026 at 03:45:37PM +0100, Jan Beulich wrote:
> Extend commit 1df11ccceb1a ("symbols: check table sizes don't change
> between linking passes 2 and 3") to other ports as well.
>
> Signed-off-by: Jan Beulich <jbeulich@suse.com>
Acked-by: Roger Pau Monné <roger.pau@citrix.com>
Do you know whether the risc/ppc builds in the CI are OK after this?
Thanks, Roger.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] non-x86/symbols: check table sizes don't change between linking passes 2 and 3
2026-02-10 14:37 ` Roger Pau Monné
@ 2026-02-10 14:43 ` Jan Beulich
0 siblings, 0 replies; 5+ messages in thread
From: Jan Beulich @ 2026-02-10 14:43 UTC (permalink / raw)
To: Roger Pau Monné
Cc: xen-devel@lists.xenproject.org, Julien Grall, Stefano Stabellini,
Volodymyr Babchuk, Bertrand Marquis, Michal Orzel,
Timothy Pearson, Alistair Francis, Connor Davis, Oleksii Kurochko
On 10.02.2026 15:37, Roger Pau Monné wrote:
> On Mon, Feb 02, 2026 at 03:45:37PM +0100, Jan Beulich wrote:
>> Extend commit 1df11ccceb1a ("symbols: check table sizes don't change
>> between linking passes 2 and 3") to other ports as well.
>>
>> Signed-off-by: Jan Beulich <jbeulich@suse.com>
>
> Acked-by: Roger Pau Monné <roger.pau@citrix.com>
Thanks.
> Do you know whether the risc/ppc builds in the CI are OK after this?
Not yet, the pre-push testing will show. They are okay in my local builds.
Jan
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] non-x86/symbols: check table sizes don't change between linking passes 2 and 3
2026-02-02 14:45 [PATCH] non-x86/symbols: check table sizes don't change between linking passes 2 and 3 Jan Beulich
2026-02-02 15:43 ` Bertrand Marquis
2026-02-10 14:37 ` Roger Pau Monné
@ 2026-02-10 16:45 ` Oleksii Kurochko
2 siblings, 0 replies; 5+ messages in thread
From: Oleksii Kurochko @ 2026-02-10 16:45 UTC (permalink / raw)
To: Jan Beulich, xen-devel@lists.xenproject.org
Cc: Julien Grall, Stefano Stabellini, Volodymyr Babchuk,
Bertrand Marquis, Michal Orzel, Timothy Pearson, Alistair Francis,
Connor Davis
On 2/2/26 3:45 PM, Jan Beulich wrote:
> Extend commit 1df11ccceb1a ("symbols: check table sizes don't change
> between linking passes 2 and 3") to other ports as well.
>
> Signed-off-by: Jan Beulich <jbeulich@suse.com>
>
> --- a/xen/arch/arm/Makefile
> +++ b/xen/arch/arm/Makefile
> @@ -99,6 +99,7 @@ $(TARGET)-syms: $(objtree)/prelink.o $(o
> | $(objtree)/tools/symbols $(all_symbols) --sysv --sort \
> > $(dot-target).2.S
> $(MAKE) $(build)=$(@D) $(dot-target).2.o
> + $(call compare-symbol-tables, $(dot-target).1.o, $(dot-target).2.o)
> $(LD) $(XEN_LDFLAGS) -T $(obj)/xen.lds $< $(build_id_linker) \
> $(dot-target).2.o -o $@
> $(NM) -pa --format=sysv $@ \
> --- a/xen/arch/ppc/Makefile
> +++ b/xen/arch/ppc/Makefile
> @@ -26,6 +26,7 @@ $(TARGET)-syms: $(objtree)/prelink.o $(o
> | $(objtree)/tools/symbols $(all_symbols) --sysv --sort \
> > $(dot-target).2.S
> $(MAKE) $(build)=$(@D) $(dot-target).2.o
> + $(call compare-symbol-tables, $(dot-target).1.o, $(dot-target).2.o)
> $(LD) $(XEN_LDFLAGS) -T $(obj)/xen.lds $< $(build_id_linker) \
> $(dot-target).2.o -o $@
> $(NM) -pa --format=sysv $@ \
> --- a/xen/arch/riscv/Makefile
> +++ b/xen/arch/riscv/Makefile
> @@ -40,6 +40,7 @@ $(TARGET)-syms: $(objtree)/prelink.o $(o
> | $(objtree)/tools/symbols $(all_symbols) --sysv --sort \
> > $(dot-target).2.S
> $(MAKE) $(build)=$(@D) $(dot-target).2.o
> + $(call compare-symbol-tables, $(dot-target).1.o, $(dot-target).2.o)
> $(LD) $(XEN_LDFLAGS) -T $(obj)/xen.lds $< $(build_id_linker) \
> $(dot-target).2.o -o $@
> $(NM) -pa --format=sysv $@ \
Reviewed-by: Oleksii Kurochko <oleksii.kurochko@gmail.com>
Thanks.
~ Oleksii
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2026-02-10 16:45 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-02-02 14:45 [PATCH] non-x86/symbols: check table sizes don't change between linking passes 2 and 3 Jan Beulich
2026-02-02 15:43 ` Bertrand Marquis
2026-02-10 14:37 ` Roger Pau Monné
2026-02-10 14:43 ` Jan Beulich
2026-02-10 16:45 ` Oleksii Kurochko
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.