All of lore.kernel.org
 help / color / mirror / Atom feed
From: Catalin Marinas <catalin.marinas@arm.com>
To: "Edgecombe, Rick P" <rick.p.edgecombe@intel.com>
Cc: "david@kernel.org" <david@kernel.org>,
	"broonie@kernel.org" <broonie@kernel.org>,
	"akpm@linux-foundation.org" <akpm@linux-foundation.org>,
	"debug@rivosinc.com" <debug@rivosinc.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-riscv@lists.infradead.org"
	<linux-riscv@lists.infradead.org>, "bp@alien8.de" <bp@alien8.de>,
	"dave.hansen@linux.intel.com" <dave.hansen@linux.intel.com>,
	"pjw@kernel.org" <pjw@kernel.org>,
	"alex@ghiti.fr" <alex@ghiti.fr>,
	"aou@eecs.berkeley.edu" <aou@eecs.berkeley.edu>,
	"palmer@dabbelt.com" <palmer@dabbelt.com>,
	"will@kernel.org" <will@kernel.org>,
	"tglx@kernel.org" <tglx@kernel.org>,
	"hpa@zytor.com" <hpa@zytor.com>,
	"mingo@redhat.com" <mingo@redhat.com>,
	"linux-mm@kvack.org" <linux-mm@kvack.org>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH 4/5] x86: shstk: Use the new common vm_mmap_shadow_stack() helper
Date: Wed, 25 Feb 2026 08:12:28 +0000	[thread overview]
Message-ID: <aZ6u7LMfGmExzhS4@arm.com> (raw)
In-Reply-To: <eac72941ab8d9520cadc1b98bdcfd7e5d2ef14ca.camel@intel.com>

On Tue, Feb 24, 2026 at 07:47:14PM +0000, Edgecombe, Rick P wrote:
> On Tue, 2026-02-24 at 17:57 +0000, Catalin Marinas wrote:
> > Replace part of the x86 alloc_shstk() content with a call to
> > vm_mmap_shadow_stack().
> 
> I ran it through the selftest. It would be nice to have a bit more information
> in the log, like that there is no functional change. Otherwise,

Good point, I'll add this to the other arch patches as well.

> Reviewed-by: Rick Edgecombe <rick.p.edgecombe@intel.com>
> Tested-by: Rick Edgecombe <rick.p.edgecombe@intel.com>

Thanks.

-- 
Catalin


WARNING: multiple messages have this Message-ID (diff)
From: Catalin Marinas <catalin.marinas@arm.com>
To: "Edgecombe, Rick P" <rick.p.edgecombe@intel.com>
Cc: "david@kernel.org" <david@kernel.org>,
	"broonie@kernel.org" <broonie@kernel.org>,
	"akpm@linux-foundation.org" <akpm@linux-foundation.org>,
	"debug@rivosinc.com" <debug@rivosinc.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-riscv@lists.infradead.org"
	<linux-riscv@lists.infradead.org>, "bp@alien8.de" <bp@alien8.de>,
	"dave.hansen@linux.intel.com" <dave.hansen@linux.intel.com>,
	"pjw@kernel.org" <pjw@kernel.org>,
	"alex@ghiti.fr" <alex@ghiti.fr>,
	"aou@eecs.berkeley.edu" <aou@eecs.berkeley.edu>,
	"palmer@dabbelt.com" <palmer@dabbelt.com>,
	"will@kernel.org" <will@kernel.org>,
	"tglx@kernel.org" <tglx@kernel.org>,
	"hpa@zytor.com" <hpa@zytor.com>,
	"mingo@redhat.com" <mingo@redhat.com>,
	"linux-mm@kvack.org" <linux-mm@kvack.org>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH 4/5] x86: shstk: Use the new common vm_mmap_shadow_stack() helper
Date: Wed, 25 Feb 2026 08:12:28 +0000	[thread overview]
Message-ID: <aZ6u7LMfGmExzhS4@arm.com> (raw)
In-Reply-To: <eac72941ab8d9520cadc1b98bdcfd7e5d2ef14ca.camel@intel.com>

On Tue, Feb 24, 2026 at 07:47:14PM +0000, Edgecombe, Rick P wrote:
> On Tue, 2026-02-24 at 17:57 +0000, Catalin Marinas wrote:
> > Replace part of the x86 alloc_shstk() content with a call to
> > vm_mmap_shadow_stack().
> 
> I ran it through the selftest. It would be nice to have a bit more information
> in the log, like that there is no functional change. Otherwise,

Good point, I'll add this to the other arch patches as well.

> Reviewed-by: Rick Edgecombe <rick.p.edgecombe@intel.com>
> Tested-by: Rick Edgecombe <rick.p.edgecombe@intel.com>

Thanks.

-- 
Catalin

_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

  reply	other threads:[~2026-02-25  8:12 UTC|newest]

Thread overview: 42+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-24 17:57 [PATCH 0/5] mm: arch/shstk: Common shadow stack mapping helper and VM_NOHUGEPAGE Catalin Marinas
2026-02-24 17:57 ` Catalin Marinas
2026-02-24 17:57 ` [PATCH 1/5] mm: Introduce vm_mmap_shadow_stack() as a helper for VM_SHADOW_STACK mappings Catalin Marinas
2026-02-24 17:57   ` Catalin Marinas
2026-02-24 19:47   ` Edgecombe, Rick P
2026-02-24 19:47     ` Edgecombe, Rick P
2026-02-25 12:25   ` Mark Brown
2026-02-25 12:25     ` Mark Brown
2026-02-25 13:32   ` David Hildenbrand (Arm)
2026-02-25 13:32     ` David Hildenbrand (Arm)
2026-02-24 17:57 ` [PATCH 2/5] arm64: gcs: Use the new common vm_mmap_shadow_stack() helper Catalin Marinas
2026-02-24 17:57   ` Catalin Marinas
2026-02-25 13:32   ` David Hildenbrand (Arm)
2026-02-25 13:32     ` David Hildenbrand (Arm)
2026-02-25 13:41   ` Mark Brown
2026-02-25 13:41     ` Mark Brown
2026-02-24 17:57 ` [PATCH 3/5] riscv: shstk: " Catalin Marinas
2026-02-24 17:57   ` Catalin Marinas
2026-02-25 13:33   ` David Hildenbrand (Arm)
2026-02-25 13:33     ` David Hildenbrand (Arm)
2026-02-24 17:57 ` [PATCH 4/5] x86: " Catalin Marinas
2026-02-24 17:57   ` Catalin Marinas
2026-02-24 19:47   ` Edgecombe, Rick P
2026-02-24 19:47     ` Edgecombe, Rick P
2026-02-25  8:12     ` Catalin Marinas [this message]
2026-02-25  8:12       ` Catalin Marinas
2026-02-25 13:33   ` David Hildenbrand (Arm)
2026-02-25 13:33     ` David Hildenbrand (Arm)
2026-02-24 17:57 ` [PATCH 5/5] mm: Do not map the shadow stack as THP Catalin Marinas
2026-02-24 17:57   ` Catalin Marinas
2026-02-25 13:02   ` Mark Brown
2026-02-25 13:02     ` Mark Brown
2026-02-25 15:51     ` Catalin Marinas
2026-02-25 15:51       ` Catalin Marinas
2026-02-25 16:10       ` Mark Brown
2026-02-25 16:10         ` Mark Brown
2026-02-25 13:34   ` David Hildenbrand (Arm)
2026-02-25 13:34     ` David Hildenbrand (Arm)
2026-02-25  0:06 ` [PATCH 0/5] mm: arch/shstk: Common shadow stack mapping helper and VM_NOHUGEPAGE Deepak Gupta
2026-02-25  0:06   ` Deepak Gupta
2026-02-25  8:08   ` Catalin Marinas
2026-02-25  8:08     ` Catalin Marinas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aZ6u7LMfGmExzhS4@arm.com \
    --to=catalin.marinas@arm.com \
    --cc=akpm@linux-foundation.org \
    --cc=alex@ghiti.fr \
    --cc=aou@eecs.berkeley.edu \
    --cc=bp@alien8.de \
    --cc=broonie@kernel.org \
    --cc=dave.hansen@linux.intel.com \
    --cc=david@kernel.org \
    --cc=debug@rivosinc.com \
    --cc=hpa@zytor.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=linux-riscv@lists.infradead.org \
    --cc=mingo@redhat.com \
    --cc=palmer@dabbelt.com \
    --cc=pjw@kernel.org \
    --cc=rick.p.edgecombe@intel.com \
    --cc=tglx@kernel.org \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.