All of lore.kernel.org
 help / color / mirror / Atom feed
From: Niklas Cassel <cassel@kernel.org>
To: Manivannan Sadhasivam <mani@kernel.org>
Cc: "Bjorn Helgaas" <bhelgaas@google.com>,
	"Jingoo Han" <jingoohan1@gmail.com>,
	"Lorenzo Pieralisi" <lpieralisi@kernel.org>,
	"Krzysztof Wilczyński" <kwilczynski@kernel.org>,
	"Rob Herring" <robh@kernel.org>,
	"Koichiro Den" <den@valinux.co.jp>,
	"Shinichiro Kawasaki" <shinichiro.kawasaki@wdc.com>,
	linux-pci@vger.kernel.org
Subject: Re: [PATCH] PCI: dwc: ep: Fix regression in dw_pcie_ep_raise_msi_irq()
Date: Wed, 25 Feb 2026 16:51:59 +0100	[thread overview]
Message-ID: <aZ8an10tlBmWOKE6@ryzen> (raw)
In-Reply-To: <qxcf4idjsbscd5tlgsbt3yg6xyngkn3wgaubaedgr24dx3pcsx@ejbrdqpryipe>

On Wed, Feb 25, 2026 at 08:31:24PM +0530, Manivannan Sadhasivam wrote:
> On Tue, Feb 10, 2026 at 07:12:25PM +0100, Niklas Cassel wrote:
> > When using the nvmet-pci-epf EPF driver, and starting the EP before
> > starting a host with UEFI, the UEFI performs NVMe commands e.g.
> > Identify Controller, to get the name of the controller.
> > 
> > nvmet-pci-epf will post the CQE (completion queue entry) to the Admin
> > Completion Queue, and then raise an IRQ (using
> > dw_pcie_ep_raise_msi_irq()).
> > 
> > Once the host boots Linux, we will see a WARN_ON_ONCE() from
> > dw_pcie_ep_raise_msi_irq(), and then the booting of the host hangs,
> > because it never gets an IRQ when loading the nvme driver.
> > 
> > The reason is that the MSI target address used by UEFI and Linux might
> > be different, which will cause dw_pcie_ep_raise_msi_irq() to simply
> > return -EINVAL.
> > 
> > This was working before commit 8719c64e76bf ("PCI: dwc: ep: Cache MSI
> > outbound iATU mapping"), so this is a regression.
> > 
> > Also, remove the warning, as we cannot know if there are operations in
> > flight or not, so it seems wrong to print this warning unconditionally
> > at every boot when e.g. nvmet-pci-epf is used with a host with UEFI.
> > 
> > Fixes: 8719c64e76bf ("PCI: dwc: ep: Cache MSI outbound iATU mapping")
> > Signed-off-by: Niklas Cassel <cassel@kernel.org>
> 
> Acked-by: Manivannan Sadhasivam <mani@kernel.org>
> 
> Bjorn, since this patch fixes a regression introduced in v7.0, could you please
> take it for current -rc?


While not introduced in v7.0, it would be nice if you could also consider:
https://patchwork.kernel.org/project/linux-pci/patch/20260211175540.105677-2-cassel@kernel.org/

(Such that v7.0 could have both working dw_pcie_ep_raise_msix_irq() and
dw_pcie_ep_raise_msi_irq())


Kind regards,
Niklas

  reply	other threads:[~2026-02-25 15:52 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-10 18:12 [PATCH] PCI: dwc: ep: Fix regression in dw_pcie_ep_raise_msi_irq() Niklas Cassel
2026-02-10 19:32 ` Bjorn Helgaas
2026-02-10 20:22   ` Niklas Cassel
2026-02-10 20:33     ` Niklas Cassel
2026-02-10 20:39     ` Bjorn Helgaas
2026-02-11  8:52       ` Niklas Cassel
2026-02-11 18:08         ` Bjorn Helgaas
2026-02-25 14:59     ` Manivannan Sadhasivam
2026-02-11 16:44 ` Koichiro Den
2026-02-12  9:42 ` Shinichiro Kawasaki
2026-02-25 15:01 ` Manivannan Sadhasivam
2026-02-25 15:51   ` Niklas Cassel [this message]
2026-02-25 16:30     ` Manivannan Sadhasivam
2026-02-25 20:05 ` Bjorn Helgaas
2026-02-25 21:56   ` Niklas Cassel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aZ8an10tlBmWOKE6@ryzen \
    --to=cassel@kernel.org \
    --cc=bhelgaas@google.com \
    --cc=den@valinux.co.jp \
    --cc=jingoohan1@gmail.com \
    --cc=kwilczynski@kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=lpieralisi@kernel.org \
    --cc=mani@kernel.org \
    --cc=robh@kernel.org \
    --cc=shinichiro.kawasaki@wdc.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.