Re: [PATCH 0/3] Add Invensense ICM42607

From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Chris Morgan <macromorgan@hotmail.com>
Cc: Chris Morgan <macroalpha82@gmail.com>,
	linux-iio@vger.kernel.org, andy@kernel.org, nuno.sa@analog.com,
	dlechner@baylibre.com, jic23@kernel.org,
	jean-baptiste.maneyrol@tdk.com,
	linux-rockchip@lists.infradead.org, devicetree@vger.kernel.org,
	heiko@sntech.de, conor+dt@kernel.org, krzk+dt@kernel.org,
	robh@kernel.org
Subject: Re: [PATCH 0/3] Add Invensense ICM42607
Date: Wed, 25 Feb 2026 19:13:42 +0200	[thread overview]
Message-ID: <aZ8txsLe6GJcya8B@smile.fi.intel.com> (raw)
In-Reply-To: <SN6PR1901MB465422A4BAFD469CD6966E0BA575A@SN6PR1901MB4654.namprd19.prod.outlook.com>

On Wed, Feb 25, 2026 at 08:20:13AM -0600, Chris Morgan wrote:
> On Tue, Feb 24, 2026 at 07:41:35PM +0200, Andy Shevchenko wrote:
> > On Tue, Feb 24, 2026 at 10:31:02AM -0600, Chris Morgan wrote:
> > 
> > > Add support for the ICM42607 IMU. This sensor shares the same
> > > functionality but a different register layout with the existing
> > > ICM42600.
> > > 
> > > This driver should work with the ICM42607 and ICM42607P over both I2C
> > > and SPI, however only the ICM42607P over I2C could be tested.
> > 
> > Thanks for your contribution, but...
> > 
> > NAK.
> > 
> > It's unreviewable bulk out of 4kLoC! I even won't bother looking at any other
> > messages in this (too mini) series.
> > 
> > TL;DR: reviewable code is limited at ~750 (or less) ± 150 LoC per patch.
> 
> Please disregard this series then, I will do my best to split it apart
> into smaller pieces and resubmit.

Please do!

Also keep in mind that from the beginning the driver should work, so the split
mustn't be by-file, it should be by-feature / documentation.

-- 
With Best Regards,
Andy Shevchenko