Re: [PATCH v13] futex_waitv.2: new page

[Alejandro Colomar <alx@kernel.org>]

[-- Attachment #1: Type: text/plain, Size: 1269 bytes --]

Hi наб,

On 2026-02-17T17:17:03+0100, наб wrote:
> On Tue, Feb 17, 2026 at 04:46:28PM +0100, Alejandro Colomar wrote:
> > silence; let me know your opinion:
> > 
> > 	.tmp/man/man2/futex_waitv.2.d/futex_waitv.c:36:13: error: implicit use of sequentially-consistent atomic may incur stronger memory barriers than necessary [clang-diagnostic-atomic-implicit-seq-cst,-warnings-as-errors]
> > 	   36 |      usleep(*futex * 10000);
> > 	      |             ^
> > 
> > 
> > 	.tmp/man/man2/futex_waitv.2.d/futex_waitv.c:37:13: error: implicit use of sequentially-consistent atomic may incur stronger memory barriers than necessary [clang-diagnostic-atomic-implicit-seq-cst,-warnings-as-errors]
> > 	   37 |      *futex *= 2;
> > 	      |             ^
> > 
> > I have little knowledge about atomics, so can't judge, but the code
> > seems good to me.  Please confirm.
> Yeah, that's okay. Worst-case is it'll be marginally slower than
> something more verbose that specifies... acqrel? which would be minimal here.
> But that doesn't matter for example code.

Thanks!  Applied and pushed.  In a moment, I'll send a patch to refactor
the page, to see what you think of it.


Have a lovely night!
Alex

-- 
<https://www.alejandro-colomar.es>

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]