* [PATCH 0/3] ice: use better bitmap API
@ 2025-12-23 16:22 ` Yury Norov (NVIDIA)
0 siblings, 0 replies; 16+ messages in thread
From: Yury Norov (NVIDIA) @ 2025-12-23 16:22 UTC (permalink / raw)
To: Tony Nguyen, Przemek Kitszel, Andrew Lunn, David S. Miller,
Eric Dumazet, Jakub Kicinski, Paolo Abeni, Yury Norov,
Rasmus Villemoes, Andrew Morton, intel-wired-lan, netdev,
linux-kernel
Use better bitmap API where appropriate.
Yury Norov (NVIDIA) (3):
bitmap_weighted_xor()
ice: use bitmap_weighted_xor()
ice: use bitmap_empty() in ice_vf_has_no_qs_ena
drivers/net/ethernet/intel/ice/ice_switch.c | 4 +---
drivers/net/ethernet/intel/ice/ice_vf_lib.c | 4 ++--
include/linux/bitmap.h | 14 ++++++++++++++
lib/bitmap.c | 7 +++++++
4 files changed, 24 insertions(+), 5 deletions(-)
--
2.43.0
^ permalink raw reply [flat|nested] 16+ messages in thread
* [Intel-wired-lan] [PATCH 1/3] bitmap: introduce bitmap_weighted_xor()
2025-12-23 16:22 ` Yury Norov (NVIDIA)
@ 2025-12-23 16:23 ` Yury Norov (NVIDIA)
-1 siblings, 0 replies; 16+ messages in thread
From: Yury Norov (NVIDIA) @ 2025-12-23 16:23 UTC (permalink / raw)
To: Tony Nguyen, Przemek Kitszel, Andrew Lunn, David S. Miller,
Eric Dumazet, Jakub Kicinski, Paolo Abeni, Yury Norov,
Rasmus Villemoes, Andrew Morton, intel-wired-lan, netdev,
linux-kernel
The function helps to XOR bitmaps and calculate Hamming weight of
the result in one pass.
Signed-off-by: Yury Norov (NVIDIA) <yury.norov@gmail.com>
---
include/linux/bitmap.h | 14 ++++++++++++++
lib/bitmap.c | 7 +++++++
2 files changed, 21 insertions(+)
diff --git a/include/linux/bitmap.h b/include/linux/bitmap.h
index 0f4789e1f7cb..7ecf56e0d3b5 100644
--- a/include/linux/bitmap.h
+++ b/include/linux/bitmap.h
@@ -169,6 +169,8 @@ void __bitmap_or(unsigned long *dst, const unsigned long *bitmap1,
const unsigned long *bitmap2, unsigned int nbits);
unsigned int __bitmap_weighted_or(unsigned long *dst, const unsigned long *bitmap1,
const unsigned long *bitmap2, unsigned int nbits);
+unsigned int __bitmap_weighted_xor(unsigned long *dst, const unsigned long *bitmap1,
+ const unsigned long *bitmap2, unsigned int nbits);
void __bitmap_xor(unsigned long *dst, const unsigned long *bitmap1,
const unsigned long *bitmap2, unsigned int nbits);
bool __bitmap_andnot(unsigned long *dst, const unsigned long *bitmap1,
@@ -355,6 +357,18 @@ unsigned int bitmap_weighted_or(unsigned long *dst, const unsigned long *src1,
}
}
+static __always_inline
+unsigned int bitmap_weighted_xor(unsigned long *dst, const unsigned long *src1,
+ const unsigned long *src2, unsigned int nbits)
+{
+ if (small_const_nbits(nbits)) {
+ *dst = *src1 ^ *src2;
+ return hweight_long(*dst & BITMAP_LAST_WORD_MASK(nbits));
+ } else {
+ return __bitmap_weighted_xor(dst, src1, src2, nbits);
+ }
+}
+
static __always_inline
void bitmap_xor(unsigned long *dst, const unsigned long *src1,
const unsigned long *src2, unsigned int nbits)
diff --git a/lib/bitmap.c b/lib/bitmap.c
index 698d15933c84..bed32b8cd23a 100644
--- a/lib/bitmap.c
+++ b/lib/bitmap.c
@@ -382,6 +382,13 @@ unsigned int __bitmap_weighted_or(unsigned long *dst, const unsigned long *bitma
return BITMAP_WEIGHT(({dst[idx] = bitmap1[idx] | bitmap2[idx]; dst[idx]; }), bits);
}
+unsigned int __bitmap_weighted_xor(unsigned long *dst, const unsigned long *bitmap1,
+ const unsigned long *bitmap2, unsigned int bits)
+{
+ return BITMAP_WEIGHT(({dst[idx] = bitmap1[idx] ^ bitmap2[idx]; dst[idx]; }), bits);
+}
+EXPORT_SYMBOL(__bitmap_weighted_xor);
+
unsigned long __bitmap_weight_from(const unsigned long *bitmap,
unsigned int start, unsigned int nbits)
{
--
2.43.0
^ permalink raw reply related [flat|nested] 16+ messages in thread* [PATCH 1/3] bitmap: introduce bitmap_weighted_xor()
@ 2025-12-23 16:23 ` Yury Norov (NVIDIA)
0 siblings, 0 replies; 16+ messages in thread
From: Yury Norov (NVIDIA) @ 2025-12-23 16:23 UTC (permalink / raw)
To: Tony Nguyen, Przemek Kitszel, Andrew Lunn, David S. Miller,
Eric Dumazet, Jakub Kicinski, Paolo Abeni, Yury Norov,
Rasmus Villemoes, Andrew Morton, intel-wired-lan, netdev,
linux-kernel
The function helps to XOR bitmaps and calculate Hamming weight of
the result in one pass.
Signed-off-by: Yury Norov (NVIDIA) <yury.norov@gmail.com>
---
include/linux/bitmap.h | 14 ++++++++++++++
lib/bitmap.c | 7 +++++++
2 files changed, 21 insertions(+)
diff --git a/include/linux/bitmap.h b/include/linux/bitmap.h
index 0f4789e1f7cb..7ecf56e0d3b5 100644
--- a/include/linux/bitmap.h
+++ b/include/linux/bitmap.h
@@ -169,6 +169,8 @@ void __bitmap_or(unsigned long *dst, const unsigned long *bitmap1,
const unsigned long *bitmap2, unsigned int nbits);
unsigned int __bitmap_weighted_or(unsigned long *dst, const unsigned long *bitmap1,
const unsigned long *bitmap2, unsigned int nbits);
+unsigned int __bitmap_weighted_xor(unsigned long *dst, const unsigned long *bitmap1,
+ const unsigned long *bitmap2, unsigned int nbits);
void __bitmap_xor(unsigned long *dst, const unsigned long *bitmap1,
const unsigned long *bitmap2, unsigned int nbits);
bool __bitmap_andnot(unsigned long *dst, const unsigned long *bitmap1,
@@ -355,6 +357,18 @@ unsigned int bitmap_weighted_or(unsigned long *dst, const unsigned long *src1,
}
}
+static __always_inline
+unsigned int bitmap_weighted_xor(unsigned long *dst, const unsigned long *src1,
+ const unsigned long *src2, unsigned int nbits)
+{
+ if (small_const_nbits(nbits)) {
+ *dst = *src1 ^ *src2;
+ return hweight_long(*dst & BITMAP_LAST_WORD_MASK(nbits));
+ } else {
+ return __bitmap_weighted_xor(dst, src1, src2, nbits);
+ }
+}
+
static __always_inline
void bitmap_xor(unsigned long *dst, const unsigned long *src1,
const unsigned long *src2, unsigned int nbits)
diff --git a/lib/bitmap.c b/lib/bitmap.c
index 698d15933c84..bed32b8cd23a 100644
--- a/lib/bitmap.c
+++ b/lib/bitmap.c
@@ -382,6 +382,13 @@ unsigned int __bitmap_weighted_or(unsigned long *dst, const unsigned long *bitma
return BITMAP_WEIGHT(({dst[idx] = bitmap1[idx] | bitmap2[idx]; dst[idx]; }), bits);
}
+unsigned int __bitmap_weighted_xor(unsigned long *dst, const unsigned long *bitmap1,
+ const unsigned long *bitmap2, unsigned int bits)
+{
+ return BITMAP_WEIGHT(({dst[idx] = bitmap1[idx] ^ bitmap2[idx]; dst[idx]; }), bits);
+}
+EXPORT_SYMBOL(__bitmap_weighted_xor);
+
unsigned long __bitmap_weight_from(const unsigned long *bitmap,
unsigned int start, unsigned int nbits)
{
--
2.43.0
^ permalink raw reply related [flat|nested] 16+ messages in thread
* [Intel-wired-lan] [PATCH 2/3] ice: use bitmap_weighted_xor() in ice_find_free_recp_res_idx()
2025-12-23 16:22 ` Yury Norov (NVIDIA)
@ 2025-12-23 16:23 ` Yury Norov (NVIDIA)
-1 siblings, 0 replies; 16+ messages in thread
From: Yury Norov (NVIDIA) @ 2025-12-23 16:23 UTC (permalink / raw)
To: Tony Nguyen, Przemek Kitszel, Andrew Lunn, David S. Miller,
Eric Dumazet, Jakub Kicinski, Paolo Abeni, Yury Norov,
Rasmus Villemoes, Andrew Morton, intel-wired-lan, netdev,
linux-kernel
Use the right helper and save one bitmaps traverse.
Signed-off-by: Yury Norov (NVIDIA) <yury.norov@gmail.com>
---
drivers/net/ethernet/intel/ice/ice_switch.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/net/ethernet/intel/ice/ice_switch.c b/drivers/net/ethernet/intel/ice/ice_switch.c
index 84848f0123e7..903417477929 100644
--- a/drivers/net/ethernet/intel/ice/ice_switch.c
+++ b/drivers/net/ethernet/intel/ice/ice_switch.c
@@ -4984,10 +4984,8 @@ ice_find_free_recp_res_idx(struct ice_hw *hw, const unsigned long *profiles,
hw->switch_info->recp_list[bit].res_idxs,
ICE_MAX_FV_WORDS);
- bitmap_xor(free_idx, used_idx, possible_idx, ICE_MAX_FV_WORDS);
-
/* return number of free indexes */
- return (u16)bitmap_weight(free_idx, ICE_MAX_FV_WORDS);
+ return (u16)bitmap_weighted_xor(free_idx, used_idx, possible_idx, ICE_MAX_FV_WORDS);
}
/**
--
2.43.0
^ permalink raw reply related [flat|nested] 16+ messages in thread
* [PATCH 2/3] ice: use bitmap_weighted_xor() in ice_find_free_recp_res_idx()
@ 2025-12-23 16:23 ` Yury Norov (NVIDIA)
0 siblings, 0 replies; 16+ messages in thread
From: Yury Norov (NVIDIA) @ 2025-12-23 16:23 UTC (permalink / raw)
To: Tony Nguyen, Przemek Kitszel, Andrew Lunn, David S. Miller,
Eric Dumazet, Jakub Kicinski, Paolo Abeni, Yury Norov,
Rasmus Villemoes, Andrew Morton, intel-wired-lan, netdev,
linux-kernel
Use the right helper and save one bitmaps traverse.
Signed-off-by: Yury Norov (NVIDIA) <yury.norov@gmail.com>
---
drivers/net/ethernet/intel/ice/ice_switch.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/net/ethernet/intel/ice/ice_switch.c b/drivers/net/ethernet/intel/ice/ice_switch.c
index 84848f0123e7..903417477929 100644
--- a/drivers/net/ethernet/intel/ice/ice_switch.c
+++ b/drivers/net/ethernet/intel/ice/ice_switch.c
@@ -4984,10 +4984,8 @@ ice_find_free_recp_res_idx(struct ice_hw *hw, const unsigned long *profiles,
hw->switch_info->recp_list[bit].res_idxs,
ICE_MAX_FV_WORDS);
- bitmap_xor(free_idx, used_idx, possible_idx, ICE_MAX_FV_WORDS);
-
/* return number of free indexes */
- return (u16)bitmap_weight(free_idx, ICE_MAX_FV_WORDS);
+ return (u16)bitmap_weighted_xor(free_idx, used_idx, possible_idx, ICE_MAX_FV_WORDS);
}
/**
--
2.43.0
^ permalink raw reply related [flat|nested] 16+ messages in thread
* Re: [Intel-wired-lan] [PATCH 2/3] ice: use bitmap_weighted_xor() in ice_find_free_recp_res_idx()
2025-12-23 16:23 ` Yury Norov (NVIDIA)
@ 2025-12-23 19:08 ` David Laight
-1 siblings, 0 replies; 16+ messages in thread
From: David Laight @ 2025-12-23 19:08 UTC (permalink / raw)
To: Yury Norov (NVIDIA)
Cc: Tony Nguyen, Przemek Kitszel, Andrew Lunn, David S. Miller,
Eric Dumazet, Jakub Kicinski, Paolo Abeni, Rasmus Villemoes,
Andrew Morton, intel-wired-lan, netdev, linux-kernel
On Tue, 23 Dec 2025 11:23:01 -0500
"Yury Norov (NVIDIA)" <yury.norov@gmail.com> wrote:
> Use the right helper and save one bitmaps traverse.
It makes no difference here.
The bitmap has 48 entries and is just a single 'long' on 64bit.
It is also already in a very slow path that has iterated all the
'set' bit of two bitmaps.
The code is also pretty convoluted and confusing already.
One of the other bitmaps has 64 entries, recoding using u64 would
make it a bit more readable.
Doing the 'weight' here is also just optimising for failure.
Oh, and using u8 and u16 for function parameters, return values and
maths requires extra instructions and is usually a bad idea.
Dvaid
>
> Signed-off-by: Yury Norov (NVIDIA) <yury.norov@gmail.com>
> ---
> drivers/net/ethernet/intel/ice/ice_switch.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/net/ethernet/intel/ice/ice_switch.c b/drivers/net/ethernet/intel/ice/ice_switch.c
> index 84848f0123e7..903417477929 100644
> --- a/drivers/net/ethernet/intel/ice/ice_switch.c
> +++ b/drivers/net/ethernet/intel/ice/ice_switch.c
> @@ -4984,10 +4984,8 @@ ice_find_free_recp_res_idx(struct ice_hw *hw, const unsigned long *profiles,
> hw->switch_info->recp_list[bit].res_idxs,
> ICE_MAX_FV_WORDS);
>
> - bitmap_xor(free_idx, used_idx, possible_idx, ICE_MAX_FV_WORDS);
> -
> /* return number of free indexes */
> - return (u16)bitmap_weight(free_idx, ICE_MAX_FV_WORDS);
> + return (u16)bitmap_weighted_xor(free_idx, used_idx, possible_idx, ICE_MAX_FV_WORDS);
> }
>
> /**
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH 2/3] ice: use bitmap_weighted_xor() in ice_find_free_recp_res_idx()
@ 2025-12-23 19:08 ` David Laight
0 siblings, 0 replies; 16+ messages in thread
From: David Laight @ 2025-12-23 19:08 UTC (permalink / raw)
To: Yury Norov (NVIDIA)
Cc: Tony Nguyen, Przemek Kitszel, Andrew Lunn, David S. Miller,
Eric Dumazet, Jakub Kicinski, Paolo Abeni, Rasmus Villemoes,
Andrew Morton, intel-wired-lan, netdev, linux-kernel
On Tue, 23 Dec 2025 11:23:01 -0500
"Yury Norov (NVIDIA)" <yury.norov@gmail.com> wrote:
> Use the right helper and save one bitmaps traverse.
It makes no difference here.
The bitmap has 48 entries and is just a single 'long' on 64bit.
It is also already in a very slow path that has iterated all the
'set' bit of two bitmaps.
The code is also pretty convoluted and confusing already.
One of the other bitmaps has 64 entries, recoding using u64 would
make it a bit more readable.
Doing the 'weight' here is also just optimising for failure.
Oh, and using u8 and u16 for function parameters, return values and
maths requires extra instructions and is usually a bad idea.
Dvaid
>
> Signed-off-by: Yury Norov (NVIDIA) <yury.norov@gmail.com>
> ---
> drivers/net/ethernet/intel/ice/ice_switch.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/net/ethernet/intel/ice/ice_switch.c b/drivers/net/ethernet/intel/ice/ice_switch.c
> index 84848f0123e7..903417477929 100644
> --- a/drivers/net/ethernet/intel/ice/ice_switch.c
> +++ b/drivers/net/ethernet/intel/ice/ice_switch.c
> @@ -4984,10 +4984,8 @@ ice_find_free_recp_res_idx(struct ice_hw *hw, const unsigned long *profiles,
> hw->switch_info->recp_list[bit].res_idxs,
> ICE_MAX_FV_WORDS);
>
> - bitmap_xor(free_idx, used_idx, possible_idx, ICE_MAX_FV_WORDS);
> -
> /* return number of free indexes */
> - return (u16)bitmap_weight(free_idx, ICE_MAX_FV_WORDS);
> + return (u16)bitmap_weighted_xor(free_idx, used_idx, possible_idx, ICE_MAX_FV_WORDS);
> }
>
> /**
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [Intel-wired-lan] [PATCH 2/3] ice: use bitmap_weighted_xor() in ice_find_free_recp_res_idx()
2025-12-23 19:08 ` David Laight
@ 2026-02-22 17:59 ` Yury Norov
-1 siblings, 0 replies; 16+ messages in thread
From: Yury Norov via Intel-wired-lan @ 2026-02-22 17:59 UTC (permalink / raw)
To: David Laight
Cc: Yury Norov (NVIDIA), Tony Nguyen, Przemek Kitszel, Andrew Lunn,
David S. Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni,
Rasmus Villemoes, Andrew Morton, intel-wired-lan, netdev,
linux-kernel
On Tue, Dec 23, 2025 at 07:08:46PM +0000, David Laight wrote:
> On Tue, 23 Dec 2025 11:23:01 -0500
> "Yury Norov (NVIDIA)" <yury.norov@gmail.com> wrote:
>
> > Use the right helper and save one bitmaps traverse.
>
> It makes no difference here.
No it makes.
> The bitmap has 48 entries and is just a single 'long' on 64bit.
> It is also already in a very slow path that has iterated all the
> 'set' bit of two bitmaps.
>
> The code is also pretty convoluted and confusing already.
> One of the other bitmaps has 64 entries, recoding using u64 would
> make it a bit more readable.
>
> Doing the 'weight' here is also just optimising for failure.
We've introduced bitmap_weighted_or() recently, and now we need to add
siblings to the new sub-class. Regardless of performance impact in this
case, having a dedicated helper for a typical operations saves a lot in
debugging. This is proven by decades of code development.
> Oh, and using u8 and u16 for function parameters, return values and
> maths requires extra instructions and is usually a bad idea.
Changing function signatures is not the patch purpose. Feel free to
submit a separate patch.
> Dvaid
>
> >
> > Signed-off-by: Yury Norov (NVIDIA) <yury.norov@gmail.com>
> > ---
> > drivers/net/ethernet/intel/ice/ice_switch.c | 4 +---
> > 1 file changed, 1 insertion(+), 3 deletions(-)
> >
> > diff --git a/drivers/net/ethernet/intel/ice/ice_switch.c b/drivers/net/ethernet/intel/ice/ice_switch.c
> > index 84848f0123e7..903417477929 100644
> > --- a/drivers/net/ethernet/intel/ice/ice_switch.c
> > +++ b/drivers/net/ethernet/intel/ice/ice_switch.c
> > @@ -4984,10 +4984,8 @@ ice_find_free_recp_res_idx(struct ice_hw *hw, const unsigned long *profiles,
> > hw->switch_info->recp_list[bit].res_idxs,
> > ICE_MAX_FV_WORDS);
> >
> > - bitmap_xor(free_idx, used_idx, possible_idx, ICE_MAX_FV_WORDS);
> > -
> > /* return number of free indexes */
> > - return (u16)bitmap_weight(free_idx, ICE_MAX_FV_WORDS);
> > + return (u16)bitmap_weighted_xor(free_idx, used_idx, possible_idx, ICE_MAX_FV_WORDS);
> > }
> >
> > /**
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH 2/3] ice: use bitmap_weighted_xor() in ice_find_free_recp_res_idx()
@ 2026-02-22 17:59 ` Yury Norov
0 siblings, 0 replies; 16+ messages in thread
From: Yury Norov @ 2026-02-22 17:59 UTC (permalink / raw)
To: David Laight
Cc: Yury Norov (NVIDIA), Tony Nguyen, Przemek Kitszel, Andrew Lunn,
David S. Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni,
Rasmus Villemoes, Andrew Morton, intel-wired-lan, netdev,
linux-kernel
On Tue, Dec 23, 2025 at 07:08:46PM +0000, David Laight wrote:
> On Tue, 23 Dec 2025 11:23:01 -0500
> "Yury Norov (NVIDIA)" <yury.norov@gmail.com> wrote:
>
> > Use the right helper and save one bitmaps traverse.
>
> It makes no difference here.
No it makes.
> The bitmap has 48 entries and is just a single 'long' on 64bit.
> It is also already in a very slow path that has iterated all the
> 'set' bit of two bitmaps.
>
> The code is also pretty convoluted and confusing already.
> One of the other bitmaps has 64 entries, recoding using u64 would
> make it a bit more readable.
>
> Doing the 'weight' here is also just optimising for failure.
We've introduced bitmap_weighted_or() recently, and now we need to add
siblings to the new sub-class. Regardless of performance impact in this
case, having a dedicated helper for a typical operations saves a lot in
debugging. This is proven by decades of code development.
> Oh, and using u8 and u16 for function parameters, return values and
> maths requires extra instructions and is usually a bad idea.
Changing function signatures is not the patch purpose. Feel free to
submit a separate patch.
> Dvaid
>
> >
> > Signed-off-by: Yury Norov (NVIDIA) <yury.norov@gmail.com>
> > ---
> > drivers/net/ethernet/intel/ice/ice_switch.c | 4 +---
> > 1 file changed, 1 insertion(+), 3 deletions(-)
> >
> > diff --git a/drivers/net/ethernet/intel/ice/ice_switch.c b/drivers/net/ethernet/intel/ice/ice_switch.c
> > index 84848f0123e7..903417477929 100644
> > --- a/drivers/net/ethernet/intel/ice/ice_switch.c
> > +++ b/drivers/net/ethernet/intel/ice/ice_switch.c
> > @@ -4984,10 +4984,8 @@ ice_find_free_recp_res_idx(struct ice_hw *hw, const unsigned long *profiles,
> > hw->switch_info->recp_list[bit].res_idxs,
> > ICE_MAX_FV_WORDS);
> >
> > - bitmap_xor(free_idx, used_idx, possible_idx, ICE_MAX_FV_WORDS);
> > -
> > /* return number of free indexes */
> > - return (u16)bitmap_weight(free_idx, ICE_MAX_FV_WORDS);
> > + return (u16)bitmap_weighted_xor(free_idx, used_idx, possible_idx, ICE_MAX_FV_WORDS);
> > }
> >
> > /**
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [Intel-wired-lan] [PATCH 2/3] ice: use bitmap_weighted_xor() in ice_find_free_recp_res_idx()
2026-02-22 17:59 ` Yury Norov
@ 2026-02-24 22:50 ` Tony Nguyen
-1 siblings, 0 replies; 16+ messages in thread
From: Tony Nguyen @ 2026-02-24 22:50 UTC (permalink / raw)
To: Yury Norov, David Laight
Cc: Yury Norov (NVIDIA), Przemek Kitszel, Andrew Lunn,
David S. Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni,
Rasmus Villemoes, Andrew Morton, intel-wired-lan, netdev,
linux-kernel
On 2/22/2026 9:59 AM, Yury Norov wrote:
> On Tue, Dec 23, 2025 at 07:08:46PM +0000, David Laight wrote:
>> On Tue, 23 Dec 2025 11:23:01 -0500
>> "Yury Norov (NVIDIA)" <yury.norov@gmail.com> wrote:
>>
>>> Use the right helper and save one bitmaps traverse.
>>
>> It makes no difference here.
>
> No it makes.
>
>> The bitmap has 48 entries and is just a single 'long' on 64bit.
>> It is also already in a very slow path that has iterated all the
>> 'set' bit of two bitmaps.
>>
>> The code is also pretty convoluted and confusing already.
>> One of the other bitmaps has 64 entries, recoding using u64 would
>> make it a bit more readable.
>>
>> Doing the 'weight' here is also just optimising for failure.
>
> We've introduced bitmap_weighted_or() recently, and now we need to add
> siblings to the new sub-class. Regardless of performance impact in this
> case, having a dedicated helper for a typical operations saves a lot in
> debugging. This is proven by decades of code development.
I agree, performance issues aside, I could see the utility in having a
combined helper. It makes is a little cleaner and removes a point for
introducing problems. Assuming there are no objections, could you resend
the series? It'll be easier than digging back to get these.
Thanks,
Tony
>> Oh, and using u8 and u16 for function parameters, return values and
>> maths requires extra instructions and is usually a bad idea.
>
> Changing function signatures is not the patch purpose. Feel free to
> submit a separate patch.
>
>> Dvaid
>>
>>>
>>> Signed-off-by: Yury Norov (NVIDIA) <yury.norov@gmail.com>
>>> ---
>>> drivers/net/ethernet/intel/ice/ice_switch.c | 4 +---
>>> 1 file changed, 1 insertion(+), 3 deletions(-)
>>>
>>> diff --git a/drivers/net/ethernet/intel/ice/ice_switch.c b/drivers/net/ethernet/intel/ice/ice_switch.c
>>> index 84848f0123e7..903417477929 100644
>>> --- a/drivers/net/ethernet/intel/ice/ice_switch.c
>>> +++ b/drivers/net/ethernet/intel/ice/ice_switch.c
>>> @@ -4984,10 +4984,8 @@ ice_find_free_recp_res_idx(struct ice_hw *hw, const unsigned long *profiles,
>>> hw->switch_info->recp_list[bit].res_idxs,
>>> ICE_MAX_FV_WORDS);
>>>
>>> - bitmap_xor(free_idx, used_idx, possible_idx, ICE_MAX_FV_WORDS);
>>> -
>>> /* return number of free indexes */
>>> - return (u16)bitmap_weight(free_idx, ICE_MAX_FV_WORDS);
>>> + return (u16)bitmap_weighted_xor(free_idx, used_idx, possible_idx, ICE_MAX_FV_WORDS);
>>> }
>>>
>>> /**
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH 2/3] ice: use bitmap_weighted_xor() in ice_find_free_recp_res_idx()
@ 2026-02-24 22:50 ` Tony Nguyen
0 siblings, 0 replies; 16+ messages in thread
From: Tony Nguyen @ 2026-02-24 22:50 UTC (permalink / raw)
To: Yury Norov, David Laight
Cc: Yury Norov (NVIDIA), Przemek Kitszel, Andrew Lunn,
David S. Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni,
Rasmus Villemoes, Andrew Morton, intel-wired-lan, netdev,
linux-kernel
On 2/22/2026 9:59 AM, Yury Norov wrote:
> On Tue, Dec 23, 2025 at 07:08:46PM +0000, David Laight wrote:
>> On Tue, 23 Dec 2025 11:23:01 -0500
>> "Yury Norov (NVIDIA)" <yury.norov@gmail.com> wrote:
>>
>>> Use the right helper and save one bitmaps traverse.
>>
>> It makes no difference here.
>
> No it makes.
>
>> The bitmap has 48 entries and is just a single 'long' on 64bit.
>> It is also already in a very slow path that has iterated all the
>> 'set' bit of two bitmaps.
>>
>> The code is also pretty convoluted and confusing already.
>> One of the other bitmaps has 64 entries, recoding using u64 would
>> make it a bit more readable.
>>
>> Doing the 'weight' here is also just optimising for failure.
>
> We've introduced bitmap_weighted_or() recently, and now we need to add
> siblings to the new sub-class. Regardless of performance impact in this
> case, having a dedicated helper for a typical operations saves a lot in
> debugging. This is proven by decades of code development.
I agree, performance issues aside, I could see the utility in having a
combined helper. It makes is a little cleaner and removes a point for
introducing problems. Assuming there are no objections, could you resend
the series? It'll be easier than digging back to get these.
Thanks,
Tony
>> Oh, and using u8 and u16 for function parameters, return values and
>> maths requires extra instructions and is usually a bad idea.
>
> Changing function signatures is not the patch purpose. Feel free to
> submit a separate patch.
>
>> Dvaid
>>
>>>
>>> Signed-off-by: Yury Norov (NVIDIA) <yury.norov@gmail.com>
>>> ---
>>> drivers/net/ethernet/intel/ice/ice_switch.c | 4 +---
>>> 1 file changed, 1 insertion(+), 3 deletions(-)
>>>
>>> diff --git a/drivers/net/ethernet/intel/ice/ice_switch.c b/drivers/net/ethernet/intel/ice/ice_switch.c
>>> index 84848f0123e7..903417477929 100644
>>> --- a/drivers/net/ethernet/intel/ice/ice_switch.c
>>> +++ b/drivers/net/ethernet/intel/ice/ice_switch.c
>>> @@ -4984,10 +4984,8 @@ ice_find_free_recp_res_idx(struct ice_hw *hw, const unsigned long *profiles,
>>> hw->switch_info->recp_list[bit].res_idxs,
>>> ICE_MAX_FV_WORDS);
>>>
>>> - bitmap_xor(free_idx, used_idx, possible_idx, ICE_MAX_FV_WORDS);
>>> -
>>> /* return number of free indexes */
>>> - return (u16)bitmap_weight(free_idx, ICE_MAX_FV_WORDS);
>>> + return (u16)bitmap_weighted_xor(free_idx, used_idx, possible_idx, ICE_MAX_FV_WORDS);
>>> }
>>>
>>> /**
^ permalink raw reply [flat|nested] 16+ messages in thread
* [Intel-wired-lan] [PATCH 3/3] ice: use bitmap_empty() in ice_vf_has_no_qs_ena
2025-12-23 16:22 ` Yury Norov (NVIDIA)
@ 2025-12-23 16:23 ` Yury Norov (NVIDIA)
-1 siblings, 0 replies; 16+ messages in thread
From: Yury Norov (NVIDIA) @ 2025-12-23 16:23 UTC (permalink / raw)
To: Tony Nguyen, Przemek Kitszel, Andrew Lunn, David S. Miller,
Eric Dumazet, Jakub Kicinski, Paolo Abeni, Yury Norov,
Rasmus Villemoes, Andrew Morton, intel-wired-lan, netdev,
linux-kernel
bitmap_empty() is more verbose and efficient, as it stops traversing
{r,t}xq_ena as soon as the 1st set bit found.
Signed-off-by: Yury Norov (NVIDIA) <yury.norov@gmail.com>
---
drivers/net/ethernet/intel/ice/ice_vf_lib.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/intel/ice/ice_vf_lib.c b/drivers/net/ethernet/intel/ice/ice_vf_lib.c
index de9e81ccee66..2b359752a158 100644
--- a/drivers/net/ethernet/intel/ice/ice_vf_lib.c
+++ b/drivers/net/ethernet/intel/ice/ice_vf_lib.c
@@ -1210,8 +1210,8 @@ bool ice_is_vf_trusted(struct ice_vf *vf)
*/
bool ice_vf_has_no_qs_ena(struct ice_vf *vf)
{
- return (!bitmap_weight(vf->rxq_ena, ICE_MAX_RSS_QS_PER_VF) &&
- !bitmap_weight(vf->txq_ena, ICE_MAX_RSS_QS_PER_VF));
+ return bitmap_empty(vf->rxq_ena, ICE_MAX_RSS_QS_PER_VF) &&
+ bitmap_empty(vf->txq_ena, ICE_MAX_RSS_QS_PER_VF);
}
/**
--
2.43.0
^ permalink raw reply related [flat|nested] 16+ messages in thread* [PATCH 3/3] ice: use bitmap_empty() in ice_vf_has_no_qs_ena
@ 2025-12-23 16:23 ` Yury Norov (NVIDIA)
0 siblings, 0 replies; 16+ messages in thread
From: Yury Norov (NVIDIA) @ 2025-12-23 16:23 UTC (permalink / raw)
To: Tony Nguyen, Przemek Kitszel, Andrew Lunn, David S. Miller,
Eric Dumazet, Jakub Kicinski, Paolo Abeni, Yury Norov,
Rasmus Villemoes, Andrew Morton, intel-wired-lan, netdev,
linux-kernel
bitmap_empty() is more verbose and efficient, as it stops traversing
{r,t}xq_ena as soon as the 1st set bit found.
Signed-off-by: Yury Norov (NVIDIA) <yury.norov@gmail.com>
---
drivers/net/ethernet/intel/ice/ice_vf_lib.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/intel/ice/ice_vf_lib.c b/drivers/net/ethernet/intel/ice/ice_vf_lib.c
index de9e81ccee66..2b359752a158 100644
--- a/drivers/net/ethernet/intel/ice/ice_vf_lib.c
+++ b/drivers/net/ethernet/intel/ice/ice_vf_lib.c
@@ -1210,8 +1210,8 @@ bool ice_is_vf_trusted(struct ice_vf *vf)
*/
bool ice_vf_has_no_qs_ena(struct ice_vf *vf)
{
- return (!bitmap_weight(vf->rxq_ena, ICE_MAX_RSS_QS_PER_VF) &&
- !bitmap_weight(vf->txq_ena, ICE_MAX_RSS_QS_PER_VF));
+ return bitmap_empty(vf->rxq_ena, ICE_MAX_RSS_QS_PER_VF) &&
+ bitmap_empty(vf->txq_ena, ICE_MAX_RSS_QS_PER_VF);
}
/**
--
2.43.0
^ permalink raw reply related [flat|nested] 16+ messages in thread
* Re: [Intel-wired-lan] [PATCH 0/3] ice: use better bitmap API
2025-12-23 16:22 ` Yury Norov (NVIDIA)
@ 2026-02-22 18:00 ` Yury Norov
-1 siblings, 0 replies; 16+ messages in thread
From: Yury Norov via Intel-wired-lan @ 2026-02-22 18:00 UTC (permalink / raw)
To: Yury Norov (NVIDIA)
Cc: Tony Nguyen, Przemek Kitszel, Andrew Lunn, David S. Miller,
Eric Dumazet, Jakub Kicinski, Paolo Abeni, Rasmus Villemoes,
Andrew Morton, intel-wired-lan, netdev, linux-kernel
Ping?
On Tue, Dec 23, 2025 at 11:22:59AM -0500, Yury Norov (NVIDIA) wrote:
> Use better bitmap API where appropriate.
>
> Yury Norov (NVIDIA) (3):
> bitmap_weighted_xor()
> ice: use bitmap_weighted_xor()
> ice: use bitmap_empty() in ice_vf_has_no_qs_ena
>
> drivers/net/ethernet/intel/ice/ice_switch.c | 4 +---
> drivers/net/ethernet/intel/ice/ice_vf_lib.c | 4 ++--
> include/linux/bitmap.h | 14 ++++++++++++++
> lib/bitmap.c | 7 +++++++
> 4 files changed, 24 insertions(+), 5 deletions(-)
>
> --
> 2.43.0
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH 0/3] ice: use better bitmap API
@ 2026-02-22 18:00 ` Yury Norov
0 siblings, 0 replies; 16+ messages in thread
From: Yury Norov @ 2026-02-22 18:00 UTC (permalink / raw)
To: Yury Norov (NVIDIA)
Cc: Tony Nguyen, Przemek Kitszel, Andrew Lunn, David S. Miller,
Eric Dumazet, Jakub Kicinski, Paolo Abeni, Rasmus Villemoes,
Andrew Morton, intel-wired-lan, netdev, linux-kernel
Ping?
On Tue, Dec 23, 2025 at 11:22:59AM -0500, Yury Norov (NVIDIA) wrote:
> Use better bitmap API where appropriate.
>
> Yury Norov (NVIDIA) (3):
> bitmap_weighted_xor()
> ice: use bitmap_weighted_xor()
> ice: use bitmap_empty() in ice_vf_has_no_qs_ena
>
> drivers/net/ethernet/intel/ice/ice_switch.c | 4 +---
> drivers/net/ethernet/intel/ice/ice_vf_lib.c | 4 ++--
> include/linux/bitmap.h | 14 ++++++++++++++
> lib/bitmap.c | 7 +++++++
> 4 files changed, 24 insertions(+), 5 deletions(-)
>
> --
> 2.43.0
^ permalink raw reply [flat|nested] 16+ messages in thread