* [PATCH] hw/misc/virt_ctrl: Fix incorrect trace event in read operation
@ 2026-01-11 18:49 Kuan-Wei Chiu
2026-02-22 17:55 ` Kuan-Wei Chiu
2026-02-22 21:45 ` Philippe Mathieu-Daudé
0 siblings, 2 replies; 3+ messages in thread
From: Kuan-Wei Chiu @ 2026-01-11 18:49 UTC (permalink / raw)
To: laurent; +Cc: jserv, qemu-devel, Kuan-Wei Chiu
The virt_ctrl_read() function currently invokes trace_virt_ctrl_write()
instead of trace_virt_ctrl_read(). This results in read operations
appearing as write operations in the trace output, which is misleading
during debugging and analysis.
Replace the incorrect trace call with the proper read-specific trace
event to accurately reflect the hardware behavior.
Fixes: 0791bc02b8fb ("m68k: add a system controller")
Signed-off-by: Kuan-Wei Chiu <visitorckw@gmail.com>
---
hw/misc/virt_ctrl.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/misc/virt_ctrl.c b/hw/misc/virt_ctrl.c
index 40747925a2..9b82e97ffd 100644
--- a/hw/misc/virt_ctrl.c
+++ b/hw/misc/virt_ctrl.c
@@ -43,7 +43,7 @@ static uint64_t virt_ctrl_read(void *opaque, hwaddr addr, unsigned size)
break;
}
- trace_virt_ctrl_write(s, addr, size, value);
+ trace_virt_ctrl_read(s, addr, size, value);
return value;
}
--
2.52.0.457.g6b5491de43-goog
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] hw/misc/virt_ctrl: Fix incorrect trace event in read operation
2026-01-11 18:49 [PATCH] hw/misc/virt_ctrl: Fix incorrect trace event in read operation Kuan-Wei Chiu
@ 2026-02-22 17:55 ` Kuan-Wei Chiu
2026-02-22 21:45 ` Philippe Mathieu-Daudé
1 sibling, 0 replies; 3+ messages in thread
From: Kuan-Wei Chiu @ 2026-02-22 17:55 UTC (permalink / raw)
To: laurent; +Cc: jserv, qemu-devel
Hi Laurent,
On Sun, Jan 11, 2026 at 06:49:15PM +0000, Kuan-Wei Chiu wrote:
> The virt_ctrl_read() function currently invokes trace_virt_ctrl_write()
> instead of trace_virt_ctrl_read(). This results in read operations
> appearing as write operations in the trace output, which is misleading
> during debugging and analysis.
>
> Replace the incorrect trace call with the proper read-specific trace
> event to accurately reflect the hardware behavior.
>
> Fixes: 0791bc02b8fb ("m68k: add a system controller")
> Signed-off-by: Kuan-Wei Chiu <visitorckw@gmail.com>
> ---
> hw/misc/virt_ctrl.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Any comments on this patch?
Regards,
Kuan-Wei
>
> diff --git a/hw/misc/virt_ctrl.c b/hw/misc/virt_ctrl.c
> index 40747925a2..9b82e97ffd 100644
> --- a/hw/misc/virt_ctrl.c
> +++ b/hw/misc/virt_ctrl.c
> @@ -43,7 +43,7 @@ static uint64_t virt_ctrl_read(void *opaque, hwaddr addr, unsigned size)
> break;
> }
>
> - trace_virt_ctrl_write(s, addr, size, value);
> + trace_virt_ctrl_read(s, addr, size, value);
>
> return value;
> }
> --
> 2.52.0.457.g6b5491de43-goog
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] hw/misc/virt_ctrl: Fix incorrect trace event in read operation
2026-01-11 18:49 [PATCH] hw/misc/virt_ctrl: Fix incorrect trace event in read operation Kuan-Wei Chiu
2026-02-22 17:55 ` Kuan-Wei Chiu
@ 2026-02-22 21:45 ` Philippe Mathieu-Daudé
1 sibling, 0 replies; 3+ messages in thread
From: Philippe Mathieu-Daudé @ 2026-02-22 21:45 UTC (permalink / raw)
To: Kuan-Wei Chiu, laurent; +Cc: jserv, qemu-devel
On 11/1/26 19:49, Kuan-Wei Chiu wrote:
> The virt_ctrl_read() function currently invokes trace_virt_ctrl_write()
> instead of trace_virt_ctrl_read(). This results in read operations
> appearing as write operations in the trace output, which is misleading
> during debugging and analysis.
>
> Replace the incorrect trace call with the proper read-specific trace
> event to accurately reflect the hardware behavior.
>
> Fixes: 0791bc02b8fb ("m68k: add a system controller")
> Signed-off-by: Kuan-Wei Chiu <visitorckw@gmail.com>
> ---
> hw/misc/virt_ctrl.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
And queued, thanks!
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2026-02-22 21:58 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-01-11 18:49 [PATCH] hw/misc/virt_ctrl: Fix incorrect trace event in read operation Kuan-Wei Chiu
2026-02-22 17:55 ` Kuan-Wei Chiu
2026-02-22 21:45 ` Philippe Mathieu-Daudé
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.