From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>,
Andy Gross <agross@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konrad.dybcio@somainline.org>,
Rob Clark <robdclark@gmail.com>, Sean Paul <sean@poorly.run>,
Abhinav Kumar <quic_abhinavk@quicinc.com>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>
Cc: Stephen Boyd <swboyd@chromium.org>,
David Airlie <airlied@gmail.com>, Daniel Vetter <daniel@ffwll.ch>,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org,
Vinod Koul <vkoul@kernel.org>
Subject: Re: [PATCH v1 5/5] arm64: dts: qcom: sm8450-hdk: Enable HDMI Display
Date: Fri, 4 Nov 2022 10:20:54 -0400 [thread overview]
Message-ID: <aa1c6223-e56c-b0b3-ed74-25cdeee36fb7@linaro.org> (raw)
In-Reply-To: <20221104131358.1025987-6-dmitry.baryshkov@linaro.org>
On 04/11/2022 09:13, Dmitry Baryshkov wrote:
> From: Vinod Koul <vkoul@kernel.org>
>
> Add the HDMI display nodes and link it to DSI. Also enable missing dispcc
> nodes
>
> Signed-off-by: Vinod Koul <vkoul@kernel.org>
> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Thank you for your patch. There is something to discuss/improve.
> +&dispcc {
> + status = "okay";
> +};
> +
> &dsi0 {
> status = "okay";
> vdda-supply = <&vreg_l6b_1p2>;
> +
> + ports {
> + port@1 {
> + endpoint {
> + remote-endpoint = <<9611_a>;
> + data-lanes = <0 1 2 3>;
> + };
> + };
> + };
> +
Drop blank line.
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Best regards,
Krzysztof
WARNING: multiple messages have this Message-ID (diff)
From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>,
Andy Gross <agross@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konrad.dybcio@somainline.org>,
Rob Clark <robdclark@gmail.com>, Sean Paul <sean@poorly.run>,
Abhinav Kumar <quic_abhinavk@quicinc.com>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>
Cc: devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org,
dri-devel@lists.freedesktop.org,
Stephen Boyd <swboyd@chromium.org>, Vinod Koul <vkoul@kernel.org>,
freedreno@lists.freedesktop.org
Subject: Re: [PATCH v1 5/5] arm64: dts: qcom: sm8450-hdk: Enable HDMI Display
Date: Fri, 4 Nov 2022 10:20:54 -0400 [thread overview]
Message-ID: <aa1c6223-e56c-b0b3-ed74-25cdeee36fb7@linaro.org> (raw)
In-Reply-To: <20221104131358.1025987-6-dmitry.baryshkov@linaro.org>
On 04/11/2022 09:13, Dmitry Baryshkov wrote:
> From: Vinod Koul <vkoul@kernel.org>
>
> Add the HDMI display nodes and link it to DSI. Also enable missing dispcc
> nodes
>
> Signed-off-by: Vinod Koul <vkoul@kernel.org>
> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Thank you for your patch. There is something to discuss/improve.
> +&dispcc {
> + status = "okay";
> +};
> +
> &dsi0 {
> status = "okay";
> vdda-supply = <&vreg_l6b_1p2>;
> +
> + ports {
> + port@1 {
> + endpoint {
> + remote-endpoint = <<9611_a>;
> + data-lanes = <0 1 2 3>;
> + };
> + };
> + };
> +
Drop blank line.
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Best regards,
Krzysztof
next prev parent reply other threads:[~2022-11-04 14:22 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-04 13:13 [PATCH v1 0/5] arm64: dts: qcom: sm8450-hdk: enable HDMI output Dmitry Baryshkov
2022-11-04 13:13 ` Dmitry Baryshkov
2022-11-04 13:13 ` [PATCH v1 1/5] arm64: dts: qcom: sm8450: add RPMH_REGULATOR_LEVEL_LOW_SVS_D1 Dmitry Baryshkov
2022-11-04 13:13 ` Dmitry Baryshkov
2022-11-04 14:13 ` Konrad Dybcio
2022-11-04 14:13 ` Konrad Dybcio
2022-11-04 13:13 ` [PATCH v1 2/5] arm64: dts: qcom: sm8450: add display hardware devices Dmitry Baryshkov
2022-11-04 13:13 ` Dmitry Baryshkov
2022-11-04 14:15 ` Konrad Dybcio
2022-11-04 14:15 ` Konrad Dybcio
2022-11-04 14:17 ` Krzysztof Kozlowski
2022-11-04 14:17 ` Krzysztof Kozlowski
2022-11-04 13:13 ` [PATCH v1 3/5] arm64: dts: qcom: sm8450-hdk: enable display hardware Dmitry Baryshkov
2022-11-04 13:13 ` Dmitry Baryshkov
2022-11-04 14:16 ` Konrad Dybcio
2022-11-04 14:16 ` Konrad Dybcio
2022-11-04 15:15 ` Vinod Koul
2022-11-04 15:15 ` Vinod Koul
2022-11-06 4:30 ` Bjorn Andersson
2022-11-06 4:30 ` Bjorn Andersson
2022-11-07 10:46 ` Konrad Dybcio
2022-11-07 10:46 ` Konrad Dybcio
2022-11-07 11:36 ` Krzysztof Kozlowski
2022-11-07 11:36 ` Krzysztof Kozlowski
2022-11-07 11:46 ` Konrad Dybcio
2022-11-07 11:46 ` Konrad Dybcio
2022-11-04 13:13 ` [PATCH v1 4/5] arm64: dts: qcom: sm8450-hdk: Add LT9611uxc HDMI bridge Dmitry Baryshkov
2022-11-04 13:13 ` Dmitry Baryshkov
2022-11-04 14:17 ` Konrad Dybcio
2022-11-04 14:17 ` Konrad Dybcio
2022-11-04 14:20 ` Krzysztof Kozlowski
2022-11-04 14:20 ` Krzysztof Kozlowski
2022-11-04 13:13 ` [PATCH v1 5/5] arm64: dts: qcom: sm8450-hdk: Enable HDMI Display Dmitry Baryshkov
2022-11-04 13:13 ` Dmitry Baryshkov
2022-11-04 14:19 ` Konrad Dybcio
2022-11-04 14:19 ` Konrad Dybcio
2022-11-04 14:20 ` Krzysztof Kozlowski [this message]
2022-11-04 14:20 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aa1c6223-e56c-b0b3-ed74-25cdeee36fb7@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=agross@kernel.org \
--cc=airlied@gmail.com \
--cc=andersson@kernel.org \
--cc=daniel@ffwll.ch \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=freedreno@lists.freedesktop.org \
--cc=konrad.dybcio@somainline.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=quic_abhinavk@quicinc.com \
--cc=robdclark@gmail.com \
--cc=robh+dt@kernel.org \
--cc=sean@poorly.run \
--cc=swboyd@chromium.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.