All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rajkumar Manoharan <rmanohar@codeaurora.org>
To: Michal Kazior <michal.kazior@tieto.com>
Cc: linux-wireless <linux-wireless@vger.kernel.org>,
	Rajkumar Manoharan <rmanohar@qti.qualcomm.com>,
	ath10k@lists.infradead.org
Subject: Re: [PATCH v3] ath10k: move mgmt descriptor limit handle under mgmt_tx
Date: Tue, 08 Mar 2016 18:24:13 +0530	[thread overview]
Message-ID: <aa44bd32c9f94d8d1a90840189ac0602@codeaurora.org> (raw)
In-Reply-To: <CA+BoTQ=Huzf7WoXMXcyj8yrykrJOd5BMc1EnmccqZgt7M1M_uA@mail.gmail.com>

On , Michal Kazior wrote:
> On 8 March 2016 at 12:54, Rajkumar Manoharan 
> <rmanohar@qti.qualcomm.com> wrote:
> [...]
>> +int ath10k_htt_tx_mgmt_inc_pending(struct ath10k_htt *htt, bool 
>> is_mgmt,
>> +                                  bool is_presp)
>>  {
>>         struct ath10k *ar = htt->ar;
>> 
>>         lockdep_assert_held(&htt->tx_lock);
>> 
>> +       if (!is_mgmt)
>> +               return 0;
>> +
> 
>>         if (htt->num_pending_tx >= htt->max_num_pending_tx)
>>                 return -EBUSY;
> 
> This busy here will be hit when you use last tx slot because
> tx_inc_pending() is called before tx_mgmt_inc_pending().
> 
Yeah.. now this condition is not needed as 
ath10k_htt_tx_mgmt_inc_pending
will be called only when tx_inc_pending succeeds. will remove this.

> 
> [...]
>>         skb_cb = ATH10K_SKB_CB(msdu);
>>         txq = skb_cb->txq;
>>         artxq = (void *)txq->drv_priv;
>> 
>> -       if (unlikely(skb_cb->flags & ATH10K_SKB_F_MGMT) &&
>> -           ar->hw_params.max_probe_resp_desc_thres)
>> -               limit_mgmt_desc = true;
>> -
> 
> Oh wait.. I didn't pay attention before, but this looks rather ugly.
> With this you will actually make the num_pending_mgmt_tx spin
> endlessly upwards on firmware with HTT 3.0 (and uses TX_FRM for mgmt
> tx and TX_COMPL_IND for completions), no?
> 
Oops.. num_pending_mgmt_tx should be incremented only for MGMT_TX. Thats
why it is moved out of txrx_tx_unref.

-Rajkumar

_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k

WARNING: multiple messages have this Message-ID (diff)
From: Rajkumar Manoharan <rmanohar@codeaurora.org>
To: Michal Kazior <michal.kazior@tieto.com>
Cc: Rajkumar Manoharan <rmanohar@qti.qualcomm.com>,
	ath10k@lists.infradead.org,
	linux-wireless <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH v3] ath10k: move mgmt descriptor limit handle under mgmt_tx
Date: Tue, 08 Mar 2016 18:24:13 +0530	[thread overview]
Message-ID: <aa44bd32c9f94d8d1a90840189ac0602@codeaurora.org> (raw)
In-Reply-To: <CA+BoTQ=Huzf7WoXMXcyj8yrykrJOd5BMc1EnmccqZgt7M1M_uA@mail.gmail.com>

On , Michal Kazior wrote:
> On 8 March 2016 at 12:54, Rajkumar Manoharan 
> <rmanohar@qti.qualcomm.com> wrote:
> [...]
>> +int ath10k_htt_tx_mgmt_inc_pending(struct ath10k_htt *htt, bool 
>> is_mgmt,
>> +                                  bool is_presp)
>>  {
>>         struct ath10k *ar = htt->ar;
>> 
>>         lockdep_assert_held(&htt->tx_lock);
>> 
>> +       if (!is_mgmt)
>> +               return 0;
>> +
> 
>>         if (htt->num_pending_tx >= htt->max_num_pending_tx)
>>                 return -EBUSY;
> 
> This busy here will be hit when you use last tx slot because
> tx_inc_pending() is called before tx_mgmt_inc_pending().
> 
Yeah.. now this condition is not needed as 
ath10k_htt_tx_mgmt_inc_pending
will be called only when tx_inc_pending succeeds. will remove this.

> 
> [...]
>>         skb_cb = ATH10K_SKB_CB(msdu);
>>         txq = skb_cb->txq;
>>         artxq = (void *)txq->drv_priv;
>> 
>> -       if (unlikely(skb_cb->flags & ATH10K_SKB_F_MGMT) &&
>> -           ar->hw_params.max_probe_resp_desc_thres)
>> -               limit_mgmt_desc = true;
>> -
> 
> Oh wait.. I didn't pay attention before, but this looks rather ugly.
> With this you will actually make the num_pending_mgmt_tx spin
> endlessly upwards on firmware with HTT 3.0 (and uses TX_FRM for mgmt
> tx and TX_COMPL_IND for completions), no?
> 
Oops.. num_pending_mgmt_tx should be incremented only for MGMT_TX. Thats
why it is moved out of txrx_tx_unref.

-Rajkumar

  reply	other threads:[~2016-03-08 12:54 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-08 11:54 [PATCH v3] ath10k: move mgmt descriptor limit handle under mgmt_tx Rajkumar Manoharan
2016-03-08 11:54 ` Rajkumar Manoharan
2016-03-08 12:40 ` Michal Kazior
2016-03-08 12:40   ` Michal Kazior
2016-03-08 12:54   ` Rajkumar Manoharan [this message]
2016-03-08 12:54     ` Rajkumar Manoharan
2016-03-08 13:01     ` Michal Kazior
2016-03-08 13:01       ` Michal Kazior
2016-03-08 16:43       ` Rajkumar Manoharan
2016-03-08 16:43         ` Rajkumar Manoharan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aa44bd32c9f94d8d1a90840189ac0602@codeaurora.org \
    --to=rmanohar@codeaurora.org \
    --cc=ath10k@lists.infradead.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=michal.kazior@tieto.com \
    --cc=rmanohar@qti.qualcomm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.