All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] drm/i915/alpm: ALPM disable fixes
@ 2026-02-12  6:27 Jouni Högander
  2026-02-12  6:49 ` ✓ CI.KUnit: success for " Patchwork
                   ` (6 more replies)
  0 siblings, 7 replies; 11+ messages in thread
From: Jouni Högander @ 2026-02-12  6:27 UTC (permalink / raw)
  To: intel-gfx, intel-xe
  Cc: Jouni Högander, Animesh Manna, Jani Nikula, stable

PORT_ALPM_CTL is supposed to be written only before link training. Remove
writing it from ALPM disable.

Also clearing ALPM_CTL_ALPM_AUX_LESS_ENABLE and is not about disabling ALPM
but switching to AUX-Wake ALPM. Stop touching this bit on ALPM disable.

Closes: https://gitlab.freedesktop.org/drm/xe/kernel/-/issues/7153
Fixes: 1ccbf135862b ("drm/i915/psr: Enable ALPM on source side for eDP Panel replay")
Cc: Animesh Manna <animesh.manna@intel.com>
Cc: Jani Nikula <jani.nikula@linux.intel.com>
Cc: <stable@vger.kernel.org> # v6.10+
Signed-off-by: Jouni Högander <jouni.hogander@intel.com>
---
 drivers/gpu/drm/i915/display/intel_alpm.c | 7 +------
 1 file changed, 1 insertion(+), 6 deletions(-)

diff --git a/drivers/gpu/drm/i915/display/intel_alpm.c b/drivers/gpu/drm/i915/display/intel_alpm.c
index e0a4a59dc025..b3334bc4d0f9 100644
--- a/drivers/gpu/drm/i915/display/intel_alpm.c
+++ b/drivers/gpu/drm/i915/display/intel_alpm.c
@@ -604,12 +604,7 @@ void intel_alpm_disable(struct intel_dp *intel_dp)
 	mutex_lock(&intel_dp->alpm.lock);
 
 	intel_de_rmw(display, ALPM_CTL(display, cpu_transcoder),
-		     ALPM_CTL_ALPM_ENABLE | ALPM_CTL_LOBF_ENABLE |
-		     ALPM_CTL_ALPM_AUX_LESS_ENABLE, 0);
-
-	intel_de_rmw(display,
-		     PORT_ALPM_CTL(cpu_transcoder),
-		     PORT_ALPM_CTL_ALPM_AUX_LESS_ENABLE, 0);
+		     ALPM_CTL_ALPM_ENABLE | ALPM_CTL_LOBF_ENABLE, 0);
 
 	drm_dbg_kms(display->drm, "Disabling ALPM\n");
 	mutex_unlock(&intel_dp->alpm.lock);
-- 
2.43.0


^ permalink raw reply related	[flat|nested] 11+ messages in thread
end of thread, other threads:[~2026-02-26 10:53 UTC | newest]

Thread overview: 11+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-02-12  6:27 [PATCH] drm/i915/alpm: ALPM disable fixes Jouni Högander
2026-02-12  6:49 ` ✓ CI.KUnit: success for " Patchwork
2026-02-12  7:25 ` ✓ Xe.CI.BAT: " Patchwork
2026-02-12  7:52 ` ✓ i915.CI.BAT: " Patchwork
2026-02-12 10:54 ` ✓ i915.CI.Full: " Patchwork
2026-02-13 10:13 ` ✗ Xe.CI.FULL: failure " Patchwork
2026-02-20 10:07   ` Hogander, Jouni
2026-02-20  8:06 ` [PATCH] " Michał Grzelak
2026-02-20 10:38   ` Hogander, Jouni
2026-02-26  9:12 ` Ville Syrjälä
2026-02-26 10:52   ` Hogander, Jouni

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.