Re: [PATCH v2 2/4] python: replace avocado tests with pytest

["Daniel P. Berrangé" <berrange@redhat.com>]

On Wed, Feb 25, 2026 at 02:28:06PM -0500, John Snow wrote:
> Following suit with the rest of this repository, drop avocado and
> replace it with the Python standard "pytest" package.
> 
> In this case, we do not truly need pytest as all we are using it for is
> running other python processes formerly launched by shell scripts, but
> this matches how the standalone python-qemu-qmp package does things,
> which keeps things simple on my end.

From the POV of QEMU we don't really want 'pytest' in the loop
any more than we want avocado. The desire is for "meson" to be
the test harness.

If this use of a pytest is just a temporary stepping stone
towards fully integrating with meson, then that's acceptable
but lets note that this is a temporary solution in the commit
message.

> 
> (pytest version chosen based off of Debian 11's package version as queried by
> repology; under the assumption that this is the likely the oldest
> version we currently leverage in testing.)
> 
> Signed-off-by: John Snow <jsnow@redhat.com>
> ---
>  python/Makefile          |  4 +-
>  python/setup.cfg         |  1 +
>  python/tests/linters.py  | 89 ++++++++++++++++++++++++++++++++++++++++
>  python/tests/minreqs.txt |  1 +
>  4 files changed, 93 insertions(+), 2 deletions(-)
>  create mode 100644 python/tests/linters.py
> 
> diff --git a/python/Makefile b/python/Makefile
> index b6c9cd1bce2..42994d39618 100644
> --- a/python/Makefile
> +++ b/python/Makefile
> @@ -105,7 +105,7 @@ develop:
>  
>  .PHONY: check
>  check:
> -	@avocado --config avocado.cfg run tests/
> +	@pytest -v tests/*.py
>  
>  .PHONY: check-tox
>  check-tox:
> @@ -113,7 +113,7 @@ check-tox:
>  
>  .PHONY: check-coverage
>  check-coverage:
> -	@coverage run -m avocado --config avocado.cfg run tests/*.py
> +	@coverage run -m pytest -v tests/*.py
>  	@coverage combine
>  	@coverage html
>  	@coverage report
> diff --git a/python/setup.cfg b/python/setup.cfg
> index c46a95f8d41..03344526730 100644
> --- a/python/setup.cfg
> +++ b/python/setup.cfg
> @@ -43,6 +43,7 @@ devel =
>      mypy >= 1.4.0
>      pylint >= 2.17.3
>      pylint != 3.2.4; python_version<"3.9"
> +    pytest >= 6.0.2
>      tox >= 3.18.0
>      sphinx >= 3.4.3
>  
> diff --git a/python/tests/linters.py b/python/tests/linters.py
> new file mode 100644
> index 00000000000..28556c09910
> --- /dev/null
> +++ b/python/tests/linters.py
> @@ -0,0 +1,89 @@
> +# SPDX-License-Identifier: GPL-2.0-or-later
> +
> +import os
> +import subprocess

from subprocess import check_call

> +import sys
> +
> +
> +def pyrun(*args):
> +    subprocess.run((sys.executable, *args), check=True)

Not sure this is worth the trouble compared to doing...


> +
> +
> +class TestLinters:
> +
> +    def test_flake8_pkg(self):
> +        pyrun("-m", "flake8", "qemu/")

...this inline:

    check_call([sys.executable, "-m", "flake8", "qemu/"])


> +    def test_mypy_iotests(self):
> +        cwd = os.getcwd()
> +        try:
> +            os.chdir("../tests/qemu-iotests/")
> +            pyrun("-m", "linters", "--mypy")
> +        finally:
> +            os.chdir(cwd)

This dance could be replaced with

    check_call([sys.executable, "-m", "linters", "--mpypy"],
               cwd="../tests/qemu-iotests/")



With regards,
Daniel
-- 
|: https://berrange.com       ~~        https://hachyderm.io/@berrange :|
|: https://libvirt.org          ~~          https://entangle-photo.org :|
|: https://pixelfed.art/berrange   ~~    https://fstop138.berrange.com :|