Re: [PATCH v2 2/4] python: replace avocado tests with pytest

["Daniel P. Berrangé" <berrange@redhat.com>]

On Thu, Feb 26, 2026 at 12:51:46PM -0500, John Snow wrote:
> On Thu, Feb 26, 2026 at 9:26 AM Daniel P. Berrangé <berrange@redhat.com> wrote:
> >
> > On Wed, Feb 25, 2026 at 02:28:06PM -0500, John Snow wrote:
> > > Following suit with the rest of this repository, drop avocado and
> > > replace it with the Python standard "pytest" package.
> > >
> > > In this case, we do not truly need pytest as all we are using it for is
> > > running other python processes formerly launched by shell scripts, but
> > > this matches how the standalone python-qemu-qmp package does things,
> > > which keeps things simple on my end.
> >
> > From the POV of QEMU we don't really want 'pytest' in the loop
> > any more than we want avocado. The desire is for "meson" to be
> > the test harness.
> >
> > If this use of a pytest is just a temporary stepping stone
> > towards fully integrating with meson, then that's acceptable
> > but lets note that this is a temporary solution in the commit
> > message.
> 
> Admittedly I wasn't thinking about just using meson directly, so I
> suppose this *is* just a stepping stone. My only question for meson
> integration is how can I set up the deps so that "make check" will try
> to install the linting deps and run the python tests, but skips these
> tests if we are offline and don't have the deps. i.e. "try to run
> these tests, but don't error out if we can't"
> 
> Hazarding a guess: make the python tests depend on a linter group, add
> a custom target for that linter group, allow failure in that custom
> target (how?), then configure the individual meson test cases to skip
> if the deps are not present.
> 
> (Guess I'll go look at your older series and see how you handled this...)

I didn't handle the complexity of venvs in my old series. IIRC I just
blindly used the host python tools, since it was just PoC quality not
a mergable series.

When doing it for real, we'd end up wanting a selection of different
meson suites. Perhaps a default suite using the same python version
as meson itself, for integration in 'make check' and a set of extra
suites, one per python venv target for SPEED=thorough.

If --disable-download was given and the host tools for the linters
were missing we would have to skip the tests in 'make check', but
with SPEED=thorough we could auto-download everything.


With regards,
Daniel
-- 
|: https://berrange.com       ~~        https://hachyderm.io/@berrange :|
|: https://libvirt.org          ~~          https://entangle-photo.org :|
|: https://pixelfed.art/berrange   ~~    https://fstop138.berrange.com :|