[PATCH] ARM: tegra: paz00: configure WiFi rfkill switch through device tree

[PATCH] ARM: tegra: paz00: configure WiFi rfkill switch through device tree

[Dmitry Torokhov]

As of d64c732dfc9e ("net: rfkill: gpio: add DT support") rfkill-gpio
device can be instantiated via device tree.

Add the declaration there and drop board-paz00.c file and relevant
Makefile fragments.

Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
---

This is not tested on real hardware, compile tested only...

 arch/arm/boot/dts/nvidia/tegra20-paz00.dts |  8 ++++
 arch/arm/mach-tegra/Makefile               |  2 -
 arch/arm/mach-tegra/board-paz00.c          | 56 ----------------------
 arch/arm/mach-tegra/board.h                |  2 -
 arch/arm/mach-tegra/tegra.c                |  4 --
 5 files changed, 8 insertions(+), 64 deletions(-)

diff --git a/arch/arm/boot/dts/nvidia/tegra20-paz00.dts b/arch/arm/boot/dts/nvidia/tegra20-paz00.dts
index 1408e1e00759..d1093ad569e6 100644
--- a/arch/arm/boot/dts/nvidia/tegra20-paz00.dts
+++ b/arch/arm/boot/dts/nvidia/tegra20-paz00.dts
@@ -706,6 +706,14 @@ vdd_pnl_reg: regulator-3v0 {
 		enable-active-high;
 	};
 
+	rfkill {
+		compatible = "rfkill-gpio";
+		label = "wifi_rfkill";
+		radio-type = "wlan";
+		reset-gpios = <&gpio TEGRA_GPIO(D, 1) GPIO_ACTIVE_HIGH>;
+		shutdown-gpios = <&gpio TEGRA_GPIO(K, 5) GPIO_ACTIVE_HIGH>;
+	};
+
 	sound {
 		compatible = "nvidia,tegra-audio-alc5632-paz00",
 			"nvidia,tegra-audio-alc5632";
diff --git a/arch/arm/mach-tegra/Makefile b/arch/arm/mach-tegra/Makefile
index a2bb55bc0081..9e3abb14fbc1 100644
--- a/arch/arm/mach-tegra/Makefile
+++ b/arch/arm/mach-tegra/Makefile
@@ -15,5 +15,3 @@ obj-$(CONFIG_HOTPLUG_CPU)               += hotplug.o
 
 obj-$(CONFIG_ARCH_TEGRA_114_SOC)	+= pm-tegra30.o
 obj-$(CONFIG_ARCH_TEGRA_124_SOC)	+= pm-tegra30.o
-
-obj-$(CONFIG_ARCH_TEGRA_2x_SOC)		+= board-paz00.o
diff --git a/arch/arm/mach-tegra/board-paz00.c b/arch/arm/mach-tegra/board-paz00.c
deleted file mode 100644
index 3ec810b6f1a7..000000000000
--- a/arch/arm/mach-tegra/board-paz00.c
+++ /dev/null
@@ -1,56 +0,0 @@
-// SPDX-License-Identifier: GPL-2.0-only
-/*
- * arch/arm/mach-tegra/board-paz00.c
- *
- * Copyright (C) 2011 Marc Dietrich <marvin24@gmx.de>
- *
- * Based on board-harmony.c
- * Copyright (C) 2010 Google, Inc.
- */
-
-#include <linux/err.h>
-#include <linux/gpio/machine.h>
-#include <linux/gpio/property.h>
-#include <linux/platform_device.h>
-#include <linux/printk.h>
-#include <linux/property.h>
-
-#include "board.h"
-
-static const struct software_node tegra_gpiochip_node = {
-	.name	= "tegra-gpio",
-};
-
-static const struct property_entry wifi_rfkill_prop[] __initconst = {
-	PROPERTY_ENTRY_STRING("name", "wifi_rfkill"),
-	PROPERTY_ENTRY_STRING("type", "wlan"),
-	PROPERTY_ENTRY_GPIO("reset-gpios",
-			    &tegra_gpiochip_node, 25, GPIO_ACTIVE_HIGH),
-	PROPERTY_ENTRY_GPIO("shutdown-gpios",
-			    &tegra_gpiochip_node, 85, GPIO_ACTIVE_HIGH),
-	{ }
-};
-
-static const struct platform_device_info wifi_rfkill_info __initconst = {
-	.name		= "rfkill_gpio",
-	.id		= PLATFORM_DEVID_NONE,
-	.properties	= wifi_rfkill_prop,
-};
-
-void __init tegra_paz00_wifikill_init(void)
-{
-	struct platform_device *pd;
-	int err;
-
-	err = software_node_register(&tegra_gpiochip_node);
-	if (err) {
-		pr_err("failed to register %s node: %d\n",
-		       tegra_gpiochip_node.name, err);
-		return;
-	}
-
-	pd = platform_device_register_full(&wifi_rfkill_info);
-	err = PTR_ERR_OR_ZERO(pd);
-	if (err)
-		pr_err("failed to register WiFi rfkill device: %d\n", err);
-}
diff --git a/arch/arm/mach-tegra/board.h b/arch/arm/mach-tegra/board.h
index 7b3ef0dc9be1..86c3ea0d6b30 100644
--- a/arch/arm/mach-tegra/board.h
+++ b/arch/arm/mach-tegra/board.h
@@ -19,6 +19,4 @@
 void __init tegra_map_common_io(void);
 void __init tegra_init_irq(void);
 
-void __init tegra_paz00_wifikill_init(void);
-
 #endif
diff --git a/arch/arm/mach-tegra/tegra.c b/arch/arm/mach-tegra/tegra.c
index 9ef1dfa7b926..f324a7e491d8 100644
--- a/arch/arm/mach-tegra/tegra.c
+++ b/arch/arm/mach-tegra/tegra.c
@@ -83,10 +83,6 @@ static void __init tegra_dt_init(void)
 
 static void __init tegra_dt_init_late(void)
 {
-	if (IS_ENABLED(CONFIG_ARCH_TEGRA_2x_SOC) &&
-	    of_machine_is_compatible("compal,paz00"))
-		tegra_paz00_wifikill_init();
-
 	if (IS_ENABLED(CONFIG_ARCH_TEGRA_2x_SOC) &&
 	    of_machine_is_compatible("nvidia,tegra20"))
 		platform_device_register_simple("tegra20-cpufreq", -1, NULL, 0);
-- 
2.53.0.310.g728cabbaf7-goog


-- 
Dmitry

Re: [PATCH] ARM: tegra: paz00: configure WiFi rfkill switch through device tree

[Marc Dietrich]

Hi Dmitry,

On Fri, 13 Feb 2026, Dmitry Torokhov wrote:

> As of d64c732dfc9e ("net: rfkill: gpio: add DT support") rfkill-gpio
> device can be instantiated via device tree.
>
> Add the declaration there and drop board-paz00.c file and relevant
> Makefile fragments.
>
> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
> ---
>
> This is not tested on real hardware, compile tested only...
>
> arch/arm/boot/dts/nvidia/tegra20-paz00.dts |  8 ++++
> arch/arm/mach-tegra/Makefile               |  2 -
> arch/arm/mach-tegra/board-paz00.c          | 56 ----------------------
> arch/arm/mach-tegra/board.h                |  2 -
> arch/arm/mach-tegra/tegra.c                |  4 --
> 5 files changed, 8 insertions(+), 64 deletions(-)
>
> diff --git a/arch/arm/boot/dts/nvidia/tegra20-paz00.dts b/arch/arm/boot/dts/nvidia/tegra20-paz00.dts
> index 1408e1e00759..d1093ad569e6 100644
> --- a/arch/arm/boot/dts/nvidia/tegra20-paz00.dts
> +++ b/arch/arm/boot/dts/nvidia/tegra20-paz00.dts
> @@ -706,6 +706,14 @@ vdd_pnl_reg: regulator-3v0 {
> 		enable-active-high;
> 	};
>
> +	rfkill {
> +		compatible = "rfkill-gpio";
> +		label = "wifi_rfkill";
> +		radio-type = "wlan";
> +		reset-gpios = <&gpio TEGRA_GPIO(D, 1) GPIO_ACTIVE_HIGH>;

I guess this can be removed, as it should trigger the LED, which is 
already included elsewhere ....

> +		shutdown-gpios = <&gpio TEGRA_GPIO(K, 5) GPIO_ACTIVE_HIGH>;
> +	};
> +
> 	sound {
> 		compatible = "nvidia,tegra-audio-alc5632-paz00",
> 			"nvidia,tegra-audio-alc5632";

I'll give it a try and report back.

Thanks for the nice cleanup!

Marc


> diff --git a/arch/arm/mach-tegra/Makefile b/arch/arm/mach-tegra/Makefile
> index a2bb55bc0081..9e3abb14fbc1 100644
> --- a/arch/arm/mach-tegra/Makefile
> +++ b/arch/arm/mach-tegra/Makefile
> @@ -15,5 +15,3 @@ obj-$(CONFIG_HOTPLUG_CPU)               += hotplug.o
>
> obj-$(CONFIG_ARCH_TEGRA_114_SOC)	+= pm-tegra30.o
> obj-$(CONFIG_ARCH_TEGRA_124_SOC)	+= pm-tegra30.o
> -
> -obj-$(CONFIG_ARCH_TEGRA_2x_SOC)		+= board-paz00.o
> diff --git a/arch/arm/mach-tegra/board-paz00.c b/arch/arm/mach-tegra/board-paz00.c
> deleted file mode 100644
> index 3ec810b6f1a7..000000000000
> --- a/arch/arm/mach-tegra/board-paz00.c
> +++ /dev/null
> @@ -1,56 +0,0 @@
> -// SPDX-License-Identifier: GPL-2.0-only
> -/*
> - * arch/arm/mach-tegra/board-paz00.c
> - *
> - * Copyright (C) 2011 Marc Dietrich <marvin24@gmx.de>
> - *
> - * Based on board-harmony.c
> - * Copyright (C) 2010 Google, Inc.
> - */
> -
> -#include <linux/err.h>
> -#include <linux/gpio/machine.h>
> -#include <linux/gpio/property.h>
> -#include <linux/platform_device.h>
> -#include <linux/printk.h>
> -#include <linux/property.h>
> -
> -#include "board.h"
> -
> -static const struct software_node tegra_gpiochip_node = {
> -	.name	= "tegra-gpio",
> -};
> -
> -static const struct property_entry wifi_rfkill_prop[] __initconst = {
> -	PROPERTY_ENTRY_STRING("name", "wifi_rfkill"),
> -	PROPERTY_ENTRY_STRING("type", "wlan"),
> -	PROPERTY_ENTRY_GPIO("reset-gpios",
> -			    &tegra_gpiochip_node, 25, GPIO_ACTIVE_HIGH),
> -	PROPERTY_ENTRY_GPIO("shutdown-gpios",
> -			    &tegra_gpiochip_node, 85, GPIO_ACTIVE_HIGH),
> -	{ }
> -};
> -
> -static const struct platform_device_info wifi_rfkill_info __initconst = {
> -	.name		= "rfkill_gpio",
> -	.id		= PLATFORM_DEVID_NONE,
> -	.properties	= wifi_rfkill_prop,
> -};
> -
> -void __init tegra_paz00_wifikill_init(void)
> -{
> -	struct platform_device *pd;
> -	int err;
> -
> -	err = software_node_register(&tegra_gpiochip_node);
> -	if (err) {
> -		pr_err("failed to register %s node: %d\n",
> -		       tegra_gpiochip_node.name, err);
> -		return;
> -	}
> -
> -	pd = platform_device_register_full(&wifi_rfkill_info);
> -	err = PTR_ERR_OR_ZERO(pd);
> -	if (err)
> -		pr_err("failed to register WiFi rfkill device: %d\n", err);
> -}
> diff --git a/arch/arm/mach-tegra/board.h b/arch/arm/mach-tegra/board.h
> index 7b3ef0dc9be1..86c3ea0d6b30 100644
> --- a/arch/arm/mach-tegra/board.h
> +++ b/arch/arm/mach-tegra/board.h
> @@ -19,6 +19,4 @@
> void __init tegra_map_common_io(void);
> void __init tegra_init_irq(void);
>
> -void __init tegra_paz00_wifikill_init(void);
> -
> #endif
> diff --git a/arch/arm/mach-tegra/tegra.c b/arch/arm/mach-tegra/tegra.c
> index 9ef1dfa7b926..f324a7e491d8 100644
> --- a/arch/arm/mach-tegra/tegra.c
> +++ b/arch/arm/mach-tegra/tegra.c
> @@ -83,10 +83,6 @@ static void __init tegra_dt_init(void)
>
> static void __init tegra_dt_init_late(void)
> {
> -	if (IS_ENABLED(CONFIG_ARCH_TEGRA_2x_SOC) &&
> -	    of_machine_is_compatible("compal,paz00"))
> -		tegra_paz00_wifikill_init();
> -
> 	if (IS_ENABLED(CONFIG_ARCH_TEGRA_2x_SOC) &&
> 	    of_machine_is_compatible("nvidia,tegra20"))
> 		platform_device_register_simple("tegra20-cpufreq", -1, NULL, 0);
> -- 
> 2.53.0.310.g728cabbaf7-goog
>
>
> -- 
> Dmitry
>
>

Re: [PATCH] ARM: tegra: paz00: configure WiFi rfkill switch through device tree

[Marc Dietrich]

Hi Dmitry,

On Sat, 14 Feb 2026, Marc Dietrich wrote:

> Hi Dmitry,
>
> On Fri, 13 Feb 2026, Dmitry Torokhov wrote:
>
>> As of d64c732dfc9e ("net: rfkill: gpio: add DT support") rfkill-gpio
>> device can be instantiated via device tree.
>> 
>> Add the declaration there and drop board-paz00.c file and relevant
>> Makefile fragments.
>> 
>> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
>> ---
>> 
>> This is not tested on real hardware, compile tested only...
>> 
>> arch/arm/boot/dts/nvidia/tegra20-paz00.dts |  8 ++++
>> arch/arm/mach-tegra/Makefile               |  2 -
>> arch/arm/mach-tegra/board-paz00.c          | 56 ----------------------
>> arch/arm/mach-tegra/board.h                |  2 -
>> arch/arm/mach-tegra/tegra.c                |  4 --
>> 5 files changed, 8 insertions(+), 64 deletions(-)
>> 
>> diff --git a/arch/arm/boot/dts/nvidia/tegra20-paz00.dts 
>> b/arch/arm/boot/dts/nvidia/tegra20-paz00.dts
>> index 1408e1e00759..d1093ad569e6 100644
>> --- a/arch/arm/boot/dts/nvidia/tegra20-paz00.dts
>> +++ b/arch/arm/boot/dts/nvidia/tegra20-paz00.dts
>> @@ -706,6 +706,14 @@ vdd_pnl_reg: regulator-3v0 {
>> 		enable-active-high;
>> 	};
>> 
>> +	rfkill {
>> +		compatible = "rfkill-gpio";
>> +		label = "wifi_rfkill";
>> +		radio-type = "wlan";
>> +		reset-gpios = <&gpio TEGRA_GPIO(D, 1) GPIO_ACTIVE_HIGH>;
>
> I guess this can be removed, as it should trigger the LED, which is already 
> included elsewhere ....
>
>> +		shutdown-gpios = <&gpio TEGRA_GPIO(K, 5) GPIO_ACTIVE_HIGH>;
>> +	};
>> +
>> 	sound {
>> 		compatible = "nvidia,tegra-audio-alc5632-paz00",
>> 			"nvidia,tegra-audio-alc5632";
>
> I'll give it a try and report back.

rfkill (and LED) works as expected. With the reset-gpio line mentioned 
above removed, you can add my Tested-By.

Thanks!

Marc

Re: [PATCH] ARM: tegra: paz00: configure WiFi rfkill switch through device tree

[Dmitry Torokhov]

Hi Marc,

On Sat, Feb 21, 2026 at 03:24:35PM +0100, Marc Dietrich wrote:
> Hi Dmitry,
> 
> On Sat, 14 Feb 2026, Marc Dietrich wrote:
> 
> > Hi Dmitry,
> > 
> > On Fri, 13 Feb 2026, Dmitry Torokhov wrote:
> > 
> > > As of d64c732dfc9e ("net: rfkill: gpio: add DT support") rfkill-gpio
> > > device can be instantiated via device tree.
> > > 
> > > Add the declaration there and drop board-paz00.c file and relevant
> > > Makefile fragments.
> > > 
> > > Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
> > > ---
> > > 
> > > This is not tested on real hardware, compile tested only...
> > > 
> > > arch/arm/boot/dts/nvidia/tegra20-paz00.dts |  8 ++++
> > > arch/arm/mach-tegra/Makefile               |  2 -
> > > arch/arm/mach-tegra/board-paz00.c          | 56 ----------------------
> > > arch/arm/mach-tegra/board.h                |  2 -
> > > arch/arm/mach-tegra/tegra.c                |  4 --
> > > 5 files changed, 8 insertions(+), 64 deletions(-)
> > > 
> > > diff --git a/arch/arm/boot/dts/nvidia/tegra20-paz00.dts
> > > b/arch/arm/boot/dts/nvidia/tegra20-paz00.dts
> > > index 1408e1e00759..d1093ad569e6 100644
> > > --- a/arch/arm/boot/dts/nvidia/tegra20-paz00.dts
> > > +++ b/arch/arm/boot/dts/nvidia/tegra20-paz00.dts
> > > @@ -706,6 +706,14 @@ vdd_pnl_reg: regulator-3v0 {
> > > 		enable-active-high;
> > > 	};
> > > 
> > > +	rfkill {
> > > +		compatible = "rfkill-gpio";
> > > +		label = "wifi_rfkill";
> > > +		radio-type = "wlan";
> > > +		reset-gpios = <&gpio TEGRA_GPIO(D, 1) GPIO_ACTIVE_HIGH>;
> > 
> > I guess this can be removed, as it should trigger the LED, which is
> > already included elsewhere ....
> > 
> > > +		shutdown-gpios = <&gpio TEGRA_GPIO(K, 5) GPIO_ACTIVE_HIGH>;
> > > +	};
> > > +
> > > 	sound {
> > > 		compatible = "nvidia,tegra-audio-alc5632-paz00",
> > > 			"nvidia,tegra-audio-alc5632";
> > 
> > I'll give it a try and report back.
> 
> rfkill (and LED) works as expected. With the reset-gpio line mentioned above
> removed, you can add my Tested-By.

Thank you Marc.

I am still a bit confused about the reset gpio. As far as I understand
looking through old commits reset gpio (PD1) is distinct from the LED
gpio (PD0) that is currently being controlled by "gpio-leds".

I guess the rfkill driver needs at least one of "reset" or "shutdown"
gpios, and that is why it continues to work with only shutdown, but I am
trying to understand if PD1 was never connected to the WiFi chip reset
line and instead is used for something else, or if it is indeed a reset
line...

Was the patch not working with reset-gpios present? I am trying to
gather data to craft a proper commit message.

Thanks.

-- 
Dmitry

Re: [PATCH] ARM: tegra: paz00: configure WiFi rfkill switch through device tree

[Marc Dietrich]

Hi Dmitry,

On Sun, 22 Feb 2026, Dmitry Torokhov wrote:

> Hi Marc,
>
> On Sat, Feb 21, 2026 at 03:24:35PM +0100, Marc Dietrich wrote:
>> Hi Dmitry,
>>
>> On Sat, 14 Feb 2026, Marc Dietrich wrote:
>>
>>> Hi Dmitry,
>>>
>>> On Fri, 13 Feb 2026, Dmitry Torokhov wrote:
>>>
>>>> As of d64c732dfc9e ("net: rfkill: gpio: add DT support") rfkill-gpio
>>>> device can be instantiated via device tree.
>>>>
>>>> Add the declaration there and drop board-paz00.c file and relevant
>>>> Makefile fragments.
>>>>
>>>> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
>>>> ---
>>>>
>>>> This is not tested on real hardware, compile tested only...
>>>>
>>>> arch/arm/boot/dts/nvidia/tegra20-paz00.dts |  8 ++++
>>>> arch/arm/mach-tegra/Makefile               |  2 -
>>>> arch/arm/mach-tegra/board-paz00.c          | 56 ----------------------
>>>> arch/arm/mach-tegra/board.h                |  2 -
>>>> arch/arm/mach-tegra/tegra.c                |  4 --
>>>> 5 files changed, 8 insertions(+), 64 deletions(-)
>>>>
>>>> diff --git a/arch/arm/boot/dts/nvidia/tegra20-paz00.dts
>>>> b/arch/arm/boot/dts/nvidia/tegra20-paz00.dts
>>>> index 1408e1e00759..d1093ad569e6 100644
>>>> --- a/arch/arm/boot/dts/nvidia/tegra20-paz00.dts
>>>> +++ b/arch/arm/boot/dts/nvidia/tegra20-paz00.dts
>>>> @@ -706,6 +706,14 @@ vdd_pnl_reg: regulator-3v0 {
>>>> 		enable-active-high;
>>>> 	};
>>>>
>>>> +	rfkill {
>>>> +		compatible = "rfkill-gpio";
>>>> +		label = "wifi_rfkill";
>>>> +		radio-type = "wlan";
>>>> +		reset-gpios = <&gpio TEGRA_GPIO(D, 1) GPIO_ACTIVE_HIGH>;
>>>
>>> I guess this can be removed, as it should trigger the LED, which is
>>> already included elsewhere ....
>>>
>>>> +		shutdown-gpios = <&gpio TEGRA_GPIO(K, 5) GPIO_ACTIVE_HIGH>;
>>>> +	};
>>>> +
>>>> 	sound {
>>>> 		compatible = "nvidia,tegra-audio-alc5632-paz00",
>>>> 			"nvidia,tegra-audio-alc5632";
>>>
>>> I'll give it a try and report back.
>>
>> rfkill (and LED) works as expected. With the reset-gpio line mentioned above
>> removed, you can add my Tested-By.
>
> Thank you Marc.
>
> I am still a bit confused about the reset gpio. As far as I understand
> looking through old commits reset gpio (PD1) is distinct from the LED
> gpio (PD0) that is currently being controlled by "gpio-leds".

well, the situation is a bit complicated. First, D1 gpio is eletrical ORed 
with the Wifi LED gpio (D0), which you can confirm by checking the schematic 
(google is your friend).
The said schematic contains two nearly identical devices (Toshiba 
Netbook AC100, aka Procyon and Toshiba tablet Folio 100, aka Sirius). 
GPIO D1 is also used on the tablet to rfkill the wifi/bt module on an M2 
card, while the Notebook has wifi on a separate usb port (JP2) (and G3 
modem on an M2 card), where D1 is not connected to at all. At least that's 
how I understand it.

> I guess the rfkill driver needs at least one of "reset" or "shutdown"
> gpios, and that is why it continues to work with only shutdown, but I am
> trying to understand if PD1 was never connected to the WiFi chip reset
> line and instead is used for something else, or if it is indeed a reset
> line...

see above.

> Was the patch not working with reset-gpios present? I am trying to
> gather data to craft a proper commit message.

It also works with the reset-gpio, but just because it is not connected to 
anything beside the LED on this machine.

Maybe I should also add that there are also variants of the Netbook with 
integrated bluetooth (and without 3G), but I don't know where it is 
connected to (maybe also to the M2 socket). In order to support such 
machines, we could use a second rfkill device for bluetooth only I 
guess. The original code used a single rfkill device in order to control 
both gpios together for a common rfkill I guess. I just don't have such a 
variant, so I cannot test it.

Best wishes,

Marc

Re: [PATCH] ARM: tegra: paz00: configure WiFi rfkill switch through device tree

[Marc Dietrich]

Hi Dmitry,


On Sat, 28 Feb 2026, Marc Dietrich wrote:
> On Sun, 22 Feb 2026, Dmitry Torokhov wrote:
>> On Sat, Feb 21, 2026 at 03:24:35PM +0100, Marc Dietrich wrote:
>>> On Sat, 14 Feb 2026, Marc Dietrich wrote:
>>>> On Fri, 13 Feb 2026, Dmitry Torokhov wrote:
>>>> 
>>>>> As of d64c732dfc9e ("net: rfkill: gpio: add DT support") rfkill-gpio
>>>>> device can be instantiated via device tree.
>>>>> 
>>>>> Add the declaration there and drop board-paz00.c file and relevant
>>>>> Makefile fragments.
>>>>> 
>>>>> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
>>>>> ---
>>>>> 
>>>>> This is not tested on real hardware, compile tested only...
>>>>> 
>>>>> arch/arm/boot/dts/nvidia/tegra20-paz00.dts |  8 ++++
>>>>> arch/arm/mach-tegra/Makefile               |  2 -
>>>>> arch/arm/mach-tegra/board-paz00.c          | 56 ----------------------
>>>>> arch/arm/mach-tegra/board.h                |  2 -
>>>>> arch/arm/mach-tegra/tegra.c                |  4 --
>>>>> 5 files changed, 8 insertions(+), 64 deletions(-)
>>>>> 
>>>>> diff --git a/arch/arm/boot/dts/nvidia/tegra20-paz00.dts
>>>>> b/arch/arm/boot/dts/nvidia/tegra20-paz00.dts
>>>>> index 1408e1e00759..d1093ad569e6 100644
>>>>> --- a/arch/arm/boot/dts/nvidia/tegra20-paz00.dts
>>>>> +++ b/arch/arm/boot/dts/nvidia/tegra20-paz00.dts
>>>>> @@ -706,6 +706,14 @@ vdd_pnl_reg: regulator-3v0 {
>>>>> 		enable-active-high;
>>>>> 	};
>>>>> 
>>>>> +	rfkill {
>>>>> +		compatible = "rfkill-gpio";
>>>>> +		label = "wifi_rfkill";
>>>>> +		radio-type = "wlan";
>>>>> +		reset-gpios = <&gpio TEGRA_GPIO(D, 1) GPIO_ACTIVE_HIGH>;
>>>> 
>>>> I guess this can be removed, as it should trigger the LED, which is
>>>> already included elsewhere ....
>>>> 
>>>>> +		shutdown-gpios = <&gpio TEGRA_GPIO(K, 5) GPIO_ACTIVE_HIGH>;
>>>>> +	};
>>>>> +
>>>>> 	sound {
>>>>> 		compatible = "nvidia,tegra-audio-alc5632-paz00",
>>>>> 			"nvidia,tegra-audio-alc5632";
>>>> 
>>>> I'll give it a try and report back.
>>> 
>>> rfkill (and LED) works as expected. With the reset-gpio line mentioned 
>>> above
>>> removed, you can add my Tested-By.
>> 
>> Thank you Marc.
>> 
>> I am still a bit confused about the reset gpio. As far as I understand
>> looking through old commits reset gpio (PD1) is distinct from the LED
>> gpio (PD0) that is currently being controlled by "gpio-leds".
>
> well, the situation is a bit complicated. First, D1 gpio is eletrical ORed 
> with the Wifi LED gpio (D0), which you can confirm by checking the schematic 
> (google is your friend).
> The said schematic contains two nearly identical devices (Toshiba Netbook 
> AC100, aka Procyon and Toshiba tablet Folio 100, aka Sirius). GPIO D1 is also 
> used on the tablet to rfkill the wifi/bt module on an M2 card, while the 
> Notebook has wifi on a separate usb port (JP2) (and G3 modem on an M2 card), 
> where D1 is not connected to at all. At least that's how I understand it.
>
>> I guess the rfkill driver needs at least one of "reset" or "shutdown"
>> gpios, and that is why it continues to work with only shutdown, but I am
>> trying to understand if PD1 was never connected to the WiFi chip reset
>> line and instead is used for something else, or if it is indeed a reset
>> line...
>
> see above.
>
>> Was the patch not working with reset-gpios present? I am trying to
>> gather data to craft a proper commit message.
>
> It also works with the reset-gpio, but just because it is not connected to 
> anything beside the LED on this machine.
>
> Maybe I should also add that there are also variants of the Netbook with 
> integrated bluetooth (and without 3G), but I don't know where it is connected 
> to (maybe also to the M2 socket). In order to support such machines, we could 
> use a second rfkill device for bluetooth only I guess. The original code used 
> a single rfkill device in order to control both gpios together for a common 
> rfkill I guess. I just don't have such a variant, so I cannot test it.

thinking about all this a bit more, I guess your approach to just convert 
the driver to device-tree and not change any functionally beside it, is 
the best solution for now (and good pratice in general).
Maybe I can get access to a machine with bluetooth (or some other user 
steps up), so we can try to find a better solution, if required at all.

Thanks!
Marc

Re: [PATCH] ARM: tegra: paz00: configure WiFi rfkill switch through device tree

[Dmitry Torokhov]

Hi Marc,

On Sun, Mar 01, 2026 at 09:55:45PM +0100, Marc Dietrich wrote:
> 
> thinking about all this a bit more, I guess your approach to just convert
> the driver to device-tree and not change any functionally beside it, is the
> best solution for now (and good pratice in general).
> Maybe I can get access to a machine with bluetooth (or some other user steps
> up), so we can try to find a better solution, if required at all.

Thank you. I believe your tested-by is applicable to the current version
of the patch as well, so maybe Thierry can simply pick it up.

Thanks.

-- 
Dmitry

Re: [PATCH] ARM: tegra: paz00: configure WiFi rfkill switch through device tree

[Marc Dietrich]

On Sun, 1 Mar 2026, Dmitry Torokhov wrote:

> Hi Marc,
>
> On Sun, Mar 01, 2026 at 09:55:45PM +0100, Marc Dietrich wrote:
>>
>> thinking about all this a bit more, I guess your approach to just convert
>> the driver to device-tree and not change any functionally beside it, is the
>> best solution for now (and good pratice in general).
>> Maybe I can get access to a machine with bluetooth (or some other user steps
>> up), so we can try to find a better solution, if required at all.
>
> Thank you. I believe your tested-by is applicable to the current version
> of the patch as well, so maybe Thierry can simply pick it up.

yes sure, thanks!

Marc

Re: [PATCH] ARM: tegra: paz00: configure WiFi rfkill switch through device tree

[kernel test robot]

:::::: 
:::::: Manual check reason: "dtcheck: binding changes may go via different trees"
:::::: 

BCC: lkp@intel.com
CC: oe-kbuild-all@lists.linux.dev
In-Reply-To: <aY_BpRQmLdqOOW2K@google.com>
References: <aY_BpRQmLdqOOW2K@google.com>
TO: Dmitry Torokhov <dmitry.torokhov@gmail.com>
TO: Thierry Reding <thierry.reding@gmail.com>
CC: Arnd Bergmann <arnd@kernel.org>
CC: Rob Herring <robh@kernel.org>
CC: Krzysztof Kozlowski <krzk@kernel.org>
CC: Conor Dooley <conor+dt@kernel.org>
CC: Jonathan Hunter <jonathanh@nvidia.com>
CC: devicetree@vger.kernel.org
CC: linux-tegra@vger.kernel.org
CC: linux-kernel@vger.kernel.org
CC: linux-arm-kernel@lists.infradead.org

Hi Dmitry,

kernel test robot noticed the following build warnings:

[auto build test WARNING on tegra/for-next]
[also build test WARNING on robh/for-next soc/for-next linus/master v6.19 next-20260213]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Dmitry-Torokhov/ARM-tegra-paz00-configure-WiFi-rfkill-switch-through-device-tree/20260214-083759
base:   https://git.kernel.org/pub/scm/linux/kernel/git/tegra/linux.git for-next
patch link:    https://lore.kernel.org/r/aY_BpRQmLdqOOW2K%40google.com
patch subject: [PATCH] ARM: tegra: paz00: configure WiFi rfkill switch through device tree
:::::: branch date: 2 days ago
:::::: commit date: 2 days ago
config: arm-randconfig-2051-20260214 (https://download.01.org/0day-ci/archive/20260215/202602152058.ORIhgZzV-lkp@intel.com/config)
compiler: arm-linux-gnueabi-gcc (GCC) 11.5.0
dtschema: 2025.13.dev7+gd16dc68b0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20260215/202602152058.ORIhgZzV-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/r/202602152058.ORIhgZzV-lkp@intel.com/

dtcheck warnings: (new ones prefixed by >>)
   arch/arm/boot/dts/nvidia/tegra20-paz00.dtb: /i2c@7000d000/tps6586x@34: failed to match any schema with compatible: ['ti,tps6586x']
   arch/arm/boot/dts/nvidia/tegra20-paz00.dtb: /kbc@7000e200: failed to match any schema with compatible: ['nvidia,tegra20-kbc']
   arch/arm/boot/dts/nvidia/tegra20-paz00.dtb: /pcie@80003000: failed to match any schema with compatible: ['nvidia,tegra20-pcie']
   arch/arm/boot/dts/nvidia/tegra20-paz00.dtb: gpio-leds (gpio-leds): led-0:linux,default-trigger: 'oneOf' conditional failed, one must be fixed:
   	'rfkill0' is not one of ['backlight', 'default-on', 'heartbeat', 'disk-activity', 'disk-read', 'disk-write', 'timer', 'pattern', 'audio-micmute', 'audio-mute', 'bluetooth-power', 'flash', 'kbd-capslock', 'mtd', 'nand-disk', 'netdev', 'none', 'rc-feedback', 'torch', 'usb-gadget', 'usb-host', 'usbport']
   	'rfkill0' does not match '^cpu[0-9]*$'
   	'rfkill0' does not match '^hci[0-9]+-power$'
   	'rfkill0' does not match '^mmc[0-9]+$'
   	'rfkill0' does not match '^phy[0-9]+tx$'
   	from schema $id: http://devicetree.org/schemas/leds/leds-gpio.yaml
>> arch/arm/boot/dts/nvidia/tegra20-paz00.dtb: rfkill (rfkill-gpio): 'reset-gpios' does not match any of the regexes: '^pinctrl-[0-9]+$'
   	from schema $id: http://devicetree.org/schemas/net/rfkill-gpio.yaml

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki