From: Chao Yu via Linux-erofs <linux-erofs@lists.ozlabs.org>
To: Gao Xiang <hsiangkao@linux.alibaba.com>,
Yiyang Wu <toolmanp@tlmp.cc>,
linux-erofs@lists.ozlabs.org, linux-kernel@vger.kernel.org,
Al Viro <viro@zeniv.linux.org.uk>
Subject: Re: [PATCH V4 1/2] erofs: use kmemdup_nul in erofs_fill_symlink
Date: Mon, 9 Sep 2024 11:37:52 +0800 [thread overview]
Message-ID: <aacfdf82-6b8f-44ef-9efd-e5356147d91b@kernel.org> (raw)
In-Reply-To: <ZtV/speqypBt99sE@debian>
On 2024/9/2 17:04, Gao Xiang via Linux-erofs wrote:
> On Mon, Sep 02, 2024 at 04:52:30PM +0800, Gao Xiang wrote:
>>
>>
>> On 2024/9/2 16:31, Yiyang Wu wrote:
>>> Remove open coding in erofs_fill_symlink.
>>>
>>> Suggested-by: Al Viro <viro@zeniv.linux.org.uk>
>>> Link: https://lore.kernel.org/all/20240425222847.GN2118490@ZenIV
>>> Signed-off-by: Yiyang Wu <toolmanp@tlmp.cc>
>>
>> If a patch is unchanged, you have two ways to handle:
>> - resend the patch with new received "Reviewed-by";
>> - just send the updated [PATCH 2/2] with new version
>> and `--in-reply-to=<old message id>`.
>>
>> I will apply this patch first.
>
> I applied this patch as
>
> From b3c5375ceb2944a7e4d34a6fb106ecd4614260d7 Mon Sep 17 00:00:00 2001
> From: Yiyang Wu <toolmanp@tlmp.cc>
> Date: Mon, 2 Sep 2024 16:31:46 +0800
> Subject: erofs: use kmemdup_nul in erofs_fill_symlink
>
> Remove open coding in erofs_fill_symlink.
>
> Suggested-by: Al Viro <viro@zeniv.linux.org.uk>
> Link: https://lore.kernel.org/all/20240425222847.GN2118490@ZenIV
> Signed-off-by: Yiyang Wu <toolmanp@tlmp.cc>
> Link: https://lore.kernel.org/r/20240902083147.450558-2-toolmanp@tlmp.cc
> Reviewed-by: Gao Xiang <hsiangkao@linux.alibaba.com>
> Signed-off-by: Gao Xiang <hsiangkao@linux.alibaba.com>
Reviewed-by: Chao Yu <chao@kernel.org>
Thanks,
WARNING: multiple messages have this Message-ID (diff)
From: Chao Yu <chao@kernel.org>
To: Gao Xiang <hsiangkao@linux.alibaba.com>,
Yiyang Wu <toolmanp@tlmp.cc>,
linux-erofs@lists.ozlabs.org, linux-kernel@vger.kernel.org,
Al Viro <viro@zeniv.linux.org.uk>
Cc: chao@kernel.org
Subject: Re: [PATCH V4 1/2] erofs: use kmemdup_nul in erofs_fill_symlink
Date: Mon, 9 Sep 2024 11:37:52 +0800 [thread overview]
Message-ID: <aacfdf82-6b8f-44ef-9efd-e5356147d91b@kernel.org> (raw)
In-Reply-To: <ZtV/speqypBt99sE@debian>
On 2024/9/2 17:04, Gao Xiang via Linux-erofs wrote:
> On Mon, Sep 02, 2024 at 04:52:30PM +0800, Gao Xiang wrote:
>>
>>
>> On 2024/9/2 16:31, Yiyang Wu wrote:
>>> Remove open coding in erofs_fill_symlink.
>>>
>>> Suggested-by: Al Viro <viro@zeniv.linux.org.uk>
>>> Link: https://lore.kernel.org/all/20240425222847.GN2118490@ZenIV
>>> Signed-off-by: Yiyang Wu <toolmanp@tlmp.cc>
>>
>> If a patch is unchanged, you have two ways to handle:
>> - resend the patch with new received "Reviewed-by";
>> - just send the updated [PATCH 2/2] with new version
>> and `--in-reply-to=<old message id>`.
>>
>> I will apply this patch first.
>
> I applied this patch as
>
> From b3c5375ceb2944a7e4d34a6fb106ecd4614260d7 Mon Sep 17 00:00:00 2001
> From: Yiyang Wu <toolmanp@tlmp.cc>
> Date: Mon, 2 Sep 2024 16:31:46 +0800
> Subject: erofs: use kmemdup_nul in erofs_fill_symlink
>
> Remove open coding in erofs_fill_symlink.
>
> Suggested-by: Al Viro <viro@zeniv.linux.org.uk>
> Link: https://lore.kernel.org/all/20240425222847.GN2118490@ZenIV
> Signed-off-by: Yiyang Wu <toolmanp@tlmp.cc>
> Link: https://lore.kernel.org/r/20240902083147.450558-2-toolmanp@tlmp.cc
> Reviewed-by: Gao Xiang <hsiangkao@linux.alibaba.com>
> Signed-off-by: Gao Xiang <hsiangkao@linux.alibaba.com>
Reviewed-by: Chao Yu <chao@kernel.org>
Thanks,
next prev parent reply other threads:[~2024-09-09 3:38 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-02 8:31 [PATCH V4 0/2] erofs: refactor fast_symlink and read_inode Yiyang Wu via Linux-erofs
2024-09-02 8:31 ` Yiyang Wu
2024-09-02 8:31 ` [PATCH V4 1/2] erofs: use kmemdup_nul in erofs_fill_symlink Yiyang Wu via Linux-erofs
2024-09-02 8:31 ` Yiyang Wu
2024-09-02 8:52 ` Gao Xiang
2024-09-02 9:04 ` Gao Xiang via Linux-erofs
2024-09-02 9:04 ` Gao Xiang
2024-09-09 3:37 ` Chao Yu via Linux-erofs [this message]
2024-09-09 3:37 ` Chao Yu
2024-09-02 8:31 ` [PATCH V4 2/2] erofs: refactor read_inode calling convention Yiyang Wu via Linux-erofs
2024-09-02 8:31 ` Yiyang Wu
2024-09-02 8:53 ` Gao Xiang
2024-09-02 9:34 ` Yiyang Wu via Linux-erofs
2024-09-02 9:34 ` Yiyang Wu
2024-09-02 9:54 ` Gao Xiang
2024-09-03 2:37 ` Gao Xiang via Linux-erofs
2024-09-03 2:37 ` Gao Xiang
2024-09-09 3:41 ` Chao Yu via Linux-erofs
2024-09-09 3:41 ` Chao Yu
2024-09-02 9:36 ` Yiyang Wu via Linux-erofs
2024-09-02 9:36 ` Yiyang Wu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aacfdf82-6b8f-44ef-9efd-e5356147d91b@kernel.org \
--to=linux-erofs@lists.ozlabs.org \
--cc=chao@kernel.org \
--cc=hsiangkao@linux.alibaba.com \
--cc=linux-kernel@vger.kernel.org \
--cc=toolmanp@tlmp.cc \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.