From: Christoph Hellwig <hch@infradead.org>
To: Brian Foster <bfoster@redhat.com>
Cc: Christoph Hellwig <hch@infradead.org>,
linux-fsdevel@vger.kernel.org, linux-xfs@vger.kernel.org
Subject: Re: [PATCH v2 1/5] iomap, xfs: lift zero range hole mapping flush into xfs
Date: Wed, 4 Mar 2026 06:41:23 -0800 [thread overview]
Message-ID: <aahEk4yNqd15BIt7@infradead.org> (raw)
In-Reply-To: <aag-_c8G_L5MQ42m@bfoster>
On Wed, Mar 04, 2026 at 09:17:33AM -0500, Brian Foster wrote:
> I tested the change below but it ended up failing xfs/131. Some fast and
> loose (i.e. LLM assisted) trace analysis suggests the issue is that this
> particular situation is racy. I.e., we write to a sparse file range and
> add COW fork dellaloc, writeback kicks in and drops the delalloc
> mapping, then zeroing occurs over said range and finds holes in both
> forks, then zone I/O completion occurs and maps blocks into the data
> fork.
Yes, that can happen. But the folio will be locked or have the
writeback bit set over that whole period, so I can't see how writeback
can actually race with that?
next prev parent reply other threads:[~2026-03-04 14:41 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-29 15:50 [PATCH v2 0/5] iomap, xfs: improve zero range flushing and lookup Brian Foster
2026-01-29 15:50 ` [PATCH v2 1/5] iomap, xfs: lift zero range hole mapping flush into xfs Brian Foster
2026-02-10 16:15 ` Christoph Hellwig
2026-02-10 19:14 ` Brian Foster
2026-02-11 15:36 ` Christoph Hellwig
2026-02-13 6:06 ` Christoph Hellwig
2026-02-13 17:37 ` Brian Foster
2026-03-02 19:02 ` Brian Foster
2026-03-03 14:37 ` Christoph Hellwig
2026-03-03 19:00 ` Brian Foster
2026-03-04 13:13 ` Christoph Hellwig
2026-03-04 14:17 ` Brian Foster
2026-03-04 14:41 ` Christoph Hellwig [this message]
2026-03-04 15:02 ` Brian Foster
2026-03-04 17:04 ` Brian Foster
2026-03-05 14:11 ` Christoph Hellwig
2026-03-05 15:06 ` Brian Foster
2026-03-05 16:10 ` Christoph Hellwig
2026-02-13 10:20 ` Nirjhar Roy (IBM)
2026-02-13 16:24 ` Darrick J. Wong
2026-02-18 17:41 ` Nirjhar Roy (IBM)
2026-01-29 15:50 ` [PATCH v2 2/5] xfs: flush eof folio before insert range size update Brian Foster
2026-02-10 16:16 ` Christoph Hellwig
2026-02-10 19:14 ` Brian Foster
2026-01-29 15:50 ` [PATCH v2 3/5] xfs: look up cow fork extent earlier for buffered iomap_begin Brian Foster
2026-02-10 16:17 ` Christoph Hellwig
2026-01-29 15:50 ` [PATCH v2 4/5] xfs: only flush when COW fork blocks overlap data fork holes Brian Foster
2026-02-10 16:19 ` Christoph Hellwig
2026-02-10 19:18 ` Brian Foster
2026-02-17 15:06 ` Nirjhar Roy (IBM)
2026-02-18 15:37 ` Brian Foster
2026-02-18 17:40 ` Nirjhar Roy (IBM)
2026-01-29 15:50 ` [PATCH v2 5/5] xfs: replace zero range flush with folio batch Brian Foster
2026-02-10 16:21 ` Christoph Hellwig
2026-02-10 19:19 ` Brian Foster
2026-02-11 15:41 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aahEk4yNqd15BIt7@infradead.org \
--to=hch@infradead.org \
--cc=bfoster@redhat.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.