From: Keith Busch <kbusch@kernel.org>
To: Gregory Price <gourry@gourry.net>
Cc: Keith Busch <kbusch@meta.com>,
linux-cxl@vger.kernel.org, dan.j.williams@intel.com,
dave.jiang@intel.com
Subject: Re: [PATCH] cxl/acpi: Fix CXL_ACPI and CXL_PMEM Kconfig tristate mismatch
Date: Thu, 5 Mar 2026 15:43:17 -0700 [thread overview]
Message-ID: <aaoHBcKZeQpioh4d@kbusch-mbp> (raw)
In-Reply-To: <aan_z0psj080u1e_@gourry-fedora-PF4VCD3F>
On Thu, Mar 05, 2026 at 05:12:31PM -0500, Gregory Price wrote:
> > @@ -59,6 +59,7 @@ config CXL_ACPI
> > tristate "CXL ACPI: Platform Support"
> > depends on ACPI
> > depends on ACPI_NUMA
> > + depends on CXL_PMEM || !CXL_PMEM
>
> Trivially looking at this it looks funky lol
> alternatively:
>
> https://lore.kernel.org/linux-cxl/20260302200429.803417-1-gourry@gourry.net/
>
> Not sure which one we want here
Yeah, I found your proposal just minutes after sending mine.
I agree this is whacky syntax, but it's a somewhat common Kconfig
pattern (see NF_CONNTRACK in net/ipv4/netfilter/Kconfig).
Anyway, my proposal here should force demotion to "m" for CXL_ACPI if
PMEM is also "m", where your proposal should force a failure path at
compile time if ACPI=y and PMEM=m. I really don't know if there's any
preference at all, I also just wanted the kernel build to complete
successfuly. :)
next prev parent reply other threads:[~2026-03-05 22:43 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-05 20:40 [PATCH] cxl/acpi: Fix CXL_ACPI and CXL_PMEM Kconfig tristate mismatch Keith Busch
2026-03-05 22:12 ` Gregory Price
2026-03-05 22:43 ` Keith Busch [this message]
2026-03-05 22:56 ` Gregory Price
2026-03-05 23:26 ` Keith Busch
2026-03-06 1:07 ` dan.j.williams
2026-03-06 1:26 ` Keith Busch
2026-03-06 1:55 ` dan.j.williams
2026-03-06 10:50 ` Jonathan Cameron
2026-03-06 15:23 ` Dave Jiang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aaoHBcKZeQpioh4d@kbusch-mbp \
--to=kbusch@kernel.org \
--cc=dan.j.williams@intel.com \
--cc=dave.jiang@intel.com \
--cc=gourry@gourry.net \
--cc=kbusch@meta.com \
--cc=linux-cxl@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.