All of lore.kernel.org
 help / color / mirror / Atom feed
From: Keith Busch <kbusch@kernel.org>
To: dan.j.williams@intel.com
Cc: Keith Busch <kbusch@meta.com>,
	linux-cxl@vger.kernel.org, dave.jiang@intel.com,
	gourry@gourry.net
Subject: Re: [PATCH] cxl/acpi: Fix CXL_ACPI and CXL_PMEM Kconfig tristate mismatch
Date: Thu, 5 Mar 2026 18:26:24 -0700	[thread overview]
Message-ID: <aaotQCg0TspiiaDH@kbusch-mbp> (raw)
In-Reply-To: <69aa28d0d9076_6423c100da@dwillia2-mobl4.notmuch>

On Thu, Mar 05, 2026 at 05:07:28PM -0800, dan.j.williams@intel.com wrote:
> > The call from cxl_acpi_probe() is guarded by
> > IS_ENABLED(CONFIG_CXL_PMEM), which evaluates to true for both =y and =m.

<snip>

> So I do not think this is sufficient because there is no
> devm_cxl_add_nvdimm_bridge() stub in the CONFIG_CXL_PMEM=n case, right?

It's called from a preprocesser "#if 0" section, so it shouldn't be
compiled in. At least it seems perfectly fine in local testing, but is
that compiler specific? I think this should have been optimized out.

  reply	other threads:[~2026-03-06  1:26 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-05 20:40 [PATCH] cxl/acpi: Fix CXL_ACPI and CXL_PMEM Kconfig tristate mismatch Keith Busch
2026-03-05 22:12 ` Gregory Price
2026-03-05 22:43   ` Keith Busch
2026-03-05 22:56     ` Gregory Price
2026-03-05 23:26       ` Keith Busch
2026-03-06  1:07 ` dan.j.williams
2026-03-06  1:26   ` Keith Busch [this message]
2026-03-06  1:55     ` dan.j.williams
2026-03-06 10:50       ` Jonathan Cameron
2026-03-06 15:23 ` Dave Jiang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aaotQCg0TspiiaDH@kbusch-mbp \
    --to=kbusch@kernel.org \
    --cc=dan.j.williams@intel.com \
    --cc=dave.jiang@intel.com \
    --cc=gourry@gourry.net \
    --cc=kbusch@meta.com \
    --cc=linux-cxl@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.