Re: [PATCH 1/2] drm/xe: Add for_each_gt_with_type() iterator

[Rodrigo Vivi <rodrigo.vivi@intel.com>]

On Thu, Mar 05, 2026 at 02:59:27PM -0800, Matt Roper wrote:
> There are a couple places in the driver today that have GT loops that
> only need to operate on a specific type of GT.  E.g.,
> 
>         for_each_gt(...) {
>                 if (xe_gt_is_media_type(gt))
>                         continue;
>                 ...
>         }
> 
> Some upcoming development is expected to utilize this pattern a bit more
> widely, so add a dedicated iterator that allows looping over specific GT
> type(s).
> 
> Note that this iterator uses a mask for the "type" parameter rather than
> a direct value match.  That's probably a bit overkill for now given that
> there are only two possible types of GTs, but if additional types of GTs
> ever show up in the future, this approach will fit more naturally and
> allow cases where we might want to loop over a subset of the possible
> types, or specifically mask off one single type.
> 
> Signed-off-by: Matt Roper <matthew.d.roper@intel.com>
> ---
>  drivers/gpu/drm/xe/xe_device.h | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/drivers/gpu/drm/xe/xe_device.h b/drivers/gpu/drm/xe/xe_device.h
> index 39464650533b5fd9aa7d9fc3dd432710303311b5..c4d26700266115f91330cff0a115a716e6899c50 100644
> --- a/drivers/gpu/drm/xe/xe_device.h
> +++ b/drivers/gpu/drm/xe/xe_device.h
> @@ -131,6 +131,10 @@ static inline bool xe_device_uc_enabled(struct xe_device *xe)
>  	for ((id__) = 0; (id__) < (xe__)->info.tile_count * (xe__)->info.max_gt_per_tile; (id__)++) \
>  		for_each_if((gt__) = xe_device_get_gt((xe__), (id__)))
>  
> +#define for_each_gt_with_type(gt__, xe__, id__, typemask__) \

perhaps we could leave it as:

for_each_gt_with(gt, xe, id, something)

where something for now is the gt_type, but it could later
be extended to some capability bitmask.

But nothing that cannot be done later/on-top.

Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>

> +	for_each_gt((gt__), (xe__), (id__)) \
> +		for_each_if((typemask__) & BIT((gt__)->info.type))
> +
>  #define for_each_gt_on_tile(gt__, tile__, id__) \
>  	for_each_gt((gt__), (tile__)->xe, (id__)) \
>  		for_each_if((gt__)->tile == (tile__))
> 
> -- 
> 2.53.0
>