Re: [PATCH 2/2] drm/xe: Utilize for_each_gt_with_type() for type-specific GT loops

[Rodrigo Vivi <rodrigo.vivi@intel.com>]

On Thu, Mar 05, 2026 at 02:59:28PM -0800, Matt Roper wrote:
> Convert existing loops with Coccinelle via the following semantic patch:
> 
>     @@
>     identifier GT, XE, ID;
>     iterator name for_each_gt, for_each_gt_with_type;
>     @@
>     - for_each_gt(GT, XE, ID) {
>     + for_each_gt_with_type(GT, XE, ID, BIT(XE_GT_TYPE_MAIN)) {
>     -         if (xe_gt_is_media_type(GT))
>     -                 continue;
>               ...
>       }
> 
>     @@
>     identifier GT, XE, ID;
>     iterator name for_each_gt, for_each_gt_with_type;
>     @@
>     - for_each_gt(GT, XE, ID) {
>     + for_each_gt_with_type(GT, XE, ID, BIT(XE_GT_TYPE_MEDIA)) {
>     -         if (xe_gt_is_main_type(GT))
>     -                 continue;
>               ...
>       }
> 
>     @@
>     identifier GT, XE, ID;
>     iterator name for_each_gt, for_each_gt_with_type;
>     @@
>     - for_each_gt(GT, XE, ID) {
>     + for_each_gt_with_type(GT, XE, ID, BIT(XE_GT_TYPE_MAIN)) {
>     -         if (!xe_gt_is_main_type(GT))
>     -                 continue;
>               ...
>       }
> 
>     @@
>     identifier GT, XE, ID;
>     iterator name for_each_gt, for_each_gt_with_type;
>     @@
>     - for_each_gt(GT, XE, ID) {
>     + for_each_gt_with_type(GT, XE, ID, BIT(XE_GT_TYPE_MEDIA)) {
>     -         if (xe_gt_is_media_type(GT))
>     -                 continue;
>               ...
>       }
> 
> No functional change expected.
> 
> Signed-off-by: Matt Roper <matthew.d.roper@intel.com>
> ---
>  drivers/gpu/drm/xe/xe_device.c             | 5 +----
>  drivers/gpu/drm/xe/xe_gt_sriov_pf_config.c | 5 +----
>  2 files changed, 2 insertions(+), 8 deletions(-)
> 
> diff --git a/drivers/gpu/drm/xe/xe_device.c b/drivers/gpu/drm/xe/xe_device.c
> index 3462645ca13c79b9cfed0de86cfffe150b51942a..e77a3a3db73dbf8509d857b58a2dc3964d9aa0ca 100644
> --- a/drivers/gpu/drm/xe/xe_device.c
> +++ b/drivers/gpu/drm/xe/xe_device.c
> @@ -1074,10 +1074,7 @@ static void tdf_request_sync(struct xe_device *xe)
>  	struct xe_gt *gt;
>  	u8 id;
>  
> -	for_each_gt(gt, xe, id) {
> -		if (xe_gt_is_media_type(gt))
> -			continue;
> -
> +	for_each_gt_with_type(gt, xe, id, BIT(XE_GT_TYPE_MAIN)) {
>  		CLASS(xe_force_wake, fw_ref)(gt_to_fw(gt), XE_FW_GT);
>  		if (!fw_ref.domains)
>  			return;
> diff --git a/drivers/gpu/drm/xe/xe_gt_sriov_pf_config.c b/drivers/gpu/drm/xe/xe_gt_sriov_pf_config.c
> index b867203b49977537a31c1a1780c0409d5541c83d..2f376b5fb08827d81a070735c4b4a35338723552 100644
> --- a/drivers/gpu/drm/xe/xe_gt_sriov_pf_config.c
> +++ b/drivers/gpu/drm/xe/xe_gt_sriov_pf_config.c
> @@ -1579,10 +1579,7 @@ static int pf_update_vf_lmtt(struct xe_device *xe, unsigned int vfid)
>  			goto fail;
>  
>  		offset = 0;
> -		for_each_gt(gt, xe, gtid) {
> -			if (xe_gt_is_media_type(gt))
> -				continue;
> -
> +		for_each_gt_with_type(gt, xe, gtid, BIT(XE_GT_TYPE_MAIN)) {

Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>

>  			config = pf_pick_vf_config(gt, vfid);
>  			bo = config->lmem_obj;
>  			if (!bo)
> 
> -- 
> 2.53.0
>