From: Jia-Ju Bai <baijiaju1990@gmail.com>
To: dccp@vger.kernel.org
Subject: Re: [PATCH] net: dccp: Replace GFP_ATOMIC with GFP_KERNEL in dccp_init
Date: Mon, 09 Apr 2018 14:46:05 +0000 [thread overview]
Message-ID: <ab55c4a7-ee67-eead-eeeb-4dc92eaf9aee@gmail.com> (raw)
In-Reply-To: <1523283004-25581-1-git-send-email-baijiaju1990@gmail.com>
On 2018/4/9 22:42, Eric Dumazet wrote:
>
> On 04/09/2018 07:10 AM, Jia-Ju Bai wrote:
>> dccp_init() is never called in atomic context.
>> This function is only set as a parameter of module_init().
>>
>> Despite never getting called from atomic context,
>> dccp_init() calls __get_free_pages() with GFP_ATOMIC,
>> which waits busily for allocation.
> What do you mean by "waits busily" ?
>
> GFP_ATOMIC does not sleep, does not wait.
Sorry, I should modify it to "does not sleep".
Do you think it is okay?
Best wishes,
Jia-Ju Bai
WARNING: multiple messages have this Message-ID (diff)
From: Jia-Ju Bai <baijiaju1990@gmail.com>
To: Eric Dumazet <eric.dumazet@gmail.com>,
gerrit@erg.abdn.ac.uk, davem@davemloft.net
Cc: dccp@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net: dccp: Replace GFP_ATOMIC with GFP_KERNEL in dccp_init
Date: Mon, 9 Apr 2018 22:46:05 +0800 [thread overview]
Message-ID: <ab55c4a7-ee67-eead-eeeb-4dc92eaf9aee@gmail.com> (raw)
In-Reply-To: <8216dee8-5e52-421e-026a-4c75d654be54@gmail.com>
On 2018/4/9 22:42, Eric Dumazet wrote:
>
> On 04/09/2018 07:10 AM, Jia-Ju Bai wrote:
>> dccp_init() is never called in atomic context.
>> This function is only set as a parameter of module_init().
>>
>> Despite never getting called from atomic context,
>> dccp_init() calls __get_free_pages() with GFP_ATOMIC,
>> which waits busily for allocation.
> What do you mean by "waits busily" ?
>
> GFP_ATOMIC does not sleep, does not wait.
Sorry, I should modify it to "does not sleep".
Do you think it is okay?
Best wishes,
Jia-Ju Bai
next prev parent reply other threads:[~2018-04-09 14:46 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-09 14:10 [PATCH] net: dccp: Replace GFP_ATOMIC with GFP_KERNEL in dccp_init Jia-Ju Bai
2018-04-09 14:10 ` Jia-Ju Bai
2018-04-09 14:42 ` Eric Dumazet
2018-04-09 14:42 ` Eric Dumazet
2018-04-09 14:46 ` Jia-Ju Bai [this message]
2018-04-09 14:46 ` Jia-Ju Bai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ab55c4a7-ee67-eead-eeeb-4dc92eaf9aee@gmail.com \
--to=baijiaju1990@gmail.com \
--cc=dccp@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.