All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Xu <peterx@redhat.com>
To: Sergei Heifetz <heifetz@yandex-team.com>
Cc: qemu-devel@nongnu.org, "Fabiano Rosas" <farosas@suse.de>,
	"Marc-André Lureau" <marcandre.lureau@redhat.com>,
	"Paolo Bonzini" <pbonzini@redhat.com>,
	"Philippe Mathieu-Daudé" <philmd@linaro.org>,
	"Ani Sinha" <anisinha@redhat.com>,
	qemu-trivial@nongnu.org
Subject: Re: [PATCH v4 0/4] Fix a few minor issues reported by Coverity
Date: Wed, 11 Mar 2026 13:37:22 -0400	[thread overview]
Message-ID: <abGoUkNv0sqgm5QH@x1.local> (raw)
In-Reply-To: <20260311131522.58600-1-heifetz@yandex-team.com>

On Wed, Mar 11, 2026 at 06:15:18PM +0500, Sergei Heifetz wrote:
> Hi. This patch series fixes several minor issues reported by our local
> Coverity installation.
> 
> Changes in v4:
> - Included Peter's explanation why `assert` is redundant in the commit
>   message of the third patch.
> - Added `Reviewed-by` tags that I missed in v2 to the other three patches.
> 
> Changes in v3:
> - Nothing. I sent the second version of the series without the corresponding
> 'v2' suffix by mistake. I apologise.
> 
> Changes in v2:
> - Remove assert(block) in system/physmem.c instead of placing it
>   before the dereference.
> 
> Sergei Heifetz (4):
>   migration/savevm.c: reorder usage and assertion of mis->from_src_file
>   dump/dump.c: reorder usage and assertion of block
>   system/physmem.c: remove useless assertion of block
>   hw/usb/core.c: reorder usage and assertion of p->ep

Reviewed-by: Peter Xu <peterx@redhat.com>

-- 
Peter Xu



      parent reply	other threads:[~2026-03-11 17:37 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-11 13:15 [PATCH v4 0/4] Fix a few minor issues reported by Coverity Sergei Heifetz
2026-03-11 13:15 ` [PATCH v4 1/4] migration/savevm.c: reorder usage and assertion of mis->from_src_file Sergei Heifetz
2026-03-11 13:58   ` Fabiano Rosas
2026-03-12 11:43   ` Prasad Pandit
2026-03-11 13:15 ` [PATCH v4 2/4] dump/dump.c: reorder usage and assertion of block Sergei Heifetz
2026-03-11 13:15 ` [PATCH v4 3/4] system/physmem.c: remove useless " Sergei Heifetz
2026-03-11 13:15 ` [PATCH v4 4/4] hw/usb/core.c: reorder usage and assertion of p->ep Sergei Heifetz
2026-03-11 17:37 ` Peter Xu [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=abGoUkNv0sqgm5QH@x1.local \
    --to=peterx@redhat.com \
    --cc=anisinha@redhat.com \
    --cc=farosas@suse.de \
    --cc=heifetz@yandex-team.com \
    --cc=marcandre.lureau@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=philmd@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-trivial@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.