From: Yao Zi <me@ziyao.cc>
To: Junhui Liu <junhui.liu@pigmoral.tech>,
Linus Walleij <linusw@kernel.org>, Yixun Lan <dlan@kernel.org>,
Bartosz Golaszewski <brgl@kernel.org>
Cc: linux-gpio@vger.kernel.org, linux-riscv@lists.infradead.org,
spacemit@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] pinctrl: spacemit: return -ENOTSUPP for unsupported pin configurations
Date: Fri, 13 Mar 2026 13:37:34 +0000 [thread overview]
Message-ID: <abQTHmE_8_N3F-Hj@pie> (raw)
In-Reply-To: <20260312-k1-gpio-set-config-v1-1-8c3541da16b1@pigmoral.tech>
On Thu, Mar 12, 2026 at 04:42:42PM +0800, Junhui Liu wrote:
> Return -ENOTSUPP instead of -EINVAL when encountering unsupported pin
> configuration parameters. This is more logical and allows the GPIO
> subsystem to gracefully handle unsupported parameters via functions like
> gpio_set_config_with_argument_optional(), which specifically ignores
> -ENOTSUPP but treats others as failure.
This sounds like a fix and deserves Fixes tag, though I'm not sure
whether backporting is appropriate since no existing system should be
affected...
Regards,
Yao Zi
WARNING: multiple messages have this Message-ID (diff)
From: Yao Zi <me@ziyao.cc>
To: Junhui Liu <junhui.liu@pigmoral.tech>,
Linus Walleij <linusw@kernel.org>, Yixun Lan <dlan@kernel.org>,
Bartosz Golaszewski <brgl@kernel.org>
Cc: linux-gpio@vger.kernel.org, linux-riscv@lists.infradead.org,
spacemit@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] pinctrl: spacemit: return -ENOTSUPP for unsupported pin configurations
Date: Fri, 13 Mar 2026 13:37:34 +0000 [thread overview]
Message-ID: <abQTHmE_8_N3F-Hj@pie> (raw)
In-Reply-To: <20260312-k1-gpio-set-config-v1-1-8c3541da16b1@pigmoral.tech>
On Thu, Mar 12, 2026 at 04:42:42PM +0800, Junhui Liu wrote:
> Return -ENOTSUPP instead of -EINVAL when encountering unsupported pin
> configuration parameters. This is more logical and allows the GPIO
> subsystem to gracefully handle unsupported parameters via functions like
> gpio_set_config_with_argument_optional(), which specifically ignores
> -ENOTSUPP but treats others as failure.
This sounds like a fix and deserves Fixes tag, though I'm not sure
whether backporting is appropriate since no existing system should be
affected...
Regards,
Yao Zi
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
next prev parent reply other threads:[~2026-03-13 13:38 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-12 8:42 [PATCH 0/2] gpio/pinctrl: spacemit: Add GPIO pin configuration support for K1 Junhui Liu
2026-03-12 8:42 ` Junhui Liu
2026-03-12 8:42 ` [PATCH 1/2] pinctrl: spacemit: return -ENOTSUPP for unsupported pin configurations Junhui Liu
2026-03-12 8:42 ` Junhui Liu
2026-03-13 13:37 ` Yao Zi [this message]
2026-03-13 13:37 ` Yao Zi
2026-03-13 13:52 ` Bartosz Golaszewski
2026-03-13 13:52 ` Bartosz Golaszewski
2026-03-14 8:20 ` Anand Moon
2026-03-14 8:20 ` Anand Moon
2026-03-12 8:42 ` [PATCH 2/2] gpio: spacemit-k1: Add set_config callback support Junhui Liu
2026-03-12 8:42 ` Junhui Liu
2026-03-13 14:05 ` Bartosz Golaszewski
2026-03-13 14:05 ` Bartosz Golaszewski
2026-03-19 12:54 ` Linus Walleij
2026-03-19 12:54 ` Linus Walleij
2026-03-14 8:20 ` Anand Moon
2026-03-14 8:20 ` Anand Moon
2026-03-12 11:21 ` [PATCH 0/2] gpio/pinctrl: spacemit: Add GPIO pin configuration support for K1 Yixun Lan
2026-03-12 11:21 ` Yixun Lan
2026-03-19 12:53 ` Linus Walleij
2026-03-19 12:53 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=abQTHmE_8_N3F-Hj@pie \
--to=me@ziyao.cc \
--cc=brgl@kernel.org \
--cc=dlan@kernel.org \
--cc=junhui.liu@pigmoral.tech \
--cc=linusw@kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=spacemit@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.