From: Osama Abdelkader <osama.abdelkader@gmail.com>
To: Markus Elfring <Markus.Elfring@web.de>
Cc: kvm-riscv@lists.infradead.org, linux-riscv@lists.infradead.org,
kvm@vger.kernel.org, Albert Ou <aou@eecs.berkeley.edu>,
Alexandre Ghiti <alex@ghiti.fr>, Anup Patel <anup@brainfault.org>,
Atish Patra <atish.patra@linux.dev>,
Palmer Dabbelt <palmer@dabbelt.com>,
Paul Walmsley <pjw@kernel.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] riscv: kvm: fix vector context allocation leak
Date: Mon, 16 Mar 2026 16:24:12 +0100 [thread overview]
Message-ID: <abggnCAb9Py60PBT@osama> (raw)
In-Reply-To: <19cdcafd-adab-469d-9729-f01e8bcaf543@web.de>
On Mon, Mar 16, 2026 at 10:23:27AM +0100, Markus Elfring wrote:
> > When the second kzalloc (host_context.vector.datap) fails in
> > kvm_riscv_vcpu_alloc_vector_context, the first allocation
> > (guest_context.vector.datap) is leaked. Free it before returning.
>
> Were any source code analysis tools involved here?
>
No, there were found during manual review.
>
> How do you think about to add any tags (like “Fixes” and “Cc”) accordingly?
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v7.0-rc4#n145
>
Done, I just sent v2, thank you.
> Regards,
> Markus
Best regards,
Osama
--
kvm-riscv mailing list
kvm-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kvm-riscv
WARNING: multiple messages have this Message-ID (diff)
From: Osama Abdelkader <osama.abdelkader@gmail.com>
To: Markus Elfring <Markus.Elfring@web.de>
Cc: kvm-riscv@lists.infradead.org, linux-riscv@lists.infradead.org,
kvm@vger.kernel.org, Albert Ou <aou@eecs.berkeley.edu>,
Alexandre Ghiti <alex@ghiti.fr>, Anup Patel <anup@brainfault.org>,
Atish Patra <atish.patra@linux.dev>,
Palmer Dabbelt <palmer@dabbelt.com>,
Paul Walmsley <pjw@kernel.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] riscv: kvm: fix vector context allocation leak
Date: Mon, 16 Mar 2026 16:24:12 +0100 [thread overview]
Message-ID: <abggnCAb9Py60PBT@osama> (raw)
In-Reply-To: <19cdcafd-adab-469d-9729-f01e8bcaf543@web.de>
On Mon, Mar 16, 2026 at 10:23:27AM +0100, Markus Elfring wrote:
> > When the second kzalloc (host_context.vector.datap) fails in
> > kvm_riscv_vcpu_alloc_vector_context, the first allocation
> > (guest_context.vector.datap) is leaked. Free it before returning.
>
> Were any source code analysis tools involved here?
>
No, there were found during manual review.
>
> How do you think about to add any tags (like “Fixes” and “Cc”) accordingly?
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v7.0-rc4#n145
>
Done, I just sent v2, thank you.
> Regards,
> Markus
Best regards,
Osama
WARNING: multiple messages have this Message-ID (diff)
From: Osama Abdelkader <osama.abdelkader@gmail.com>
To: Markus Elfring <Markus.Elfring@web.de>
Cc: kvm-riscv@lists.infradead.org, linux-riscv@lists.infradead.org,
kvm@vger.kernel.org, Albert Ou <aou@eecs.berkeley.edu>,
Alexandre Ghiti <alex@ghiti.fr>, Anup Patel <anup@brainfault.org>,
Atish Patra <atish.patra@linux.dev>,
Palmer Dabbelt <palmer@dabbelt.com>,
Paul Walmsley <pjw@kernel.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] riscv: kvm: fix vector context allocation leak
Date: Mon, 16 Mar 2026 16:24:12 +0100 [thread overview]
Message-ID: <abggnCAb9Py60PBT@osama> (raw)
In-Reply-To: <19cdcafd-adab-469d-9729-f01e8bcaf543@web.de>
On Mon, Mar 16, 2026 at 10:23:27AM +0100, Markus Elfring wrote:
> > When the second kzalloc (host_context.vector.datap) fails in
> > kvm_riscv_vcpu_alloc_vector_context, the first allocation
> > (guest_context.vector.datap) is leaked. Free it before returning.
>
> Were any source code analysis tools involved here?
>
No, there were found during manual review.
>
> How do you think about to add any tags (like “Fixes” and “Cc”) accordingly?
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v7.0-rc4#n145
>
Done, I just sent v2, thank you.
> Regards,
> Markus
Best regards,
Osama
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
next prev parent reply other threads:[~2026-03-16 15:24 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-14 22:31 [PATCH] riscv: kvm: fix vector context allocation leak Osama Abdelkader
2026-03-14 22:31 ` Osama Abdelkader
2026-03-14 22:31 ` Osama Abdelkader
2026-03-16 9:23 ` Markus Elfring
2026-03-16 9:23 ` Markus Elfring
2026-03-16 9:23 ` Markus Elfring
2026-03-16 15:24 ` Osama Abdelkader [this message]
2026-03-16 15:24 ` Osama Abdelkader
2026-03-16 15:24 ` Osama Abdelkader
2026-03-16 16:36 ` Markus Elfring
2026-03-16 16:36 ` Markus Elfring
2026-03-16 16:36 ` Markus Elfring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=abggnCAb9Py60PBT@osama \
--to=osama.abdelkader@gmail.com \
--cc=Markus.Elfring@web.de \
--cc=alex@ghiti.fr \
--cc=anup@brainfault.org \
--cc=aou@eecs.berkeley.edu \
--cc=atish.patra@linux.dev \
--cc=kvm-riscv@lists.infradead.org \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=palmer@dabbelt.com \
--cc=pjw@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.