From: Jiayu Du <jiayu.riscv@isrc.iscas.ac.cn>
To: Junhui Liu <junhui.liu@pigmoral.tech>
Cc: pjw@kernel.org, palmer@dabbelt.com, aou@eecs.berkeley.edu,
linux-mmc@vger.kernel.org, devicetree@vger.kernel.org,
linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org,
gaohan@iscas.ac.cn, me@ziyao.cc,
linux-riscv <linux-riscv-bounces@lists.infradead.org>
Subject: Re: [PATCH v4 3/3] riscv: dts: canaan: Add mmc nodes for K230
Date: Tue, 17 Mar 2026 00:03:28 +0800 [thread overview]
Message-ID: <abgp0PT4GHRwmaLy@duge-virtual-machine> (raw)
In-Reply-To: <DH49Q7OQSIYM.1RD7H0L809JQV@pigmoral.tech>
On Mon, Mar 16, 2026 at 10:15:27PM +0800, Junhui Liu wrote:
> Hi Jiayu,
> Thanks for the new version. Just a friendly reminder.
>
> On Sun Mar 15, 2026 at 1:44 PM CST, Jiayu Du wrote:
> > Add MMC nodes to K230, including eMMC and SDIO. Enable HS200 eMMC
> > on the SoM and SDIO high-speed on the board.
> >
> > Signed-off-by: Jiayu Du <jiayu.riscv@isrc.iscas.ac.cn>
> > ---
> > .../boot/dts/canaan/k230-canmv-dshanpi.dts | 56 +++++++++++++++++++
> > .../dts/canaan/k230-canmv-module-dshanpi.dtsi | 7 +++
> > arch/riscv/boot/dts/canaan/k230.dtsi | 28 ++++++++++
> > 3 files changed, 91 insertions(+)
>
> [...]
>
> > +
> > +&sdio {
> > + bus-width = <4>;
> > + max-frequency = <50000000>;
> > + pinctrl-names = "default";
> > + pinctrl-0 = <&mmc1_pins>;
> > + vmmc-supply = <&vdd_3v3>;
> > + vqmmc-supply = <&vdd_3v3>;
> > + cap-sd-highspeed;
> > + no-1-8-v;
> > + status = "okay";
> > };
> >
>
> It seems the broken-cd property we discussed in the previous version is
> not added, and also my Tested-by tag (for the whole series). Was this
> intentional or just an oversight?
>
Sorry for that, It was a oversight. I will fix both.
And I will only add your Tested-by tags to patch [2/3] and [3/3].
Is this correct?
Kind regards,
Jiayu Du
> --
> Best regards,
> Junhui Liu
>
WARNING: multiple messages have this Message-ID (diff)
From: Jiayu Du <jiayu.riscv@isrc.iscas.ac.cn>
To: Junhui Liu <junhui.liu@pigmoral.tech>
Cc: pjw@kernel.org, palmer@dabbelt.com, aou@eecs.berkeley.edu,
linux-mmc@vger.kernel.org, devicetree@vger.kernel.org,
linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org,
gaohan@iscas.ac.cn, me@ziyao.cc,
linux-riscv <linux-riscv-bounces@lists.infradead.org>
Subject: Re: [PATCH v4 3/3] riscv: dts: canaan: Add mmc nodes for K230
Date: Tue, 17 Mar 2026 00:03:28 +0800 [thread overview]
Message-ID: <abgp0PT4GHRwmaLy@duge-virtual-machine> (raw)
In-Reply-To: <DH49Q7OQSIYM.1RD7H0L809JQV@pigmoral.tech>
On Mon, Mar 16, 2026 at 10:15:27PM +0800, Junhui Liu wrote:
> Hi Jiayu,
> Thanks for the new version. Just a friendly reminder.
>
> On Sun Mar 15, 2026 at 1:44 PM CST, Jiayu Du wrote:
> > Add MMC nodes to K230, including eMMC and SDIO. Enable HS200 eMMC
> > on the SoM and SDIO high-speed on the board.
> >
> > Signed-off-by: Jiayu Du <jiayu.riscv@isrc.iscas.ac.cn>
> > ---
> > .../boot/dts/canaan/k230-canmv-dshanpi.dts | 56 +++++++++++++++++++
> > .../dts/canaan/k230-canmv-module-dshanpi.dtsi | 7 +++
> > arch/riscv/boot/dts/canaan/k230.dtsi | 28 ++++++++++
> > 3 files changed, 91 insertions(+)
>
> [...]
>
> > +
> > +&sdio {
> > + bus-width = <4>;
> > + max-frequency = <50000000>;
> > + pinctrl-names = "default";
> > + pinctrl-0 = <&mmc1_pins>;
> > + vmmc-supply = <&vdd_3v3>;
> > + vqmmc-supply = <&vdd_3v3>;
> > + cap-sd-highspeed;
> > + no-1-8-v;
> > + status = "okay";
> > };
> >
>
> It seems the broken-cd property we discussed in the previous version is
> not added, and also my Tested-by tag (for the whole series). Was this
> intentional or just an oversight?
>
Sorry for that, It was a oversight. I will fix both.
And I will only add your Tested-by tags to patch [2/3] and [3/3].
Is this correct?
Kind regards,
Jiayu Du
> --
> Best regards,
> Junhui Liu
>
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
next prev parent reply other threads:[~2026-03-16 16:03 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-15 5:44 [PATCH v4 0/3] Add SDHCI support for Canaan K230 SoC Jiayu Du
2026-03-15 5:44 ` Jiayu Du
2026-03-15 5:44 ` [PATCH v4 1/3] dt-bindings: mmc: Add sdhci support for Canaan k230 Jiayu Du
2026-03-15 5:44 ` Jiayu Du
2026-03-15 5:44 ` [PATCH v4 2/3] mmc: sdhci-dwcmshc: Add Canaan K230 DWCMSHC controller support Jiayu Du
2026-03-15 5:44 ` Jiayu Du
2026-03-16 12:33 ` Adrian Hunter
2026-03-16 12:33 ` Adrian Hunter
2026-03-15 5:44 ` [PATCH v4 3/3] riscv: dts: canaan: Add mmc nodes for K230 Jiayu Du
2026-03-15 5:44 ` Jiayu Du
2026-03-16 14:15 ` Junhui Liu
2026-03-16 14:15 ` Junhui Liu
2026-03-16 16:03 ` Jiayu Du [this message]
2026-03-16 16:03 ` Jiayu Du
2026-03-17 6:52 ` Junhui Liu
2026-03-17 6:52 ` Junhui Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=abgp0PT4GHRwmaLy@duge-virtual-machine \
--to=jiayu.riscv@isrc.iscas.ac.cn \
--cc=aou@eecs.berkeley.edu \
--cc=devicetree@vger.kernel.org \
--cc=gaohan@iscas.ac.cn \
--cc=junhui.liu@pigmoral.tech \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-riscv-bounces@lists.infradead.org \
--cc=linux-riscv@lists.infradead.org \
--cc=me@ziyao.cc \
--cc=palmer@dabbelt.com \
--cc=pjw@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.