From: Alice Ryhl <aliceryhl@google.com>
To: Timur Tabi <ttabi@nvidia.com>
Cc: Miguel Ojeda <ojeda@kernel.org>,
Danilo Krummrich <dakr@kernel.org>, Gary Guo <gary@garyguo.net>,
mmaurer@google.com, Alexandre Courbot <acourbot@nvidia.com>,
Joel Fernandes <joelagnelf@nvidia.com>,
ecourtney@nvidia.com, rust-for-linux@vger.kernel.org,
nouveau@lists.freedesktop.org
Subject: Re: [PATCH v9 3/6] rust: dma: implement BinaryWriter for CoherentAllocation<u8>
Date: Mon, 16 Mar 2026 20:46:01 +0000 [thread overview]
Message-ID: <abhsCSOuS3pi9qrh@google.com> (raw)
In-Reply-To: <20260316055736.1690546-4-ttabi@nvidia.com>
On Mon, Mar 16, 2026 at 12:57:33AM -0500, Timur Tabi wrote:
> Implement the BinaryWriter trait for CoherentAllocation<u8>, enabling
> DMA coherent allocations to be exposed as readable binary files.
> The implementation handles offset tracking and bounds checking, copying
> data from the coherent allocation to userspace via write_dma().
>
> Signed-off-by: Timur Tabi <ttabi@nvidia.com>
Reviewed-by: Alice Ryhl <aliceryhl@google.com>
> + let count = self.count().saturating_sub(offset_val).min(writer.len());
It's kind of weird to call the length method self.count() rather than
self.len(). All other methods called count() in the stdlib are cases
where you get a length by literally counting with a for loop.
Anyway, not a problem of this patch. LGTM.
Alice
WARNING: multiple messages have this Message-ID (diff)
From: Alice Ryhl <aliceryhl@google.com>
To: Timur Tabi <ttabi@nvidia.com>
Cc: Miguel Ojeda <ojeda@kernel.org>,
Danilo Krummrich <dakr@kernel.org>, Gary Guo <gary@garyguo.net>,
mmaurer@google.com, Alexandre Courbot <acourbot@nvidia.com>,
John Hubbard <jhubbard@nvidia.com>,
Joel Fernandes <joelagnelf@nvidia.com>,
ecourtney@nvidia.com, rust-for-linux@vger.kernel.org,
nouveau@lists.freedesktop.org
Subject: Re: [PATCH v9 3/6] rust: dma: implement BinaryWriter for CoherentAllocation<u8>
Date: Mon, 16 Mar 2026 20:46:01 +0000 [thread overview]
Message-ID: <abhsCSOuS3pi9qrh@google.com> (raw)
In-Reply-To: <20260316055736.1690546-4-ttabi@nvidia.com>
On Mon, Mar 16, 2026 at 12:57:33AM -0500, Timur Tabi wrote:
> Implement the BinaryWriter trait for CoherentAllocation<u8>, enabling
> DMA coherent allocations to be exposed as readable binary files.
> The implementation handles offset tracking and bounds checking, copying
> data from the coherent allocation to userspace via write_dma().
>
> Signed-off-by: Timur Tabi <ttabi@nvidia.com>
Reviewed-by: Alice Ryhl <aliceryhl@google.com>
> + let count = self.count().saturating_sub(offset_val).min(writer.len());
It's kind of weird to call the length method self.count() rather than
self.len(). All other methods called count() in the stdlib are cases
where you get a length by literally counting with a for loop.
Anyway, not a problem of this patch. LGTM.
Alice
next prev parent reply other threads:[~2026-03-16 20:46 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-16 5:57 [PATCH v9 0/6] gpu: nova-core: expose the logging buffers via debugfs Timur Tabi
2026-03-16 5:57 ` [PATCH v9 1/6] rust: device: add device name method Timur Tabi
2026-03-16 11:49 ` Gary Guo
2026-03-16 5:57 ` [PATCH v9 2/6] rust: uaccess: add write_dma() for copying from DMA buffers to userspace Timur Tabi
2026-03-16 20:42 ` Alice Ryhl
2026-03-16 20:42 ` Alice Ryhl
2026-03-16 21:42 ` Timur Tabi
2026-03-16 21:42 ` Timur Tabi
2026-03-16 21:51 ` Alice Ryhl
2026-03-16 21:51 ` Alice Ryhl
2026-03-17 21:43 ` Miguel Ojeda
2026-03-17 21:43 ` Miguel Ojeda
2026-03-17 23:02 ` Timur Tabi
2026-03-17 23:02 ` Timur Tabi
2026-03-16 5:57 ` [PATCH v9 3/6] rust: dma: implement BinaryWriter for CoherentAllocation<u8> Timur Tabi
2026-03-16 20:46 ` Alice Ryhl [this message]
2026-03-16 20:46 ` Alice Ryhl
2026-03-16 21:57 ` Gary Guo
2026-03-16 21:57 ` Gary Guo
2026-03-17 4:22 ` Alexandre Courbot
2026-03-17 4:22 ` Alexandre Courbot
2026-03-16 5:57 ` [PATCH v9 4/6] gpu: nova-core: Replace module_pci_driver! with explicit module init Timur Tabi
2026-03-16 16:28 ` Gary Guo
2026-03-16 5:57 ` [PATCH v9 5/6] gpu: nova-core: create debugfs root in " Timur Tabi
2026-03-16 16:28 ` Gary Guo
2026-03-16 5:57 ` [PATCH v9 6/6] gpu: nova-core: create GSP-RM logging buffers debugfs entries Timur Tabi
2026-03-16 16:29 ` Gary Guo
2026-03-16 22:05 ` [PATCH v9 0/6] gpu: nova-core: expose the logging buffers via debugfs John Hubbard
2026-03-17 1:53 ` Eliot Courtney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=abhsCSOuS3pi9qrh@google.com \
--to=aliceryhl@google.com \
--cc=acourbot@nvidia.com \
--cc=dakr@kernel.org \
--cc=ecourtney@nvidia.com \
--cc=gary@garyguo.net \
--cc=joelagnelf@nvidia.com \
--cc=mmaurer@google.com \
--cc=nouveau@lists.freedesktop.org \
--cc=ojeda@kernel.org \
--cc=rust-for-linux@vger.kernel.org \
--cc=ttabi@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.