* [PATCH] build-sys: use the "run" variable
@ 2026-02-11 10:33 marcandre.lureau
2026-03-17 10:34 ` Marc-André Lureau
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: marcandre.lureau @ 2026-02-11 10:33 UTC (permalink / raw)
To: qemu-devel
Cc: berrange, Marc-André Lureau, Paolo Bonzini,
Philippe Mathieu-Daudé
From: Marc-André Lureau <marcandre.lureau@redhat.com>
Avoid unused variables and hand-written path, this should also help meson
to figure out the relation between the commands.
Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
---
meson.build | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/meson.build b/meson.build
index 38ad6820f3e..e2aa90a43de 100644
--- a/meson.build
+++ b/meson.build
@@ -3473,7 +3473,7 @@ run_config = configuration_data({'build_dir': meson.current_build_dir()})
run = configure_file(input: 'run.in',
output: 'run',
configuration: run_config)
-run_command('chmod', 'a+x', meson.current_build_dir() / 'run', check: true)
+run_command('chmod', 'a+x', run, check: true)
hxtool = find_program('scripts/hxtool')
shaderinclude = find_program('scripts/shaderinclude.py')
--
2.52.0
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] build-sys: use the "run" variable
2026-02-11 10:33 [PATCH] build-sys: use the "run" variable marcandre.lureau
@ 2026-03-17 10:34 ` Marc-André Lureau
2026-03-17 10:47 ` Daniel P. Berrangé
2026-03-17 11:03 ` Paolo Bonzini
2 siblings, 0 replies; 4+ messages in thread
From: Marc-André Lureau @ 2026-03-17 10:34 UTC (permalink / raw)
To: qemu-devel, P. Berrange, Daniel
Cc: Paolo Bonzini, Philippe Mathieu-Daudé
On Wed, Feb 11, 2026 at 2:33 PM <marcandre.lureau@redhat.com> wrote:
>
> From: Marc-André Lureau <marcandre.lureau@redhat.com>
>
> Avoid unused variables and hand-written path, this should also help meson
> to figure out the relation between the commands.
>
> Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
ping
> ---
> meson.build | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/meson.build b/meson.build
> index 38ad6820f3e..e2aa90a43de 100644
> --- a/meson.build
> +++ b/meson.build
> @@ -3473,7 +3473,7 @@ run_config = configuration_data({'build_dir': meson.current_build_dir()})
> run = configure_file(input: 'run.in',
> output: 'run',
> configuration: run_config)
> -run_command('chmod', 'a+x', meson.current_build_dir() / 'run', check: true)
> +run_command('chmod', 'a+x', run, check: true)
>
> hxtool = find_program('scripts/hxtool')
> shaderinclude = find_program('scripts/shaderinclude.py')
> --
> 2.52.0
>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] build-sys: use the "run" variable
2026-02-11 10:33 [PATCH] build-sys: use the "run" variable marcandre.lureau
2026-03-17 10:34 ` Marc-André Lureau
@ 2026-03-17 10:47 ` Daniel P. Berrangé
2026-03-17 11:03 ` Paolo Bonzini
2 siblings, 0 replies; 4+ messages in thread
From: Daniel P. Berrangé @ 2026-03-17 10:47 UTC (permalink / raw)
To: marcandre.lureau; +Cc: qemu-devel, Paolo Bonzini, Philippe Mathieu-Daudé
On Wed, Feb 11, 2026 at 02:33:05PM +0400, marcandre.lureau@redhat.com wrote:
> From: Marc-André Lureau <marcandre.lureau@redhat.com>
>
> Avoid unused variables and hand-written path, this should also help meson
> to figure out the relation between the commands.
>
> Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
> ---
> meson.build | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
With regards,
Daniel
--
|: https://berrange.com ~~ https://hachyderm.io/@berrange :|
|: https://libvirt.org ~~ https://entangle-photo.org :|
|: https://pixelfed.art/berrange ~~ https://fstop138.berrange.com :|
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] build-sys: use the "run" variable
2026-02-11 10:33 [PATCH] build-sys: use the "run" variable marcandre.lureau
2026-03-17 10:34 ` Marc-André Lureau
2026-03-17 10:47 ` Daniel P. Berrangé
@ 2026-03-17 11:03 ` Paolo Bonzini
2 siblings, 0 replies; 4+ messages in thread
From: Paolo Bonzini @ 2026-03-17 11:03 UTC (permalink / raw)
To: marcandre.lureau; +Cc: qemu-devel, berrange, Philippe Mathieu-Daudé
Queued, thanks.
Paolo
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2026-03-17 11:04 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-02-11 10:33 [PATCH] build-sys: use the "run" variable marcandre.lureau
2026-03-17 10:34 ` Marc-André Lureau
2026-03-17 10:47 ` Daniel P. Berrangé
2026-03-17 11:03 ` Paolo Bonzini
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.