Re: [PATCH] lib/list_sort: introduce list_sort_nonatomic() and remove dummy cmp() calls - Kuan-Wei Chiu

From: Kuan-Wei Chiu <visitorckw@gmail.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: Richard Weinberger <richard@nod.at>,
	Andrew Morton <akpm@linux-foundation.org>,
	chengzhihao1 <chengzhihao1@huawei.com>,
	jserv <jserv@ccns.ncku.edu.tw>, eleanor15x <eleanor15x@gmail.com>,
	marscheng <marscheng@google.com>,
	linux-mtd <linux-mtd@lists.infradead.org>,
	linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] lib/list_sort: introduce list_sort_nonatomic() and remove dummy cmp() calls
Date: Wed, 18 Mar 2026 00:08:52 +0800	[thread overview]
Message-ID: <abl8lJ5_hFSRHu6-@google.com> (raw)
In-Reply-To: <abln0mfbHdueNgtD@infradead.org>

On Tue, Mar 17, 2026 at 07:40:18AM -0700, Christoph Hellwig wrote:
> On Tue, Mar 17, 2026 at 03:38:41PM +0100, Richard Weinberger wrote:
> > ----- Ursprüngliche Mail -----
> > >> For UBIFS, this patch doesn't alter the frequency, timing, or behavior
> > >> of the cond_resched() calls at all, so I am confident that this won't
> > >> introduce any regressions.
> > > 
> > > I'd be tempted to drop the workaround and remove the cond_resched
> > > from ubifs given that entirely non-preemptible scheduling models are
> > > on their way out.
> > 
> > arm32 still has no preempt-lazy.
> > This is one of the biggest platforms where UBIFS is still used.
> 
> Time to fix that if it wants to stay alive.
> 
It seems that dropping cond_resched() right now would cause issues for
UBIFS.

Given that, let's stick with current plan for now. If we reach a point
in the future where it's safe to drop these scheduling points, we can
always revisit this and remove then.

Regards,
Kuan-Wei

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/