From: Sebastian Reichel <sebastian.reichel@collabora.com>
To: Mark Brown <broonie@kernel.org>
Cc: Liam Girdwood <lgirdwood@gmail.com>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Heiko Stuebner <heiko@sntech.de>,
Alexey Charkov <alchark@gmail.com>,
linux-sound@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org,
linux-kernel@vger.kernel.org, kernel@collabora.com
Subject: Re: [PATCH 1/2] dt-bindings: ASoC: rockchip: Add compatible for RK3576 SPDIF
Date: Tue, 17 Mar 2026 18:22:14 +0100 [thread overview]
Message-ID: <abmNLwjx4FJ5N_Px@venus> (raw)
In-Reply-To: <50e2f262-6fc8-429d-af0d-5f9d1a0d6ab0@sirena.org.uk>
[-- Attachment #1: Type: text/plain, Size: 842 bytes --]
Hello Mark,
On Mon, Mar 16, 2026 at 07:44:45PM +0000, Mark Brown wrote:
> On Mon, Mar 16, 2026 at 07:23:00PM +0100, Sebastian Reichel wrote:
> > Add a compatible string for SPDIF on RK3576, which is similar to the
> > one on RK3568.
>
> Please submit patches using subject lines reflecting the style for the
> subsystem, this makes it easier for people to identify relevant patches.
> Look at what existing commits in the area you're changing are doing and
> make sure your subject lines visually resemble what they're doing.
> There's no need to resubmit to fix this alone.
Sorry, my fault. I used the same prefix as the one adding RK3588
support to the binding and forgot about the different preference for
sound DT bindings. I would have prepared a v2, but I see you already
picked it up.
Greetings,
-- Sebastian
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Sebastian Reichel <sebastian.reichel@collabora.com>
To: Mark Brown <broonie@kernel.org>
Cc: Liam Girdwood <lgirdwood@gmail.com>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Heiko Stuebner <heiko@sntech.de>,
Alexey Charkov <alchark@gmail.com>,
linux-sound@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org,
linux-kernel@vger.kernel.org, kernel@collabora.com
Subject: Re: [PATCH 1/2] dt-bindings: ASoC: rockchip: Add compatible for RK3576 SPDIF
Date: Tue, 17 Mar 2026 18:22:14 +0100 [thread overview]
Message-ID: <abmNLwjx4FJ5N_Px@venus> (raw)
In-Reply-To: <50e2f262-6fc8-429d-af0d-5f9d1a0d6ab0@sirena.org.uk>
[-- Attachment #1.1: Type: text/plain, Size: 842 bytes --]
Hello Mark,
On Mon, Mar 16, 2026 at 07:44:45PM +0000, Mark Brown wrote:
> On Mon, Mar 16, 2026 at 07:23:00PM +0100, Sebastian Reichel wrote:
> > Add a compatible string for SPDIF on RK3576, which is similar to the
> > one on RK3568.
>
> Please submit patches using subject lines reflecting the style for the
> subsystem, this makes it easier for people to identify relevant patches.
> Look at what existing commits in the area you're changing are doing and
> make sure your subject lines visually resemble what they're doing.
> There's no need to resubmit to fix this alone.
Sorry, my fault. I used the same prefix as the one adding RK3588
support to the binding and forgot about the different preference for
sound DT bindings. I would have prepared a v2, but I see you already
picked it up.
Greetings,
-- Sebastian
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
[-- Attachment #2: Type: text/plain, Size: 170 bytes --]
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
next prev parent reply other threads:[~2026-03-17 17:22 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-16 18:22 [PATCH 0/2] Add SPDIF support to RK3576 Sebastian Reichel
2026-03-16 18:22 ` Sebastian Reichel
2026-03-16 18:23 ` [PATCH 1/2] dt-bindings: ASoC: rockchip: Add compatible for RK3576 SPDIF Sebastian Reichel
2026-03-16 18:23 ` Sebastian Reichel
2026-03-16 19:44 ` Mark Brown
2026-03-16 19:44 ` Mark Brown
2026-03-17 17:22 ` Sebastian Reichel [this message]
2026-03-17 17:22 ` Sebastian Reichel
2026-03-17 7:51 ` Krzysztof Kozlowski
2026-03-17 7:51 ` Krzysztof Kozlowski
2026-03-16 18:23 ` [PATCH 2/2] arm64: dts: rockchip: Add SPDIF nodes to RK3576 device tree Sebastian Reichel
2026-03-16 18:23 ` Sebastian Reichel
2026-03-17 12:31 ` (subset) [PATCH 0/2] Add SPDIF support to RK3576 Mark Brown
2026-03-17 12:31 ` Mark Brown
2026-03-24 19:53 ` Heiko Stuebner
2026-03-24 19:53 ` Heiko Stuebner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=abmNLwjx4FJ5N_Px@venus \
--to=sebastian.reichel@collabora.com \
--cc=alchark@gmail.com \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=heiko@sntech.de \
--cc=kernel@collabora.com \
--cc=krzk+dt@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=linux-sound@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.