Re: [PATCH] rust: suggest passing --locked to "cargo install"

["Daniel P. Berrangé" <berrange@redhat.com>]

On Wed, Mar 18, 2026 at 01:27:35PM +0100, Paolo Bonzini wrote:
> On 3/18/26 10:43, Daniel P. Berrangé wrote:
> > On Wed, Mar 18, 2026 at 11:32:59AM +0200, Manos Pitsidianakis wrote:
> > > > The "cargo install bindgen-cli" command does not use QEMU's Cargo.lock,
> > > 
> > > So what does `--locked` do here? As per `--help`: "--locked Assert
> > > that `Cargo.lock` will remain unchanged" What Cargo.lock does it not
> > > change?
> > 
> > --locked ensures that cargo honours the Cargo.lock from the bindgen.git
> > repo, instead of pulling in arbitrarily newer dependencies. The
> > fixed versions of deps in bindgen's Cargo.lock are still compatible
> > with edition2021, but the latest deps are only compatible with edition2024,
> > and we need edition2021
> 
> ... and that does mean that sooner or later bindgen might update to a
> version that requires 2024 and we're out of luck.  So we could indeed add
> "--version" too, just like Manos suggested.  (Separately because this issue
> was breaking the build and Peter speed-runned the merging).
> 
> That said, support for 22.04 is going away soon and at that point "cargo
> install" will only be needed for the nightly job.  So it's not super
> necessary, either.

Indeed, as soon as this pending release of QEMU is finalized, we can
bump the min Ubuntu to 24.04

With regards,
Daniel
-- 
|: https://berrange.com       ~~        https://hachyderm.io/@berrange :|
|: https://libvirt.org          ~~          https://entangle-photo.org :|
|: https://pixelfed.art/berrange   ~~    https://fstop138.berrange.com :|