All of lore.kernel.org
 help / color / mirror / Atom feed
From: Nicolas Schier <nsc@kernel.org>
To: Mohamad Alsadhan <mo@sdhn.cc>
Cc: nathan@kernel.org, ojeda@kernel.org, gary@garyguo.net,
	miguel.ojeda.sandonis@gmail.com, linux-kbuild@vger.kernel.org,
	rust-for-linux@vger.kernel.org,
	Yoann Congal <yoann.congal@smile.fr>
Subject: Re: [PATCH v3] kbuild: host: use single executable for rustc -C linker
Date: Fri, 20 Mar 2026 07:50:15 +0100	[thread overview]
Message-ID: <abzuJ9vWuvgRKUI5@derry.ads.avm.de> (raw)
In-Reply-To: <6gyfvfiiuakmdvk6ja73kad625p52ns36k7rkdhulozthx6jkx@zlmtcljufy3b>

On Tue, Mar 17, 2026 at 02:10:27PM +0300, Mohamad Alsadhan wrote:
> On 26/03/12 02:50pm, Nicolas Schier wrote:
> > 
> > Why can't we just use this?
> > 
> >     echo 'exec $(HOSTRUSTC_LD) "$$@"' >> $@; \
> > 
> > 
> 
> I was being extra safe with quoting and escaping to make this as
> general as it can be. Just in case a more complex command with some 
> shell quoting is passed e.g.
>     `HOSTRUSTC_LD="env 'CCACHE_DIR=/tmp/my cache' ccache gcc"`

This does not work with the 'printf' variant (v4) either, as the space in
'my cache' will split the printf arguments and results in:

#!/bin/sh
exec sh -c 'exec "$0" "$@"' "env CCACHE_DIR=/tmp/my
cache ccache gcc" "$@"

Sorry, I frequently forget to handle spaces in subdir names correctly.
I'll send another suggestion as reply to v4.


-- 
Nicolas

  reply	other threads:[~2026-03-20  6:51 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20260227132713.23106-1-mo@sdhn.cc/>
2026-03-12  0:28 ` [PATCH v3] kbuild: host: use single executable for rustc -C linker Mohamad Alsadhan
2026-03-12 13:50   ` Nicolas Schier
2026-03-17 11:10     ` Mohamad Alsadhan
2026-03-20  6:50       ` Nicolas Schier [this message]
2026-03-17 11:20   ` [PATCH v4] " Mohamad Alsadhan
2026-03-20  6:51     ` Nicolas Schier
2026-03-21 14:57       ` Mohamad Alsadhan
2026-03-21 15:00     ` [PATCH v5] " Mohamad Alsadhan
2026-03-25  8:45       ` Nicolas Schier
2026-03-29  2:12         ` Mohamad Alsadhan
2026-03-29 19:46           ` Nicolas Schier
2026-03-25 14:25       ` Yoann Congal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=abzuJ9vWuvgRKUI5@derry.ads.avm.de \
    --to=nsc@kernel.org \
    --cc=gary@garyguo.net \
    --cc=linux-kbuild@vger.kernel.org \
    --cc=miguel.ojeda.sandonis@gmail.com \
    --cc=mo@sdhn.cc \
    --cc=nathan@kernel.org \
    --cc=ojeda@kernel.org \
    --cc=rust-for-linux@vger.kernel.org \
    --cc=yoann.congal@smile.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.