From: Nicolas Schier <nsc@kernel.org>
To: Mohamad Alsadhan <mo@sdhn.cc>
Cc: nathan@kernel.org, ojeda@kernel.org, gary@garyguo.net,
linux-kbuild@vger.kernel.org, rust-for-linux@vger.kernel.org,
Yoann Congal <yoann.congal@smile.fr>
Subject: Re: [PATCH v5] kbuild: host: use single executable for rustc -C linker
Date: Sun, 29 Mar 2026 21:46:52 +0200 [thread overview]
Message-ID: <acmBrKIkJ0p0zcuL@levanger> (raw)
In-Reply-To: <v5gmt4ujqfr4xjxdzkmxo2qwehglc3btvhliyqcxr2npazhuwe@potf3itpqdzn>
On Sun, Mar 29, 2026 at 05:12:41AM +0300, Mohamad Alsadhan wrote:
> Hello Nicolas,
>
> On 26/03/25 09:45am, Nicolas Schier wrote:
> > Unfortunately, I overlooked the missing entries for 'clean'/'mrproper'
> > and scripts/.gitignore. Is it ok for you if I the following diff to
> > your patch?
>
> Please go ahead, I missed those as well. Thanks for catching that!
>
> I also missed another instance where the linker is passed to `RUSTC`,
> in `rust/Makefile`, as Yoann pointed out. So it's worth considering
> adding the fix in there too.
>
> Happy to send an updated patch with the missing bits if you'd prefer,
> but I'm also fine with you folding it in.
yeah, then I'd appreciate if you send a v6 patch.
Thanks and kind regards,
Nicolas
next prev parent reply other threads:[~2026-03-29 20:12 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20260227132713.23106-1-mo@sdhn.cc/>
2026-03-12 0:28 ` [PATCH v3] kbuild: host: use single executable for rustc -C linker Mohamad Alsadhan
2026-03-12 13:50 ` Nicolas Schier
2026-03-17 11:10 ` Mohamad Alsadhan
2026-03-20 6:50 ` Nicolas Schier
2026-03-17 11:20 ` [PATCH v4] " Mohamad Alsadhan
2026-03-20 6:51 ` Nicolas Schier
2026-03-21 14:57 ` Mohamad Alsadhan
2026-03-21 15:00 ` [PATCH v5] " Mohamad Alsadhan
2026-03-25 8:45 ` Nicolas Schier
2026-03-29 2:12 ` Mohamad Alsadhan
2026-03-29 19:46 ` Nicolas Schier [this message]
2026-03-25 14:25 ` Yoann Congal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=acmBrKIkJ0p0zcuL@levanger \
--to=nsc@kernel.org \
--cc=gary@garyguo.net \
--cc=linux-kbuild@vger.kernel.org \
--cc=mo@sdhn.cc \
--cc=nathan@kernel.org \
--cc=ojeda@kernel.org \
--cc=rust-for-linux@vger.kernel.org \
--cc=yoann.congal@smile.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.