From: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
To: "Jiri Slaby (SUSE)" <jirislaby@kernel.org>
Cc: "Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
linux-serial <linux-serial@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
"Russell King" <linux@armlinux.org.uk>,
"Florian Fainelli" <f.fainelli@gmail.com>,
bcm-kernel-feedback-list@broadcom.com,
"Pali Rohár" <pali@kernel.org>,
"Kevin Cernekee" <cernekee@gmail.com>,
"Palmer Dabbelt" <palmer@dabbelt.com>,
"Paul Walmsley" <paul.walmsley@sifive.com>,
"Orson Zhai" <orsonzhai@gmail.com>,
"Baolin Wang" <baolin.wang7@gmail.com>,
"Chunyan Zhang" <zhang.lyra@gmail.com>,
"Patrice Chotard" <patrice.chotard@foss.st.com>,
linux-riscv@lists.infradead.org
Subject: Re: [PATCH v5 3/3] tty: serial: use uart_port_tx_limited()
Date: Tue, 4 Oct 2022 14:22:17 +0300 (EEST) [thread overview]
Message-ID: <ac4a5f21-fd2d-6981-eedd-1bca72a9237a@linux.intel.com> (raw)
In-Reply-To: <20221004104927.14361-4-jirislaby@kernel.org>
[-- Attachment #1: Type: text/plain, Size: 1075 bytes --]
On Tue, 4 Oct 2022, Jiri Slaby (SUSE) wrote:
> uart_port_tx_limited() is a new helper to send characters to the device.
> Use it in these drivers.
>
> mux.c also needs to define tx_done(). But I'm not sure if the driver
> really wants to wait for all the characters to dismiss from the HW fifo
> at this code point. Hence I marked this as FIXME.
>
> Cc: Russell King <linux@armlinux.org.uk>
> Cc: Florian Fainelli <f.fainelli@gmail.com>
> Cc: bcm-kernel-feedback-list@broadcom.com
> Cc: "Pali Rohár" <pali@kernel.org>
> Cc: Kevin Cernekee <cernekee@gmail.com>
> Cc: Palmer Dabbelt <palmer@dabbelt.com>
> Cc: Paul Walmsley <paul.walmsley@sifive.com>
> Cc: Orson Zhai <orsonzhai@gmail.com>
> Cc: Baolin Wang <baolin.wang7@gmail.com>
> Cc: Chunyan Zhang <zhang.lyra@gmail.com>
> Cc: Patrice Chotard <patrice.chotard@foss.st.com>
> Cc: linux-riscv@lists.infradead.org
> Signed-off-by: Jiri Slaby (SUSE) <jirislaby@kernel.org>
Perhaps you missed this one in the earlier mail. ...Anyway, here it's
again:
Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
--
i.
[-- Attachment #2: Type: text/plain, Size: 161 bytes --]
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
WARNING: multiple messages have this Message-ID (diff)
From: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
To: "Jiri Slaby (SUSE)" <jirislaby@kernel.org>
Cc: "Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
linux-serial <linux-serial@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
"Russell King" <linux@armlinux.org.uk>,
"Florian Fainelli" <f.fainelli@gmail.com>,
bcm-kernel-feedback-list@broadcom.com,
"Pali Rohár" <pali@kernel.org>,
"Kevin Cernekee" <cernekee@gmail.com>,
"Palmer Dabbelt" <palmer@dabbelt.com>,
"Paul Walmsley" <paul.walmsley@sifive.com>,
"Orson Zhai" <orsonzhai@gmail.com>,
"Baolin Wang" <baolin.wang7@gmail.com>,
"Chunyan Zhang" <zhang.lyra@gmail.com>,
"Patrice Chotard" <patrice.chotard@foss.st.com>,
linux-riscv@lists.infradead.org
Subject: Re: [PATCH v5 3/3] tty: serial: use uart_port_tx_limited()
Date: Tue, 4 Oct 2022 14:22:17 +0300 (EEST) [thread overview]
Message-ID: <ac4a5f21-fd2d-6981-eedd-1bca72a9237a@linux.intel.com> (raw)
In-Reply-To: <20221004104927.14361-4-jirislaby@kernel.org>
[-- Attachment #1: Type: text/plain, Size: 1075 bytes --]
On Tue, 4 Oct 2022, Jiri Slaby (SUSE) wrote:
> uart_port_tx_limited() is a new helper to send characters to the device.
> Use it in these drivers.
>
> mux.c also needs to define tx_done(). But I'm not sure if the driver
> really wants to wait for all the characters to dismiss from the HW fifo
> at this code point. Hence I marked this as FIXME.
>
> Cc: Russell King <linux@armlinux.org.uk>
> Cc: Florian Fainelli <f.fainelli@gmail.com>
> Cc: bcm-kernel-feedback-list@broadcom.com
> Cc: "Pali Rohár" <pali@kernel.org>
> Cc: Kevin Cernekee <cernekee@gmail.com>
> Cc: Palmer Dabbelt <palmer@dabbelt.com>
> Cc: Paul Walmsley <paul.walmsley@sifive.com>
> Cc: Orson Zhai <orsonzhai@gmail.com>
> Cc: Baolin Wang <baolin.wang7@gmail.com>
> Cc: Chunyan Zhang <zhang.lyra@gmail.com>
> Cc: Patrice Chotard <patrice.chotard@foss.st.com>
> Cc: linux-riscv@lists.infradead.org
> Signed-off-by: Jiri Slaby (SUSE) <jirislaby@kernel.org>
Perhaps you missed this one in the earlier mail. ...Anyway, here it's
again:
Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
--
i.
next prev parent reply other threads:[~2022-10-04 11:22 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-04 10:49 [PATCH v5 0/3] tty: TX helpers Jiri Slaby (SUSE)
2022-10-04 10:49 ` [PATCH v5 1/3] tty: serial: introduce transmit helpers Jiri Slaby (SUSE)
2022-10-04 10:49 ` [PATCH v5 2/3] tty: serial: use uart_port_tx() helper Jiri Slaby (SUSE)
2022-11-21 20:27 ` Michael Walle
2022-11-22 7:02 ` Jiri Slaby
2022-11-22 8:09 ` Michael Walle
2022-11-22 8:18 ` Michael Walle
2022-11-22 8:23 ` Jiri Slaby
2022-11-22 8:25 ` Jiri Slaby
2022-11-22 9:13 ` Michael Walle
2022-10-04 10:49 ` [PATCH v5 3/3] tty: serial: use uart_port_tx_limited() Jiri Slaby (SUSE)
2022-10-04 10:49 ` Jiri Slaby (SUSE)
2022-10-04 11:22 ` Ilpo Järvinen [this message]
2022-10-04 11:22 ` Ilpo Järvinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ac4a5f21-fd2d-6981-eedd-1bca72a9237a@linux.intel.com \
--to=ilpo.jarvinen@linux.intel.com \
--cc=baolin.wang7@gmail.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=cernekee@gmail.com \
--cc=f.fainelli@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=jirislaby@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=linux-serial@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=orsonzhai@gmail.com \
--cc=pali@kernel.org \
--cc=palmer@dabbelt.com \
--cc=patrice.chotard@foss.st.com \
--cc=paul.walmsley@sifive.com \
--cc=zhang.lyra@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.