* [PATCH] vhost_task_create: kill unnecessary .exit_signal initialization
@ 2026-03-22 15:19 Oleg Nesterov
2026-03-23 6:45 ` Jason Wang
0 siblings, 1 reply; 2+ messages in thread
From: Oleg Nesterov @ 2026-03-22 15:19 UTC (permalink / raw)
To: Michael S. Tsirkin, Jason Wang, Eugenio Pérez; +Cc: linux-kernel
The only reason for this janitorial change is that this initialization
adds unnecessary noise to "git grep exit_signal".
args.exit_signal has no effect with CLONE_THREAD, not to mention it is
zero-initialized by the compiler anyway.
Signed-off-by: Oleg Nesterov <oleg@redhat.com>
---
kernel/vhost_task.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/kernel/vhost_task.c b/kernel/vhost_task.c
index 3f1ed7ef0582..3717885a5992 100644
--- a/kernel/vhost_task.c
+++ b/kernel/vhost_task.c
@@ -123,7 +123,6 @@ struct vhost_task *vhost_task_create(bool (*fn)(void *),
struct kernel_clone_args args = {
.flags = CLONE_FS | CLONE_UNTRACED | CLONE_VM |
CLONE_THREAD | CLONE_SIGHAND,
- .exit_signal = 0,
.fn = vhost_task_fn,
.name = name,
.user_worker = 1,
--
2.52.0
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] vhost_task_create: kill unnecessary .exit_signal initialization
2026-03-22 15:19 [PATCH] vhost_task_create: kill unnecessary .exit_signal initialization Oleg Nesterov
@ 2026-03-23 6:45 ` Jason Wang
0 siblings, 0 replies; 2+ messages in thread
From: Jason Wang @ 2026-03-23 6:45 UTC (permalink / raw)
To: Oleg Nesterov; +Cc: Michael S. Tsirkin, Eugenio Pérez, linux-kernel
On Sun, Mar 22, 2026 at 11:20 PM Oleg Nesterov <oleg@redhat.com> wrote:
>
> The only reason for this janitorial change is that this initialization
> adds unnecessary noise to "git grep exit_signal".
>
> args.exit_signal has no effect with CLONE_THREAD, not to mention it is
> zero-initialized by the compiler anyway.
>
> Signed-off-by: Oleg Nesterov <oleg@redhat.com>
> ---
> kernel/vhost_task.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/kernel/vhost_task.c b/kernel/vhost_task.c
> index 3f1ed7ef0582..3717885a5992 100644
> --- a/kernel/vhost_task.c
> +++ b/kernel/vhost_task.c
> @@ -123,7 +123,6 @@ struct vhost_task *vhost_task_create(bool (*fn)(void *),
> struct kernel_clone_args args = {
> .flags = CLONE_FS | CLONE_UNTRACED | CLONE_VM |
> CLONE_THREAD | CLONE_SIGHAND,
> - .exit_signal = 0,
> .fn = vhost_task_fn,
> .name = name,
> .user_worker = 1,
> --
> 2.52.0
>
>
Acked-by: Jason Wang <jasowang@redhat.com>
Thanks
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-03-23 6:45 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-03-22 15:19 [PATCH] vhost_task_create: kill unnecessary .exit_signal initialization Oleg Nesterov
2026-03-23 6:45 ` Jason Wang
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.