Re: [PATCH v2] platform/x86: int3472: Handle GPIO type 0x02 (strobe) as IR flood LED

[Andy Shevchenko <andriy.shevchenko@intel.com>]

On Mon, Mar 23, 2026 at 10:35:35PM +0100, Marco Nenciarini wrote:
> GPIO type 0x02 (strobe) appears in ACPI tables on recent Intel
> Meteor Lake and Arrow Lake platforms (e.g. Dell Pro Max 14/16) for
> controlling an IR flood LED used by infrared camera sensors. The
> INT3472 discrete driver does not handle this type, logging "GPIO type
> 0x02 unknown; the sensor may not work" and potentially preventing the
> associated sensor slot from initializing cleanly.
> 
> Add support for GPIO type 0x02 by registering it as an LED through
> the existing LED framework, with the name "ir_flood_led" to
> distinguish it from the privacy LED (type 0x0d).
> 
> Rename skl_int3472_register_pled() and skl_int3472_unregister_pled()
> to skl_int3472_register_led() and skl_int3472_unregister_led(). The
> register function takes a name parameter and an optional LED lookup
> con_id. For the privacy LED, "privacy" is passed so sensor drivers
> can discover it via devm_led_get(). For the IR flood LED, NULL is
> passed to register only the LED classdev without a driver lookup,
> since no sensor driver currently consumes it.

This can be improved.

...

> +		case INT3472_GPIO_TYPE_STROBE:
> +			ret = skl_int3472_register_led(int3472, gpio,
> +						       "ir_flood_led",
> +						       NULL);
> +			if (ret)
> +				err_msg = "Failed to register LED\n";
> +
>  			break;
>  		case INT3472_GPIO_TYPE_PRIVACY_LED:
> -			ret = skl_int3472_register_pled(int3472, gpio);
> +			ret = skl_int3472_register_led(int3472, gpio,
> +						       "privacy_led",
> +						       "privacy");

Maybe pass the connection ID for a starter (separate prerequisite) and here add
a new LED and new parameter for the lookup instantiation?

>  			if (ret)
>  				err_msg = "Failed to register LED\n";

...

So, this one

> +int skl_int3472_register_led(struct int3472_discrete_device *int3472,
> +			    struct gpio_desc *gpio, const char *led_name,
> +			    const char *lookup_con_id)

Becomes first

int skl_int3472_register_led(struct int3472_discrete_device *int3472,
			    struct gpio_desc *gpio, const char *con_id)

followed by

int skl_int3472_register_led(struct int3472_discrete_device *int3472,
			    struct gpio_desc *gpio, const char *con_id,
			    bool add_lookup)


>  	/* Generate the name, replacing the ':' in the ACPI devname with '_' */
>  	snprintf(int3472->pled.name, sizeof(int3472->pled.name),
> -		 "%s::privacy_led", acpi_dev_name(int3472->sensor));
> +		 "%s::%s", acpi_dev_name(int3472->sensor), led_name);

This will be

		 "%s::%s_led", acpi_dev_name(int3472->sensor), con_id);

...

> -	int3472->pled.lookup.provider = int3472->pled.name;
> -	int3472->pled.lookup.dev_id = int3472->sensor_name;
> -	int3472->pled.lookup.con_id = "privacy";
> -	led_add_lookup(&int3472->pled.lookup);
> +	if (lookup_con_id) {
> +		int3472->pled.lookup.provider = int3472->pled.name;
> +		int3472->pled.lookup.dev_id = int3472->sensor_name;
> +		int3472->pled.lookup.con_id = lookup_con_id;
> +		led_add_lookup(&int3472->pled.lookup);
> +	}
>  
>  	return 0;

And this

	if (!add_lookup)
		return 0;

	int3472->pled.lookup.provider = int3472->pled.name;
	int3472->pled.lookup.dev_id = int3472->sensor_name;
	int3472->pled.lookup.con_id = con_id;
	led_add_lookup(&int3472->pled.lookup);

	return 0;

-- 
With Best Regards,
Andy Shevchenko