From: Alice Ryhl <aliceryhl@google.com>
To: Danilo Krummrich <dakr@kernel.org>
Cc: acourbot@nvidia.com, abdiel.janulgue@gmail.com,
daniel.almeida@collabora.com, robin.murphy@arm.com,
a.hindborg@kernel.org, ojeda@kernel.org, boqun@kernel.org,
gary@garyguo.net, bjorn3_gh@protonmail.com, lossin@kernel.org,
tmgross@umich.edu, ttabi@nvidia.com,
nouveau@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
linux-kernel@vger.kernel.org, driver-core@lists.linux.dev,
rust-for-linux@vger.kernel.org
Subject: Re: [PATCH 1/3] rust: uaccess: generalize write_dma() to accept any Coherent<T>
Date: Wed, 25 Mar 2026 11:44:23 +0000 [thread overview]
Message-ID: <acPKl5HXwd6e4Sl2@google.com> (raw)
In-Reply-To: <20260325003921.3420-1-dakr@kernel.org>
On Wed, Mar 25, 2026 at 01:39:15AM +0100, Danilo Krummrich wrote:
> Generalize write_dma() from &Coherent<[u8]> to &Coherent<T> where
> T: KnownSize + AsBytes + ?Sized. The function body only uses as_ptr()
> and size(), which work for any such T, so there is no reason to
> restrict it to byte slices.
>
> Signed-off-by: Danilo Krummrich <dakr@kernel.org>
Reviewed-by: Alice Ryhl <aliceryhl@google.com>
WARNING: multiple messages have this Message-ID (diff)
From: Alice Ryhl <aliceryhl@google.com>
To: Danilo Krummrich <dakr@kernel.org>
Cc: acourbot@nvidia.com, abdiel.janulgue@gmail.com,
daniel.almeida@collabora.com, robin.murphy@arm.com,
a.hindborg@kernel.org, ojeda@kernel.org, boqun@kernel.org,
gary@garyguo.net, bjorn3_gh@protonmail.com, lossin@kernel.org,
tmgross@umich.edu, nouveau@lists.freedesktop.org,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
driver-core@lists.linux.dev, rust-for-linux@vger.kernel.org
Subject: Re: [PATCH 1/3] rust: uaccess: generalize write_dma() to accept any Coherent<T>
Date: Wed, 25 Mar 2026 11:44:23 +0000 [thread overview]
Message-ID: <acPKl5HXwd6e4Sl2@google.com> (raw)
In-Reply-To: <20260325003921.3420-1-dakr@kernel.org>
On Wed, Mar 25, 2026 at 01:39:15AM +0100, Danilo Krummrich wrote:
> Generalize write_dma() from &Coherent<[u8]> to &Coherent<T> where
> T: KnownSize + AsBytes + ?Sized. The function body only uses as_ptr()
> and size(), which work for any such T, so there is no reason to
> restrict it to byte slices.
>
> Signed-off-by: Danilo Krummrich <dakr@kernel.org>
Reviewed-by: Alice Ryhl <aliceryhl@google.com>
next prev parent reply other threads:[~2026-03-25 11:44 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-25 0:39 [PATCH 1/3] rust: uaccess: generalize write_dma() to accept any Coherent<T> Danilo Krummrich
2026-03-25 0:39 ` [PATCH 2/3] rust: dma: generalize BinaryWriter impl for Coherent<T> Danilo Krummrich
2026-03-27 20:58 ` Danilo Krummrich
2026-03-27 20:58 ` Danilo Krummrich
2026-03-25 0:39 ` [PATCH 3/3] gpu: nova-core: use sized array for GSP log buffers Danilo Krummrich
2026-03-27 20:58 ` Danilo Krummrich
2026-03-27 20:58 ` Danilo Krummrich
2026-03-25 11:44 ` Alice Ryhl [this message]
2026-03-25 11:44 ` [PATCH 1/3] rust: uaccess: generalize write_dma() to accept any Coherent<T> Alice Ryhl
2026-03-25 13:01 ` Gary Guo
2026-03-25 13:01 ` Gary Guo
2026-03-25 13:46 ` Danilo Krummrich
2026-03-25 13:46 ` Danilo Krummrich
2026-03-25 14:55 ` Gary Guo
2026-03-25 14:55 ` Gary Guo
2026-03-26 0:39 ` Alexandre Courbot
2026-03-26 0:39 ` Alexandre Courbot
2026-03-26 13:33 ` Gary Guo
2026-03-26 13:33 ` Gary Guo
2026-03-26 18:17 ` Miguel Ojeda
2026-03-26 18:17 ` Miguel Ojeda
2026-03-27 20:58 ` Danilo Krummrich
2026-03-27 20:58 ` Danilo Krummrich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=acPKl5HXwd6e4Sl2@google.com \
--to=aliceryhl@google.com \
--cc=a.hindborg@kernel.org \
--cc=abdiel.janulgue@gmail.com \
--cc=acourbot@nvidia.com \
--cc=bjorn3_gh@protonmail.com \
--cc=boqun@kernel.org \
--cc=dakr@kernel.org \
--cc=daniel.almeida@collabora.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=driver-core@lists.linux.dev \
--cc=gary@garyguo.net \
--cc=linux-kernel@vger.kernel.org \
--cc=lossin@kernel.org \
--cc=nouveau@lists.freedesktop.org \
--cc=ojeda@kernel.org \
--cc=robin.murphy@arm.com \
--cc=rust-for-linux@vger.kernel.org \
--cc=tmgross@umich.edu \
--cc=ttabi@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.